Skip Menu |

This queue is for tickets about the TermReadKey CPAN distribution.

Report information
The Basics
Id: 25396
Status: resolved
Priority: 0/
Queue: TermReadKey
People
Owner: jns [...] gellyfish.co.uk
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: 2.30
Fixed in: (no value)

History Show all quoted text
  Mon Mar 12 19:36:06 2007 CHORNY [...] cpan.org - Ticket created
Subject: test.pl
Tests from test.pl are not properly reported to perl.cpan.testers. Can you move tests from test.pl to t/*.t ? -- Alexandr Ciornii, http://chorny.net
  Tue Mar 13 04:58:15 2007 jns [...] gellyfish.co.uk - Taken
  Tue Mar 13 05:25:59 2007 jns [...] gellyfish.co.uk - Correspondence added
Surely this is a bug in something else then rather than in Term::ReadKey (and the other couple of thousand modules that use a test.pl) you probably want to determine where exactly that bug lies and make a proper report. I'm disinclined to alter a module simply to work around a bug in someone else's tools.
  Tue Mar 13 05:26:06 2007 The RT System itself - Status changed from 'new' to 'open'
  Mon May 02 18:00:53 2011 CHORNY [...] cpan.org - Correspondence added
test.pl requires different way to report that some tests failed - setting exit status. -- Alexandr Ciornii, http://chorny.net
  Thu Apr 04 13:10:48 2013 mschwern [...] cpan.org - Correspondence added
On Tue Mar 13 05:25:59 2007, JSTOWE wrote:
Show quoted text
> Surely this is a bug in something else then rather than in Term::ReadKey

This bug is legit.  The output of test.pl is not parsed and the only measure is its exit code.  This has been since way back, there is no specification for the output of test.pl.  Your test.pl is a perfect example, it outputs lots of things which are not TAP.  DBI is an example which uses t/*.t for tests and test.pl to output some benchmarking.

Other distributions which use test.pl are in the same boat.  If they use Test::More it takes care of setting the exit code on failure.

I would suggest moving the beginning of test.pl which uses TAP up to "exit(0) unless $interactive;" into t/basic.t or something.  The rest can remain in test.pl.
  Sat Oct 26 18:07:11 2013 jns [...] gellyfish.co.uk - Correspondence added
On Thu Apr 04 13:10:48 2013, MSCHWERN wrote: Show quoted text
> On Tue Mar 13 05:25:59 2007, JSTOWE wrote:
> > Surely this is a bug in something else then rather than in > > Term::ReadKey
> > This bug is legit. The output of test.pl is not parsed and the only > measure is > its exit code. This has been since way back, there is no specification > for the > output of test.pl. Your test.pl is a perfect example, it outputs lots > of things > which are not TAP. DBI is an example which uses t/*.t for tests and > test.pl to > output some benchmarking. > > Other distributions which use test.pl are in the same boat. If they > use > Test::More it takes care of setting the exit code on failure. > > I would suggest moving the beginning of test.pl which uses TAP up to > "exit(0) > unless $interactive;" into t/basic.t or something. The rest can remain > in > test.pl.
Okay, Having thought about it for six years I've decided to do just that, after the next release I'll bump the requirements to use Test::More and leave behind anything before 5.6.2. The next release will just cover easily fixed issues :)
  Sat Oct 26 18:07:12 2013 jns [...] gellyfish.co.uk - Status changed from 'open' to 'resolved'