| Subject: | Test of Perl Minimum Version |
| Date: | Sun, 11 Mar 2007 23:01:31 +0100 |
| To: | bug-Perl-Critic-More [...] rt.cpan.org |
| From: | Heiko <heiko [...] hexco.de> |
Hello Chris,
thanks for making the perl-critic-more package!
Some feedback on version 0.13 for make test:
...
t/20_policies_modules.......ok
1/11
# Failed test 'Modules::PerlMinimumVersion - 5.005'
# at t/20_policies_modules.t line 103.
# got: '0'
# expected: '1'
t/20_policies_modules.......NOK 9# Looks like you failed 1 test of
11.
t/20_policies_modules.......dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 9
Failed 1/11 tests, 90.91% okay
I looked at the test code at line 98.
I don't see how
our $foo;
should violate the Perl minimum version 5.005.
IMO line 98 should be something like:
use 5.006;
so that minimum version testing has a version to check against.
Best regards,
Heiko