Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Simple CPAN distribution.

Report information
The Basics
Id: 25351
Status: resolved
Priority: 0/
Queue: Test-Simple

People
Owner: Nobody in particular
Requestors: djh [...] cpan.org
jeff [...] math.uh.edu
Cc: schwern [...] pobox.com
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.67
Fixed in: (no value)



CC: schwern [...] pobox.com
Subject: t/pod-coverage.t fails due to missing pod for "import_extra"
POD coverage test fails due to missing POD for import_extra. Attached patch fixes issue, added POD could stand improving though... t/pod-coverage............NOK 2/6 # Failed test 'Pod coverage on Test::More' # at t/pod-coverage.t line 23. # Coverage for Test::More is 95.7%, with 1 naked subroutine: # import_extra # Looks like you failed 1 test of 6. t/pod-coverage............dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 2 Failed 1/6 tests, 83.33% okay t/pod.....................ok
Subject: test-simple-pod-coverage.patch
diff -rup Test-Simple-0.67/lib/Test/More.pm Test-Simple-0.67a/lib/Test/More.pm --- Test-Simple-0.67/lib/Test/More.pm 2007-02-13 08:13:51.000000000 -0800 +++ Test-Simple-0.67a/lib/Test/More.pm 2007-02-13 08:18:38.000000000 -0800 @@ -162,32 +162,6 @@ sub plan { $tb->plan(@_); } - -# This implements "use Test::More 'no_diag'" but the behavior is -# deprecated. -sub import_extra { - my $class = shift; - my $list = shift; - - my @other = (); - my $idx = 0; - while( $idx <= $#{$list} ) { - my $item = $list->[$idx]; - - if( defined $item and $item eq 'no_diag' ) { - $class->builder->no_diag(1); - } - else { - push @other, $item; - } - - $idx++; - } - - @$list = @other; -} - - =head2 Test names By convention, each test is assigned a number in order. This is @@ -1380,6 +1354,7 @@ sub eq_set { ); } + =back @@ -1436,6 +1411,35 @@ B<NOTE> This behavior may go away in fu Test::More works with Perls as old as 5.004_05. +=item B<import_extra> + + This implements "use Test::More 'no_diag'" but the behavior is + deprecated. + +=cut + +sub import_extra { + my $class = shift; + my $list = shift; + + my @other = (); + my $idx = 0; + while( $idx <= $#{$list} ) { + my $item = $list->[$idx]; + + if( defined $item and $item eq 'no_diag' ) { + $class->builder->no_diag(1); + } + else { + push @other, $item; + } + + $idx++; + } + + @$list = @other; +} + =item Overloaded objects
Just posting to confirm that we also get this bug. We're using a local (private) CPAN repository and will put a patched version of Test::Simple in our private CPAN until a fix is released publicly.
import_extra() is not documented in Test::More because it is inherited from Test::Builder::Module. pod-coverage.t uses Pod::Coverage::CountParents so that Pod::Coverage considers overridden, inherited methods as documented. It has been this way for as long as the test has existed. I'm not sure why the test is failing for you. Could you check that your install of Pod::Coverage::CountParents is ok?
Subject: t/pod-coverage.t fails on v0.67 with Test::Pod::Coverage 1.06
# cd .cpan/build/Test-Simple-0.67/ cpepc210-3:~/.cpan/build/Test-Simple-0.67 # perl t/pod-coverage.t 1..6 ok 1 - Pod coverage on Test::Builder ok 2 - Pod coverage on Test::Simple not ok 3 - Pod coverage on Test::More # Failed test 'Pod coverage on Test::More' # in t/pod-coverage.t at line 23. # Coverage for Test::More is 95.7%, with 1 naked subroutine: # import_extra ok 4 - Pod coverage on Test::Builder::Module ok 5 - Pod coverage on Test::Builder::Tester ok 6 - Pod coverage on Test::Builder::Tester::Color # Looks like you failed 1 test of 6. I see from the release notes that the version of Test::Pod::Coverage may be relevant. I have "1.06" so I guess 0.67 didn't fix the problem :( Upgrading Test::Pod::Coverage to 1.08 made this problem go away, so that's a workaround. Other details of my system below: # perl -V Summary of my perl5 (revision 5 version 8 subversion 6) configuration: Platform: osname=linux, osvers=2.6.9, archname=i586-linux-thread-multi uname='linux g226 2.6.9 #1 smp tue jun 28 14:58:56 utc 2005 i686 i686 i386 gnulinux ' config_args='-ds -e -Dprefix=/usr -Dvendorprefix=/usr -Dinstallusrbinperl -Dusethreads -Di_db -Di_dbm -Di_ndbm -Di_gdbm -Duseshrplib=true -Doptimize=-O2 -march=i586 -mcpu=i686 -fmessage-length=0 -Wall -g -Wall -pipe' hint=recommended, useposix=true, d_sigaction=define usethreads=define use5005threads=undef useithreads=define usemultiplicity=define useperlio=define d_sfio=undef uselargefiles=define usesocks=undef use64bitint=undef use64bitall=undef uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBUGGING -fno-strict-aliasing -pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2 -march=i586 -mcpu=i686 -fmessage-length=0 -Wall -g -Wall -pipe', cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBUGGING -fno-strict-aliasing -pipe' ccversion='', gccversion='3.3.5 20050117 (prerelease) (SUSE Linux)', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, prototype=define Linker and Libraries: ld='cc', ldflags ='' libpth=/lib /usr/lib /usr/local/lib libs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc libc=, so=so, useshrplib=true, libperl=libperl.so gnulibc_version='2.3.4' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/lib/perl5/5.8.6/i586-linux-thread-multi/CORE' cccdlflags='-fPIC', lddlflags='-shared' Characteristics of this binary (from libperl): Compile-time options: DEBUGGING MULTIPLICITY USE_ITHREADS USE_LARGE_FILES PERL_IMPLICIT_CONTEXT Locally applied patches: SPRINTF0 - fixes for sprintf formatting issues - CVE-2005-3962 Built under linux Compiled at Dec 17 2005 03:23:29 %ENV: PERL5LIB="/home/dhoworth/progs/modules" PERLDOC_PAGER="vi" @INC: /home/dhoworth/progs/modules /usr/lib/perl5/5.8.6/i586-linux-thread-multi /usr/lib/perl5/5.8.6 /usr/lib/perl5/site_perl/5.8.6/i586-linux-thread-multi /usr/lib/perl5/site_perl/5.8.6 /usr/lib/perl5/site_perl /usr/lib/perl5/vendor_perl/5.8.6/i586-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.6 /usr/lib/perl5/vendor_perl . # uname -a Linux cpepc210-3 2.6.11.4-21.7-smp #1 SMP Thu Jun 2 14:23:14 UTC 2005 i686 i686 i386 GNU/Linux
Thanks, turns out the coverage_class option was added in TPC 1.08. Fixed.
Turns out coverage_class was added in Test::Pod::Coverage 1.08, we only required 1.00.