Bug #25133 for SVN-Web: Recent changes in Template::Toolkit makes URL:s be outputed incorrectly

Sat Feb 24 17:07:45 2007 CLAESJAC [...] cpan.org - Ticket created

Hi, recent changes to the uri filter in Template-Toolkit that converts / to %2F which causes URI:s to be incorrect everywhere. This page has more information about the change: http:// search.cpan.org/~abw/Template-Toolkit-2.18/lib/Template/Filters.pm#uri Reverting back to Template-Toolkit 2.15 solves the problem tho. Thanks for a great SVN browser /Claes

Sun Feb 25 10:53:01 2007 CLAESJAC [...] cpan.org - Subject changed from (no value) to 'Recent changes in Template::Toolkit makes URL:s be outputed incorrectly'

Tue Mar 20 17:45:51 2007 jorrit [...] ncode.nl - Correspondence added

From:

jorrit [...] ncode.nl

On Za. feb. 24 17:07:45 2007, CLAESJAC wrote: Show quoted text

> Hi, > > recent changes to the uri filter in Template-Toolkit that converts / > to %2F which causes URI:s to > be incorrect everywhere. This page has more information about the > change: http:// > search.cpan.org/~abw/Template-Toolkit-

2.18/lib/Template/Filters.pm#uri Show quoted text

> > Reverting back to Template-Toolkit 2.15 solves the problem tho. > > Thanks for a great SVN browser > > /Claes

It's insane that this bug hasn't been fixed yet: when your setup is up- to-date, SVN::Web simply does not work. You can also fix it by removing | uri from your template files, but this will probably leave you with non-compliant urls. Most browsers are however quite relaxed about this, so for me this works. Jorrit

Tue Mar 20 17:45:54 2007 The RT System itself - Status changed from 'new' to 'open'

Tue Mar 20 18:11:45 2007 nik [...] ngo.org.uk - Correspondence added

Subject:	Re: [rt.cpan.org #25133] Recent changes in Template::Toolkit makes URL:s be outputed incorrectly
Date:	Tue, 20 Mar 2007 22:10:33 +0000
To:	bug-SVN-Web [...] rt.cpan.org
From:	Nik Clayton <nik [...] ngo.org.uk>

Jorrit Schippers via RT wrote: Show quoted text

> Queue: SVN-Web > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=25133 > > > On Za. feb. 24 17:07:45 2007, CLAESJAC wrote:

>> Hi, >> >> recent changes to the uri filter in Template-Toolkit that converts / >> to %2F which causes URI:s to >> be incorrect everywhere. This page has more information about the >> change: http:// >> search.cpan.org/~abw/Template-Toolkit-

> 2.18/lib/Template/Filters.pm#uri

>> Reverting back to Template-Toolkit 2.15 solves the problem tho. >> >> Thanks for a great SVN browser >> >> /Claes

> > It's insane that this bug hasn't been fixed yet: when your setup is up- > to-date, SVN::Web simply does not work. You can also fix it by > removing | uri from your template files, but this will probably leave > you with non-compliant urls. Most browsers are however quite relaxed > about this, so for me this works.

And as and when I have a couple of free hours in which to write a fix, test it, and prepare a new distribution of SVN::Web I'll do so. However, at the moment, I'm rather busy in real life, and expect to be until the first week in April. Patches gratefully received. Either that, or a laptop, so I can use the hours I currently spend commuting doing productive open source work. N

Mon Apr 09 14:06:08 2007 NIKC [...] cpan.org - Correspondence added

Could you try the patch at http://jc.ngo.org.uk/~nik/tt.patch please. It passes all my local tests, and looks good, but a little more exposure would help before I cut a release.

Mon Apr 09 14:08:02 2007 NIKC [...] cpan.org - Taken

Sun Apr 22 10:25:46 2007 NIKC [...] cpan.org - Correspondence added

Fixed in r1302 (http://jc.ngo.org.uk:80/svnweb/jc/revision/?rev=1302). I'll be releasing 0.53 shortly which will include this change. Many thanks for the report.

Sun Apr 22 10:25:50 2007 NIKC [...] cpan.org - Status changed from 'open' to 'resolved'