Bug #25131 for CGI: Needs Test: do not clobber $

Sat Feb 24 16:15:52 2007 at [...] altlinux.ru - Ticket created

Subject:	[PATCH] CGI.pm (init): do not clobber $_
Date:	Sun, 25 Feb 2007 00:36:35 +0300
To:	bug-cgi.pm [...] rt.cpan.org
From:	Alexey Tourbin <at [...] altlinux.ru>

--- CGI.pm | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/CGI.pm b/CGI.pm index 96232da..b87f178 100644 --- a/CGI.pm +++ b/CGI.pm @@ -559,6 +559,7 @@ sub init { } if (defined($fh) && ($fh ne '')) { + local $_; while (<$fh>) { chomp; last if /^=/; @@ -574,6 +575,7 @@ sub init { } if (defined($fh) && ($fh ne '')) { + local $_; while (<$fh>) { chomp; last if /^=/; -- 1.5.0.1.GIT

Wed Jul 22 22:02:24 2009 MARKSTOS [...] cpan.org - Taken

Wed Jul 22 22:02:49 2009 MARKSTOS [...] cpan.org - Subject changed from '[PATCH] CGI.pm (init): do not clobber $_' to 'Needs Test: do not clobber $_ in init. '

Wed Jul 22 22:03:35 2009 MARKSTOS [...] cpan.org - Correspondence added

Thanks for the patch! To move this forward, next we'll need an automated test that illustrates the problem with the unpatched code. Mark On Sat Feb 24 16:15:52 2007, at@altlinux.ru wrote: Show quoted text

> --- > CGI.pm | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/CGI.pm b/CGI.pm > index 96232da..b87f178 100644 > --- a/CGI.pm > +++ b/CGI.pm > @@ -559,6 +559,7 @@ sub init { > } > > if (defined($fh) && ($fh ne '')) { > + local $_; > while (<$fh>) { > chomp; > last if /^=/; > @@ -574,6 +575,7 @@ sub init { > } > > if (defined($fh) && ($fh ne '')) { > + local $_; > while (<$fh>) { > chomp; > last if /^=/;

Wed Jul 22 22:03:35 2009 The RT System itself - Status changed from 'new' to 'open'

Sun Aug 23 17:37:13 2009 BUBAFLUB [...] cpan.org - Correspondence added

On Wed Jul 22 22:03:35 2009, MARKSTOS wrote: Show quoted text

> Thanks for the patch! > > To move this forward, next we'll need an automated test that illustrates > the problem with the unpatched code. > > Mark > >

Attached is a patch for both an automated test and the fix. You can also see it at http://github.com/bubaflub/CGI.pm/commit/759c8385eb3a371309b869be76c49a6880ddd73a.

From 759c8385eb3a371309b869be76c49a6880ddd73a Mon Sep 17 00:00:00 2001 From: Bob Kuo <bob@celect.org> Date: Sun, 23 Aug 2009 16:33:00 -0500 Subject: [PATCH] closes RT #25131 - do not clobber $_ in init --- lib/CGI.pm | 1 + t/init.t | 13 +++++++++++++ t/init_test.txt | 3 +++ 3 files changed, 17 insertions(+), 0 deletions(-) create mode 100644 t/init.t create mode 100644 t/init_test.txt diff --git a/lib/CGI.pm b/lib/CGI.pm index eec56cb..3f64320 100644 --- a/lib/CGI.pm +++ b/lib/CGI.pm @@ -615,6 +615,7 @@ sub init { } if (defined($fh) && ($fh ne '')) { + local $_; while (<$fh>) { chomp; last if /^=$/; diff --git a/t/init.t b/t/init.t new file mode 100644 index 0000000..532a277 --- /dev/null +++ b/t/init.t @@ -0,0 +1,13 @@ +#!/usr/bin perl -w + +use strict; +use Test::More tests => 1; + +use CGI; + + +$_ = "abcdefghijklmnopq"; +my $IN; +open ($IN, "t/init_test.txt"); +my $q = CGI->new($IN); +is($_, 'abcdefghijklmnopq', 'make sure not to clobber $_ on init'); diff --git a/t/init_test.txt b/t/init_test.txt new file mode 100644 index 0000000..3101583 --- /dev/null +++ b/t/init_test.txt @@ -0,0 +1,3 @@ +A=B +D=F +G=H -- 1.6.3.1

Sun Aug 23 22:14:57 2009 MARKSTOS [...] cpan.org - Correspondence added

Thanks for the report and patch. This is now resolved in my github repo.

Sun Aug 23 22:14:58 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'patched'

Wed Sep 09 22:06:43 2009 MARKSTOS [...] cpan.org - Correspondence added

Subject:

Thanks, released

The patch for this ticket has now been released in CGI.pm 3.47, and this ticket is considered resolved. Thanks again for you help to improve CGI.pm! Mark

Wed Sep 09 22:06:44 2009 The RT System itself - Status changed from 'patched' to 'open'

Wed Sep 09 22:06:48 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'

Fri May 23 14:28:45 2014 The RT System itself - Queue changed from CGI.pm to CGI

Bug #25131 for CGI: Needs Test: do not clobber $_ in init.

Preferred bug tracker