Bug #25032 for Image-Info: Patch to fix TIFF ASCII text field handling

Mon Feb 19 10:35:13 2007 ben [...] qolc.net - Ticket created

Subject:

Off-by-one error in TIFF text field handling

I fixed this a while ago but looks like I forgot to call it in. ASCII text TIFF tags weren't being handled correctly -- basically you'd get an array of characters, when a string would be rather more useful. The attached patch fixes this; also adds support for the DocumentName tag, and tidies up the change made in 1.23 (there is already a check for whether the total length is <= 4 bytes immediately before the code that was added in 1.23, so this has been merged upwards), and a slight tidyup of the rational handling in the same block which was needlessly nested. The tests work with the existing TIFF test image. Best regards, Ben

Subject:

patch

Download patch
application/octet-stream 3.7k

Message body not shown because it is not plain text.

Mon Feb 19 10:36:06 2007 ben [...] qolc.net - Status changed from 'new' to 'open'

Mon Feb 19 10:36:59 2007 ben [...] qolc.net - Status changed from 'open' to 'new'

Mon Feb 19 10:37:04 2007 ben [...] qolc.net - Broken in 1.23 added

Mon Feb 19 10:37:27 2007 ben [...] qolc.net - Subject changed from 'Off-by-one error in TIFF text field handling' to 'Patch to fix TIFF ASCII text field handling'

Sun Feb 25 07:25:39 2007 TELS [...] cpan.org - Taken

Sun Feb 25 07:43:50 2007 TELS [...] cpan.org - TimeWorked changed from (no value) to '10'

Sun Feb 25 07:45:18 2007 TELS [...] cpan.org - Correspondence added

Thanx a lot for the patch, I applied it and released v1.24 to CPAN.

Sun Feb 25 07:45:23 2007 The RT System itself - Status changed from 'new' to 'open'

Sun Feb 25 07:45:26 2007 TELS [...] cpan.org - Status changed from 'open' to 'resolved'