Bug #24832 for Test-Kwalitee: problem with Test::Kwalitee

Wed Feb 07 04:36:32 2007 casiano [...] ull.es - Ticket created

Subject:	problem with Test::Kwalitee
Date:	Wed, 7 Feb 2007 09:28:36 +0000 (WET)
To:	chromatic [...] wgz.org
From:	Casiano Rodriguez Leon <casiano [...] ull.es>

Dear Chromatic, First, let me thank you for your book "Perl Testing". Is great. And thanks for your modules too. I have unsuccessfully attempted to upload to CPAN a distribution of a new module I am working with. The attached file contains the distribution. I have successfully installed this version of the module on several local machines. What I have found is that Test::Kwalitee hangs when running on this distribution: nereida:~/src/perl/YappWithDefaultAction> cat -n t/98kwalitee.t 1 eval { require Test::Kwalitee }; 2 exit if $@; 3 Test::Kwalitee->import(); nereida:~/src/perl/YappWithDefaultAction> perl t/98kwalitee.t 1..13 ok 1 - extractable ok 2 - has_readme ok 3 - has_manifest ok 4 - has_meta_yml ok 5 - has_buildtool ok 6 - has_changelog ok 7 - no_symlinks ok 8 - has_tests ok 9 - proper_libs ok 10 - no_pod_errors The other tests 11, 12 and 13 never have the chance to finish. I ignore the reason. The last distribution works fine: nereida:/tmp/Parse-Eyapp-1.06555> perl t/98kwalitee.t 1..13 ok 1 - extractable ok 2 - has_readme ok 3 - has_manifest ok 4 - has_meta_yml ok 5 - has_buildtool ok 6 - has_changelog ok 7 - no_symlinks ok 8 - has_tests # Looks like you planned 13 tests but only ran 8. # Looks like your test died just after 8. Hope you can help Best wishes Casiano Address: Casiano Rodriguez Leon Dpto. de Estadistica IO y Computacion Edificio Fisica/Matematicas Universidad de La Laguna Calle Astrofisico Fco. Sanchez s/n 38271 La Laguna. Tenerife. Spain phone: 34 922 318187 318169 fax: 34 922 318170 email: casiano@ull.es web http://nereida.deioc.ull.es/

Download Parse-Eyapp-1.067.tar.gz
application/octet-stream 181.3k

Message body not shown because it is not plain text.

Wed Feb 07 09:43:56 2007 casiano [...] ull.es - Correspondence added

Subject:	Re: [rt.cpan.org #24832] problem with Test::Kwalitee and Module::CPANTS::Kwalitee
Date:	Wed, 7 Feb 2007 14:43:03 +0000 (WET)
To:	Bugs in Test-Kwalitee via RT <bug-Test-Kwalitee [...] rt.cpan.org>
From:	Casiano Rodriguez Leon <casiano [...] ull.es>

Dear CPAN maintainers, It seems that the problem is likely in Module::CPANTS::Kwalitee. See below. After a while I have seen the hang occurs in function "analyse" of "Module::CPANTS::Kwalitee" due to line 20 my @tests=grep {m|^t/|} @$files; that probably has to be s.t. like: 20 my @tests=grep {m|^t/.*\.t$|} @$files; or perhaps better, has to be the list of .t files in the MANIFEST. I also had to move out a large test file (is a C++ grammar used for testing): -rwxr-x--x 1 pl users 5206663 2007-02-07 10:35 99Cplusplusgrammar.t out of the way to get kwalitee finished (In spite that this test helps to improve the quality of the distribution :-). I have modified that line in my installation of Module::CPANTS::Kwalitee and now it works (but after moving out of t/ the file 99Cplusplusgrammar.t. May be there is some limitations in the size of tests that kwalitee modules can manage?) Unfortunately the previous distributions are still hanged in my CPAN directory: Index of ftp://pause.perl.org/tmp/C/CA/CASIANO/ Up to higher level directory File: Parse-Eyapp-1.06559.tar.gz 367 KB 06/02/07 13:02:00 File: Parse-Eyapp-1.06600.tar.gz 367 KB 06/02/07 16:09:00 File: Parse-Eyapp-1.067.tar.gz 182 KB 07/02/07 11:42:00 File: Parse-Eyapp-1.068.tar.gz 182 KB 07/02/07 13:12:00 and I guess that hidden files can prevent me of doing any uploads in the future. In spite the email I received, it seems as if the automatic systems hasn't changed the name. Can someone delete them? Hope you can help Apologies for being so insistent. Best wishes Casiano Address: Casiano Rodriguez Leon Dpto. de Estadistica IO y Computacion Edificio Fisica/Matematicas Universidad de La Laguna Calle Astrofisico Fco. Sanchez s/n 38271 La Laguna. Tenerife. Spain phone: 34 922 318187 318169 fax: 34 922 318170 email: casiano@ull.es web http://nereida.deioc.ull.es/

Thu Apr 05 01:46:01 2007 chris+rt [...] chrisdolan.net - Correspondence added

On Wed Feb 07 04:36:32 2007, casiano@ull.es wrote: Show quoted text

> 1..13 > ok 1 - extractable > ok 2 - has_readme > ok 3 - has_manifest > ok 4 - has_meta_yml > ok 5 - has_buildtool > ok 6 - has_changelog > ok 7 - no_symlinks > ok 8 - has_tests > # Looks like you planned 13 tests but only ran 8. > # Looks like your test died just after 8.

I'm seeing this too. My guess is that Test::Kwalitee has fallen out of sync with Module::CPANTS::Kwalitee. Test::Kwalitee hard codes the names of the Kwalitee tests. The correct list as of M::C::A v0.69 is like so: % perl -le'use Module::CPANTS::Kwalitee;print $_->{name} for Module::CPANTS::Kwalitee->new->get_indicators' extractable extracts_nicely has_readme has_manifest has_meta_yml has_buildtool has_changelog no_symlinks has_tests buildtool_not_executable has_example has_version has_proper_version metayml_is_parsable metayml_has_license metayml_conforms_spec_1_0 metayml_conforms_spec_1_2 proper_libs no_pod_errors is_prereq has_working_buildtool use_strict has_test_pod has_test_pod_coverage has_humanreadable_license manifest_matches_dist no_cpants_errors

Thu Apr 05 01:46:04 2007 The RT System itself - Status changed from 'new' to 'open'

Thu Apr 05 21:10:46 2007 MTHURN [...] cpan.org - Correspondence added

On Wed Feb 07 04:36:32 2007, casiano@ull.es wrote: Show quoted text

> 1..13 > ok 1 - extractable > ok 2 - has_readme > ok 3 - has_manifest > ok 4 - has_meta_yml > ok 5 - has_buildtool > ok 6 - has_changelog > ok 7 - no_symlinks > ok 8 - has_tests > # Looks like you planned 13 tests but only ran 8. > # Looks like your test died just after 8.

For me (ActivePerl 819 on WinXP), this problem was fixed by applying the patches to the Module-CPANTS-Analyse distro as described in this thread: https://rt.cpan.org/Ticket/Display.html?id=25207 -- - - Martin 'Kingpin' Thurn

Sun Jan 13 19:30:03 2008 greg [...] turnstep.com - Correspondence added

Subject:	Test::Kwalitee dies 'just after 8'
From:	greg [...] turnstep.com

Show quoted text

> > ok 8 - has_tests > > # Looks like you planned 13 tests but only ran 8. > > # Looks like your test died just after 8.

Any progress on this? I'm seeing the same problem on a Linux box. If I rearrange the tests by inclusion/exclusion, it still happens, but there seems to be little rhyme or reason, e.g. it's not caused by any particular test. I can provide test cases or do further debugging if needed.

Sun Mar 31 16:49:01 2013 ether [...] cpan.org - Correspondence added

Fixed via RT#25207 in Module-CPANTS-Analyse.

Sun Mar 31 16:49:01 2013 ether [...] cpan.org - Status changed from 'open' to 'resolved'