Bug #24727 for Date-Calc: Starting dates on US holidays missing, also aliases.

Thu Feb 01 14:09:52 2007 mschwern [...] cpan.org - Ticket created

Subject:

Starting dates on US holidays missing, also aliases.

Most US holidays do not go back to the beginning of time. Some, like MLK, are fairly recent. Date::Calendar should make a note of these lower bounds. Additionally, the popular names of the holidays and the official names are often different. "President's Day" is still officially "Washington's Birthday". Date::Calendar should provide aliases. See this wikipedia page for a discussion. http://en.wikipedia.org/wiki/US_holidays

Mon Jul 27 11:20:23 2009 STBEY [...] cpan.org - Correspondence added

On Thu Feb 01 14:09:52 2007, MSCHWERN wrote: Show quoted text

> Most US holidays do not go back to the beginning of time. Some, like > MLK, are fairly recent. Date::Calendar should make a note of these > lower bounds. > > Additionally, the popular names of the holidays and the official names > are often different. "President's Day" is still officially > "Washington's Birthday". Date::Calendar should provide aliases. > > See this wikipedia page for a discussion. > http://en.wikipedia.org/wiki/US_holidays

Please provide patches. Better still, make a new version of the module with the changes you want included.

Mon Jul 27 11:20:24 2009 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 27 11:20:25 2009 STBEY [...] cpan.org - Status changed from 'open' to 'stalled'

Mon Jul 27 11:34:45 2009 STBEY [...] cpan.org - Correspondence added

It is documented that this module doesn't take historic irregularities into account. Provide your own profiles (possibly based on the ones supplied, by overriding certain definitions using the same hash key).

Mon Jul 27 11:34:45 2009 The RT System itself - Status changed from 'stalled' to 'open'

Mon Jul 27 11:34:46 2009 STBEY [...] cpan.org - Status changed from 'open' to 'rejected'

Tue Jul 28 13:43:00 2009 mschwern [...] cpan.org - Correspondence added

On Mon Jul 27 11:34:45 2009, STBEY wrote: Show quoted text

> It is documented that this module doesn't take historic irregularities > into account. Provide your own profiles (possibly based on the ones > supplied, by overriding certain definitions using the same hash key).

Sorry, I can't find that documentation anywhere. Perhaps it should be listed in the bugs/limitations section? Skimming the docs gives the impression that it deals with history quite well. They start on page one talking about how it doesn't have the year limitations of DCY. Everything else about the holiday calculations is so detailed going down to individual US states and half holidays. But it sounds like you're not interested in maintaining this any more. What's the story with this release? http://search.cpan.org/~tchatzi/Date-Calc/

Tue Jul 28 13:43:01 2009 The RT System itself - Status changed from 'rejected' to 'open'

Wed Jul 29 01:04:54 2009 STBEY [...] cpan.org - Correspondence added

On Tue Jul 28 13:43:00 2009, MSCHWERN wrote: Show quoted text

> Sorry, I can't find that documentation anywhere. Perhaps it should be > listed in the bugs/limitations section?

You are right, it is not documented in the documentation proper, but in ./examples/calendar.cgi: <TD ALIGN="center" COLSPAN="3">${RED}Note: Historical irregularities are (usually) not taken into account!${END}</TD> (I knew I had written it somewhere! :-) ) Show quoted text

> Skimming the docs gives the impression that it deals with history quite > well.

Thank you! :-) Show quoted text

> They start on page one talking about how it doesn't have the year > limitations of DCY. Everything else about the holiday calculations is > so detailed going down to individual US states and half holidays.

It is possible in principle to account for all of this, but obviously I cannot do that for all of the calendar events which exist around the world... Show quoted text

> But it sounds like you're not interested in maintaining this any more.

In fact I do not have the time anymore to do much support on these modules. Besides, the list of tiny little change requests is almost endless, and I'd never be done with satisfying everybody. So I suggest that you take the Profiles in the module as examples, copy them into your code and modify them at will. Another possibility is to import profiles and to modify them at runtime, by overriding certain entries, by using the same hash keys. Show quoted text

> What's the story with this release? > http://search.cpan.org/~tchatzi/Date-Calc/

Someone has modified the module to include the Orthodox and Julian calendars (which are outside the scope of my module, and for which there are other Perl modules specializing in them) and has uploaded this new version to CPAN, which has created confusion because it was (and is) not authorized. It appears the author just wanted his private version of the module to be accessible from anywhere. Cheers!

Wed Jul 29 01:04:56 2009 STBEY [...] cpan.org - Status changed from 'open' to 'rejected'

Mon Aug 10 11:30:57 2009 STBEY [...] cpan.org - Correspondence added

On Tue Jul 28 13:43:00 2009, MSCHWERN wrote: Show quoted text

> Sorry, I can't find that documentation anywhere. Perhaps it should be > listed in the bugs/limitations section?

See also here: http://guest.engelschall.com/u/sb/download/Date-Calc/ Limitations * The calendar profiles usually do not take historical irregularities into account, they only provide means for calculating _regularly_ recurring events (the profiles should therefore not be relied on for historical faithfulness)

Mon Aug 10 11:30:59 2009 The RT System itself - Status changed from 'rejected' to 'open'

Mon Aug 10 11:32:21 2009 STBEY [...] cpan.org - Status changed from 'open' to 'rejected'

Mon Aug 10 19:08:48 2009 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #24727] Starting dates on US holidays missing, also aliases.
Date:	Mon, 10 Aug 2009 16:08:27 -0700
To:	bug-Date-Calc [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

Steffen_Beyer via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=24727 > > > On Tue Jul 28 13:43:00 2009, MSCHWERN wrote: >

>> Sorry, I can't find that documentation anywhere. Perhaps it should be >> listed in the bugs/limitations section?

> > See also here: > > http://guest.engelschall.com/u/sb/download/Date-Calc/ > > Limitations > > * The calendar profiles usually do not take historical > irregularities into account, they only provide means for calculating > _regularly_ recurring events (the profiles should therefore not be > relied on for historical faithfulness)

Thank you for pointing it out. That could be moved somewhere a user is likely to find it, like into the Date::Calendar docs. In fact, if there's any information in that URL which is not in Date::Calc proper it should be moved into the perldoc. Its not enough for the docs to be written down somewhere, it has to be written down where it will be found. Show quoted text

> Someone has modified the module to include the Orthodox and Julian > calendars (which are outside the scope of my module, and for which there > are other Perl modules specializing in them) and has uploaded this new > version to CPAN, which has created confusion because it was (and is) not > authorized. It appears the author just wanted his private version of the > module to be accessible from anywhere.

Perhaps you should offer that person maintainership. They've already taken an interest in the module and demonstrated the drive to make a patch and upload a release. -- I have a date with some giant cartoon robots and booze.

Mon Aug 10 19:08:49 2009 The RT System itself - Status changed from 'rejected' to 'open'

Tue Aug 11 07:08:10 2009 STBEY [...] cpan.org - Correspondence added

On Mon Aug 10 19:08:48 2009, schwern@pobox.com wrote: Show quoted text

> Thank you for pointing it out. That could be moved somewhere a user > is likely > to find it, like into the Date::Calendar docs. In fact, if there's > any > information in that URL which is not in Date::Calc proper it should be > moved > into the perldoc. Its not enough for the docs to be written down > somewhere, > it has to be written down where it will be found.

I strongly agree. Noted and scheduled for the next release. Show quoted text

> Perhaps you should offer that person maintainership. They've already > taken an > interest in the module and demonstrated the drive to make a patch and > upload a > release.

Maybe. The person didn't seem to be actually interested in taking over maintenance altogether; if I understood him correctly, he just wanted his private version to be accessible from anywhere, and thought uploading to CPAN would be a good way to do so.

Fri Aug 21 17:33:15 2009 STBEY [...] cpan.org - Correspondence added

This is fixed in the next version 5.7 of Date::Calc, to be released soon, plus the new module Date::Calc::Util.

Fri Aug 21 17:33:17 2009 STBEY [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Aug 24 02:23:44 2009 STBEY [...] cpan.org - Correspondence added

On Thu Feb 01 14:09:52 2007, MSCHWERN wrote: Show quoted text

> Additionally, the popular names of the holidays and the official names > are often different. "President's Day" is still officially > "Washington's Birthday". Date::Calendar should provide aliases. > > See this wikipedia page for a discussion. > http://en.wikipedia.org/wiki/US_holidays

Since I am still waiting for a confirmation that Bit::Vector 7.0 tests ok on Darwin (where it had a minor glitch), and since Date::Calc 5.7 depends on BV 7, it may be another couple of days until its release. In the meantime, you can already see the changes at work here: http://guest.engelschall.com/~sb/calendar/?language=1&country=US&select=0&myear=2009&week=31&month=8&wyear=2009&fullyear=2

Mon Aug 24 02:23:45 2009 The RT System itself - Status changed from 'resolved' to 'open'

Mon Aug 24 02:23:46 2009 STBEY [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Aug 29 00:48:46 2009 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #24727] Starting dates on US holidays missing, also aliases.
Date:	Fri, 28 Aug 2009 21:48:08 -0700
To:	bug-Date-Calc [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

Steffen_Beyer via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=24727 > > > On Thu Feb 01 14:09:52 2007, MSCHWERN wrote: >

>> Additionally, the popular names of the holidays and the official names >> are often different. "President's Day" is still officially >> "Washington's Birthday". Date::Calendar should provide aliases. >> >> See this wikipedia page for a discussion. >> http://en.wikipedia.org/wiki/US_holidays

> > Since I am still waiting for a confirmation that Bit::Vector 7.0 tests > ok on Darwin (where it had a minor glitch), and since Date::Calc 5.7 > depends on BV 7, it may be another couple of days until its release.

By Darwin do you mean OS X or GNU Darwin? I've just tested it on OS X 10.5.8 with 5.10.0 and it works fine. -- Being faith-based doesn't trump reality. -- Bruce Sterling

Sat Aug 29 00:48:47 2009 The RT System itself - Status changed from 'resolved' to 'open'

Fri Sep 11 16:31:39 2009 sb [...] engelschall.com - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #24727] Starting dates on US holidays missing, also aliases.
Date:	Fri, 11 Sep 2009 22:31:19 +0200
To:	Michael G Schwern via RT <bug-Date-Calc [...] rt.cpan.org>
From:	Steffen Beyer <sb [...] engelschall.com>

Hello Michael G Schwern via RT, in a previous mail you wrote: Show quoted text

> By Darwin do you mean OS X or GNU Darwin? I've just tested it on OS X 10.5.8 > with 5.10.0 and it works fine.

Unfortunately, I don't know myself for sure, because I don't have any recent Mac and I don't know anything about OS X or GNU Darwin. This is the original bug report I got: Show quoted text

> Hi Steffen, > > I tried to install your module Bit::Vector 6.6 (perl v5.8.6 on a PowerPC > G5 Mac Os X v10.4.11) but it failed the test '28___chunklist.t'. > > I ran the test outside of Test::Harness, and found it is failing on the > final value of $bits (=33) at $n=97 and $n=99. > > Is this a test-glitch, or a bug? If I force install, is it likely to > break anything? > > Thanks for any help,

So it seems that OS X is meant. I thought MacOS X and Darwin were synonyms? Best regards, -- Steffen Beyer <sb@engelschall.com> http://www.engelschall.com/u/sb/whoami/ (Who am I) http://www.engelschall.com/u/sb/gallery/ (Fotos Brasil, USA, ...) http://www.engelschall.com/u/sb/download/ (Free Perl and C Software)

Fri Sep 11 16:34:52 2009 STBEY [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Sep 11 23:26:08 2009 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #24727] Starting dates on US holidays missing, also aliases.
Date:	Fri, 11 Sep 2009 20:25:46 -0700
To:	bug-Date-Calc [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

sb@engelschall.com via RT wrote: Show quoted text

>> Hi Steffen, >> >> I tried to install your module Bit::Vector 6.6 (perl v5.8.6 on a PowerPC >> G5 Mac Os X v10.4.11) but it failed the test '28___chunklist.t'.

That's an out of date version of OS X (10.6.1 was just released, most OS X users stay up to date) running on out of date hardware. It could be the PowerPC messing things up as its big-endian. Anyhow, its an uncommon setup so I wouldn't let it hold up release. IMO I'd release it and let it fail to get more info. Show quoted text

> So it seems that OS X is meant. > > I thought MacOS X and Darwin were synonyms?

OS X is to Darwin as Debian is to Linux. Though my question is out of date. It seems OS X has killed off most of the other Darwin distributions. It seems to have gotten good enough that nobody else is bothering. -- 60. "The Giant Space Ants" are not at the top of my chain of command. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/

Fri Sep 11 23:26:09 2009 The RT System itself - Status changed from 'resolved' to 'open'

Sun Sep 13 14:58:08 2009 STBEY [...] cpan.org - Status changed from 'open' to 'resolved'