Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 24684
Status: resolved
Priority: 0/
Queue: CGI
People
Owner: MARKSTOS [...] cpan.org
Requestors: callumgibson [...] optusnet.com.au
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jan 30 23:20:34 2007 callumgibson [...] optusnet.com.au - Ticket created
Subject: uninitialized value with startform with non-apache webserver
Date: 31 Jan 2007 15:20:16 +1100
Date: Wed, 31 Jan 2007 15:20:16 +1100
To: bug-CGI.pm [...] rt.cpan.org
From: Callum Gibson <callumgibson [...] optusnet.com.au>
startform calls request_uri() which returns $ENV{REQUEST_URI} which is an Apache-specific environment variable. This has been a recurring issue since it was introduced and all code now seems to check if request_uri is defined upon use, but calling $self->request_uri causes an "uninitialized value" warning if you run your CGI under perl -w using a non-Apache webserver. Since undefined values of request_uri appear to be already handled, modifying the subroutine request_uri to the following would seem to be sufficient: sub request_uri { return $ENV{'REQUEST_URI'} if defined($ENV{REQUEST_URI}); return undef; } -- Callum Gibson @ home http://members.optusnet.com.au/callumgibson/
  Wed Jul 22 21:29:30 2009 MARKSTOS [...] cpan.org - Taken
  Wed Jul 22 21:29:42 2009 MARKSTOS [...] cpan.org - Broken in 3.43 added
  Wed Jul 22 21:29:50 2009 MARKSTOS [...] cpan.org - Subject changed from 'uninitialized value with startform with non-apache webserver' to 'PATCH: uninitialized value with startform with non-apache webserver'
  Wed Jul 22 21:31:49 2009 MARKSTOS [...] cpan.org - Correspondence added
On Tue Jan 30 23:20:34 2007, callumgibson@optusnet.com.au wrote: Show quoted text
> startform calls request_uri() which returns $ENV{REQUEST_URI} which is > an Apache-specific environment variable. This has been a recurring issue > since it was introduced and all code now seems to check if request_uri > is defined upon use, but calling $self->request_uri causes an > "uninitialized value" warning if you run your CGI under perl -w using > a non-Apache webserver. > > Since undefined values of request_uri appear to be already handled, > modifying the subroutine request_uri to the following would seem to > be sufficient: > > sub request_uri { > return $ENV{'REQUEST_URI'} if defined($ENV{REQUEST_URI}); > return undef; > }
Thanks for the report. I agree a change like this should be made, although I might express it a bit differently: return (defined $ENV{REQUEST_URI}) ? $ENV{REQUEST_URI} : undef; It seems some related routines like path_translated and content_type might as well get the same treatment. Mark
  Wed Jul 22 21:31:49 2009 The RT System itself - Status changed from 'new' to 'open'
  Fri Jul 31 22:28:35 2009 MARKSTOS [...] cpan.org - Correspondence added
Thanks, this patch is now in our new git repo. Stalling till launch.
  Fri Jul 31 22:28:37 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'patched'
  Fri Aug 14 21:41:21 2009 MARKSTOS [...] cpan.org - Correspondence added
Subject: released, thanks.
I believe this change was released today as part of CGI.pm 3.45. Thanks for the contribution.
  Fri Aug 14 21:41:22 2009 The RT System itself - Status changed from 'patched' to 'open'
  Fri Aug 14 21:41:23 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri May 23 14:28:44 2014 The RT System itself - Queue changed from CGI.pm to CGI