Bug #24671 for svk: Tests fail when Locale::Maketext::Simple isn't installed

Building svk-2.0.0 on Debian/etch with upgraded modules such that the core dependancy checks are met: (Harder than it looks ^_^) [Core Features] - Test::More ...loaded. (0.620 >= 0.42) - version ...loaded. (0.680 >= 0.68) - Algorithm::Annotate ...loaded. (0.100) - Algorithm::Diff ...loaded. (1.190100 >= 1.1901) - YAML::Syck ...loaded. (0.710 >= 0.60) - Data::Hierarchy ...loaded. (0.340 >= 0.30) - PerlIO::via::dynamic ...loaded. (0.110 >= 0.11) - PerlIO::via::symlink ...loaded. (0.050 >= 0.02) - IO::Digest ...loaded. (0.100) - SVN::Simple::Edit ...loaded. (0.270 >= 0.27) - URI ...loaded. (1.350) - PerlIO::eol ...loaded. (0.130 >= 0.13) - Class::Autouse ...loaded. (1.230 >= 1.15) - App::CLI ...loaded. (0.070) - List::MoreUtils ...loaded. (0.210) - Class::Accessor::Fast ...loaded. (0.300) - Class::Data::Inheritable ...loaded. (0.040) - Path::Class ...loaded. (0.160 >= 0.16) - UNIVERSAL::require ...loaded. (0.100) - Term::ReadKey ...loaded. (2.300) - Time::HiRes ...loaded. (1.860) - File::Temp ...loaded. (0.180 >= 0.17) - Encode ...loaded. (2.180 >= 2.10) - Getopt::Long ...loaded. (2.350 >= 2.35) - Pod::Escapes ...loaded. (1.040) - Pod::Simple ...loaded. (3.040) - File::Spec ...loaded. (3.240 >= 3.19) - SVN::Mirror ...loaded. (0.720 >= 0.71) [Localized messages] - Locale::Maketext::Lexicon ...loaded. (0.620 >= 0.62) - Locale::Maketext::Simple ...missing. (would need 0.16) [Message display through a pager] - IO::Pager ...missing. [Log4perl support] - Log::Log4perl ...loaded. (1.070) [Patch management] - Compress::Zlib ...loaded. (1.420) - FreezeThaw ...loaded. (0.430) However, the following tests fail: t/25log-filter...................ok 1/24Use of uninitialized value in concatenation (.) or string at /home/paulh/cpan/SVK-v2.0.0/blib/lib/SVK/I18N.pm line 87. # Failed test 'log --filter std' # in t/25log-filter.t at line 242. t/25log-filter...................NOK 21# Structures begin differing at: # $got->[1] = 'Perhaps you meant "--output ". If not, take a look at' # $expected->[1] = 'Perhaps you meant "--output std". If not, take a look at' Use of uninitialized value in concatenation (.) or string at /home/paulh/cpan/SVK-v2.0.0/blib/lib/SVK/I18N.pm line 87. # Failed test 'log --filter "author joe | std"' # in t/25log-filter.t at line 250. t/25log-filter...................NOK 22# Structures begin differing at: # $got->[1] = 'Perhaps you meant "--output ". If not, take a look at' # $expected->[1] = 'Perhaps you meant "--output std". If not, take a look at' Use of uninitialized value in concatenation (.) or string at /home/paulh/cpan/SVK-v2.0.0/blib/lib/SVK/I18N.pm line 87. # Failed test 'log --output grep' # in t/25log-filter.t at line 258. t/25log-filter...................NOK 23# Structures begin differing at: # $got->[1] = 'Perhaps you meant "--filter ' ...'". If not, take a look at' # $expected->[1] = 'Perhaps you meant "--filter 'grep ...'". If not, take a look at' # Looks like you failed 3 tests of 24. t/25log-filter...................dubious Test returned status 3 (wstat 768, 0x300) DIED. FAILED tests 21-23 Failed 3/24 tests, 87.50% okay And the reason is the following code in lib/SVK/Log/FilterPipeline.pm:153-168: # is the filter class of the right type? if ( $type eq 'output' ) { die loc( qq(Cannot use the selection filter "%1" as an output filter.\n) . qq(Perhaps you meant "--filter '%1 ...'". If not, take a look at\n) . qq("svk help log" for examples of using log filters.\n), lc($class), ) if !$found->isa('SVK::Log::Filter::Output'); } elsif ( $type eq 'selection' ) { die loc( qq(Cannot use the output filter "%1" in a selection pipeline.\n) . qq(Perhaps you meant "--output %1". If not, take a look at\n) . qq("svk help log" for examples of using log filters.\n), lc($class), ) if !$found->isa('SVK::Log::Filter::Selection'); } The repeated use of %1 in the format string for the loc function call fails. Changing the second to %2 and repeating lc($class) works around the problem. This is _only_ the case when using lib/SVK/I18N.pm's _default_gettext, installing Locale::Maketext::Simple fixed it. [Core Features] - Test::More ...loaded. (0.620 >= 0.42) - version ...loaded. (0.680 >= 0.68) - Algorithm::Annotate ...loaded. (0.100) - Algorithm::Diff ...loaded. (1.190100 >= 1.1901) - YAML::Syck ...loaded. (0.710 >= 0.60) - Data::Hierarchy ...loaded. (0.340 >= 0.30) - PerlIO::via::dynamic ...loaded. (0.110 >= 0.11) - PerlIO::via::symlink ...loaded. (0.050 >= 0.02) - IO::Digest ...loaded. (0.100) - SVN::Simple::Edit ...loaded. (0.270 >= 0.27) - URI ...loaded. (1.350) - PerlIO::eol ...loaded. (0.130 >= 0.13) - Class::Autouse ...loaded. (1.230 >= 1.15) - App::CLI ...loaded. (0.070) - List::MoreUtils ...loaded. (0.210) - Class::Accessor::Fast ...loaded. (0.300) - Class::Data::Inheritable ...loaded. (0.040) - Path::Class ...loaded. (0.160 >= 0.16) - UNIVERSAL::require ...loaded. (0.100) - Term::ReadKey ...loaded. (2.300) - Time::HiRes ...loaded. (1.860) - File::Temp ...loaded. (0.180 >= 0.17) - Encode ...loaded. (2.180 >= 2.10) - Getopt::Long ...loaded. (2.350 >= 2.35) - Pod::Escapes ...loaded. (1.040) - Pod::Simple ...loaded. (3.040) - File::Spec ...loaded. (3.240 >= 3.19) - SVN::Mirror ...loaded. (0.720 >= 0.71) [Localized messages] - Locale::Maketext::Lexicon ...loaded. (0.620 >= 0.62) - Locale::Maketext::Simple ...loaded. (0.180 >= 0.16) [Message display through a pager] - IO::Pager ...missing. [Log4perl support] - Log::Log4perl ...loaded. (1.070) [Patch management] - Compress::Zlib ...loaded. (1.420) - FreezeThaw ...loaded. (0.430) t/25log-filter...................ok -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE On-hiatus Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson@Pobox.Com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.1/au/ -----------------------------------------------------------