Bug #24665 for Perl-Critic: Perl::Critic does not detect return; after switch{}

Mon Jan 29 15:34:44 2007 GLEACH [...] cpan.org - Ticket created

#! /usr/bin/perl use Switch; use strict; use warnings; our $VERSION = 0.01; sub foo { switch $test { case 'a' {print 'a'} } } Subroutine does not end with "return" at line 9, column 1. See page 197 of PBP. (Severity: 4) Adding ';' after the '}' that closes the switch resolves the problem

Tue Jan 30 12:37:53 2007 GLEACH [...] cpan.org - Correspondence added

Subject:

Return not recognized after switch {}

I was so anxious to get a minimal test case, that I missed the most important part. Please add "return;" after the switch.

Tue Jan 30 12:37:55 2007 GLEACH [...] cpan.org - Status changed from 'new' to 'open'

Sun Feb 04 17:19:58 2007 thaljef [...] cpan.org - Correspondence added

Subject:	Perl::Critic does not detect return; after switch{}
From:	THALJEF [...] cpan.org

Switch.pm uses a source filter to do its magic. Since Perl::Critic can't compile your code and PPI has no idea what kind of new syntax the source filter introduces, all bets are off. This is just an inherent problem of static analysis for dynamic languages. The problem is that PPI sees the return statement as a continuation of the switch block. As you pointed out, putting the semi-colon after the block solves the problem, because PPI now sees them as separate statements. I can understand if that's not an attractive solution, but it is probably the best we can do :( -Jeff

Sun Feb 04 17:20:57 2007 thaljef [...] cpan.org - Subject changed from (no value) to 'Perl::Critic does not detect return; after switch{}'

Sun Feb 04 17:20:58 2007 thaljef [...] cpan.org - Status changed from 'open' to 'rejected'

Bug #24665 for Perl-Critic: Perl::Critic does not detect return; after switch{}

Preferred bug tracker