Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 24619
Status: rejected
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: smueller [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.01
Fixed in: (no value)



Subject: Subroutine called with "&" sigil
Hi, same context as my last ticket. (PAR.pm run through perlcritic.com) Subroutine called with "&" sigil at line 890, column 22. See page 175 of PBP. Severity: 2 0890: if ( defined(&Win32::LoginName) ) { It's not a sub call. Steffen
From: CDOLAN [...] cpan.org
On Fri Jan 26 18:18:15 2007, SMUELLER wrote: Show quoted text
> > same context as my last ticket. (PAR.pm run through perlcritic.com) > > Subroutine called with "&" sigil at line 890, column 22. See page 175 > of PBP. Severity: 2 > > 0890: if ( defined(&Win32::LoginName) ) { > > It's not a sub call.
Hi Steffen, Sorry, but this is a WONTFIX. The only reason that it's not a sub call is because defined() has a prototype signature of '$' (or maybe because it's magic?) P::C has deliberately taken a prototype agnostic approach because of we have no real way of knowing if someone has overridden CORE::defined without trying to emulate executing Perl code, and therein lies madness. Your best bet in this case is a C<##no critic (Sigil)> -- Chris Dolan