Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 24467
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: kanna [...] fw.jellybean.jp
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: ProhibitQuotedWordLists does not complain about 'use Module LIST'.
Date: Sat, 20 Jan 2007 15:39:43 +0900
To: bug-Perl-Critic [...] rt.cpan.org
From: "かんな (Kanna)" <kanna [...] fw.jellybean.jp>
According to Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists, use Module 'a', 'b'; use Module ( 'a', 'b' ); should be written like this. use Module qw(a b); However, Perl-Critic-0.21 does not complain about this. It's probably the edge case, Show quoted text
> In the PPI parlance, a "list" is almost anything with parens. I've > tried to make this Policy smart by targeting only "lists" that could > be sensibly expressed with qw(). However, there may be some edge cases > that I haven't covered. If you find one, send me a note.
so I report this as a bug. Could you fix it?
Subject: Re: [rt.cpan.org #24467] ProhibitQuotedWordLists does not complain about 'use Module LIST'.
Date: Fri, 19 Jan 2007 23:00:24 -0800 (PST)
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeffrey_thalhammer [...] yahoo.com>
Nice catch! I'll see what I can do. Show quoted text
____________________________________________________________________________________ Now that's room service! Choose from over 150,000 hotels in 45,000 destinations on Yahoo! Travel to find your fit. http://farechase.yahoo.com/promo-generic-14795097
On Sat Jan 20 01:46:41 2007, kanna@fw.jellybean.jp wrote: Show quoted text
> According to Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists, > > use Module 'a', 'b'; > use Module ( 'a', 'b' ); > > should be written like this. > > use Module qw(a b); > > However, Perl-Critic-0.21 does not complain about this. It's probably > the edge case,
Sorry this has taken so long. I just committed a fix for this. Look for it in the next release. Thanks for reporting it! -Jeff
Fixed and released in version 1.092.