Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 24447
Status: resolved
Priority: 0/
Queue: Net-DNS

People
Owner: Nobody in particular
Requestors: kent [...] cpttm.org.mo
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: online test fails in 5.8.7
Date: Fri, 19 Jan 2007 11:01:08 +0800
To: bug-Net-DNS [...] rt.cpan.org
From: Kent Tong <kent [...] cpttm.org.mo>
Hi, The online test (t/08-online) fails at line 106. It is expecting something like a.root-server but it gets A.ROOT-SERVER. The only difference is the case. Please consider making the comparison case insensitive. Thanks! -- Kent Tong Useful news for software developers at http://www2.cpttm.org.mo/cyberlab/softdev/newsletter
Subject: Re: [rt.cpan.org #24447] online test fails in 5.8.7
Date: Fri, 19 Jan 2007 08:46:55 +0100
To: bug-Net-DNS [...] rt.cpan.org
From: "Olaf M. Kolkman" <olaf [...] dacht.net>
Would you be so kind to apply this patch and try again? --Olaf --- t/08-online.t (revision 616) +++ t/08-online.t (working copy) @@ -65,7 +65,13 @@ foreach my $meth (keys %{$data}) { + if ($meth eq "name"){ + #names should be case insensitive + is(lc($answer->$meth()),lc($data->{$meth}), "$meth correct ($data->{name})"); + }else{ is($answer->$meth(), $data->{$meth}, "$meth correct ($data->{name})"); + } + } } @@ -75,7 +81,7 @@ my $wanted_names = [qw(a.t.net-dns.org a2.t.net-dns.org)]; my $names = [ map { $_->exchange } @mx ]; -is_deeply($names, $wanted_names, "mx() seems to be working"); +is_deeply(lc($names), lc($wanted_names), "mx() seems to be working"); # some people seem to use mx() in scalar context is(scalar mx('mx2.t.net-dns.org'), 2, "mx() works in scalar context"); @@ -103,7 +109,7 @@ next unless $packet; - is(($packet->answer)[0]->ptrdname, $test-> {'host'}, "$method($test->{'ip'}) works"); + is(lc(($packet->answer)[0]->ptrdname),lc ($test->{'host'}), "$method($test->{'ip'}) works"); } } } @@ -151,7 +157,7 @@ my ($a) = $ans->answer; isa_ok($a, 'Net::DNS::RR::A'); - is($a->name, 'a.t.net-dns.org',"Correct name (with $method)"); + is(lc($a->name), 'a.t.net-dns.org',"Correct name (with $method)"); } # $res->debug(1); my $socket=$res->bgsend('a.t.net-dns.org','A'); @@ -183,7 +189,7 @@ my ($a) = $ans->answer; isa_ok($a, 'Net::DNS::RR::A'); - is($a->name, 'a.t.net-dns.org',"Correct name"); + is(lc($a->name), 'a.t.net-dns.org',"Correct name"); } } @@ -232,7 +238,7 @@ my ($a) = $ans->answer; isa_ok($a, 'Net::DNS::RR::A'); - is($a->name, 'a.t.net-dns.org',"Correct name (with persistent socket and $method)"); + is(lc($a->name), 'a.t.net-dns.org',"Correct name (with persistent socket and $method)"); }
Download PGP.sig
application/pgp-signature 227b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #24447] online test fails in 5.8.7
Date: Fri, 19 Jan 2007 16:36:48 +0800
To: bug-Net-DNS [...] rt.cpan.org
From: Test <kent [...] cpttm.org.mo>
Olaf M. Kolkman via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=24447 > > > Would you be so kind to apply this patch and try again?
OK, but would you please send the patch as a zip attachment? Some line lines are broken. -- Kent Tong Useful & FREE software at http://www2.cpttm.org.mo/cyberlab/freeware
Subject: Re: [rt.cpan.org #24447] online test fails in 5.8.7
Date: Fri, 19 Jan 2007 10:05:36 +0100
To: bug-Net-DNS [...] rt.cpan.org
From: "Olaf M. Kolkman" <olaf [...] dacht.net>
On 19Jan 2007, at 9:37 AM, Kent Tong via RT wrote: Show quoted text
> > Queue: Net-DNS > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=24447 > > > Olaf M. Kolkman via RT wrote:
>> <URL: http://rt.cpan.org/Ticket/Display.html?id=24447 > >> >> Would you be so kind to apply this patch and try again?
> > OK, but would you please send the patch as a zip attachment? > Some line lines are broken.
Ah.. off course. Probably easiest to pull it straight from the trunk: http://www.net-dns.org/svn/net-dns/trunk/t/08-online.t There is one comparison in the test that may still fail because of changing cases (which is allowed by the protocol). as an aside I am a bit amazed that you are the first to report this error. Would you happen to know which recursive nameserver you are using (i.e. what software does the server run that is configured in /etc/ resolv.conf) --Olaf ------------------------------------------------------ Ik dacht net... heel even maar.
Download PGP.sig
application/pgp-signature 227b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #24447] online test fails in 5.8.7
Date: Fri, 19 Jan 2007 17:18:50 +0800
To: bug-Net-DNS [...] rt.cpan.org
From: Kent Tong <kent [...] cpttm.org.mo>
Olaf M. Kolkman via RT wrote: Show quoted text
> Ah.. off course. > Probably easiest to pull it straight from the trunk: > http://www.net-dns.org/svn/net-dns/trunk/t/08-online.t > > There is one comparison in the test that may still fail because of > changing cases (which is allowed by the protocol).
It works. Show quoted text
> I am a bit amazed that you are the first to report this error. Would > you happen to know which recursive nameserver you are using (i.e. > what software does the server run that is configured in /etc/ > resolv.conf)
It's an NT4 server. -- Kent Tong Useful news for network admins at http://www2.cpttm.org.mo/cyberlab/netadmin-news