Skip Menu |

This queue is for tickets about the Audio-TagLib CPAN distribution.

Report information
The Basics
Id: 24410
Status: resolved
Priority: 0/
Queue: Audio-TagLib

People
Owner: Nobody in particular
Requestors: spr [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.43
Fixed in: 1.50_01



Subject: OS X Patch for 1.43
Looks like some of the needed settings didn't make it into 1.43. Part of this is my fault, sorry. $libs needs to have all the extras as found in the patch for compiling in OS X. The DEFINE statement also needs editing to set the freebsd settings for OS X. This patch takes care of everything, and provides a working OS X build. Thanks for all your work.
Subject: osx-patch.diff
--- Audio-TagLib-1.43/Makefile.PL 2007-01-16 19:49:27.000000000 -0700 +++ Audio-TagLib-1.43-OSX/Makefile.PL 2007-01-17 00:18:47.000000000 -0700 @@ -18,6 +18,9 @@ Carp::croak("Please install taglib ver 1.4.*") unless $libver =~ m/^1\.4/io; our $libs = qx(taglib-config --libs); + if ($^O eq 'darwin') { + $libs = '-L/System/Library/Perl/lib/5.8 -lperl -liconv ' . qx(taglib-config --libs); + } our $inc = ' -I/usr/include -I./include -I. '. qx(taglib-config --cflags); } @@ -36,7 +39,7 @@ LDDLFLAGS => $^O eq 'darwin' ? "-dynamiclib $libs" : "-shared ". $libs, XSOPT => '-C++ -hiertype', LIBS => $libs, - DEFINE => $^O eq 'freebsd' ? '-D_BSD_ICONV -DNO_DOXYGEN' : '-DNO_DOXYGEN', # e.g., '-DHAVE_SOMETHING' + DEFINE => ($^O eq 'freebsd' || $^O eq 'darwin') ? '-D_BSD_ICONV -DNO_DOXYGEN' : '-DNO_DOXYGEN', # e.g., '-DHAVE_SOMETHING' INC => $inc, # e.g., '-I. -I/usr/include/other' # Un-comment this if you add C files to link with later: # OBJECT => '$(O_FILES)', # link all the C files too
normally the link path to perl core lib should not be explicitly specified here since it will be taken care by MakeMaker, have you tried omitting it? cheers,
From: spr [...] mahonri5.net
On Wed Jan 17 02:48:35 2007, DONGXU wrote: Show quoted text
> normally the link path to perl core lib should not be explicitly > specified here since it will be taken care by MakeMaker, have you tried > omitting it?
I did try without it, and it fails with linker errors without it. If there is a way to dynamically locate the core lib's path that would be great, but I'm afraid I don't know how to do that. I know that it needs it specified to work unfortunately.
Subject: Re: [rt.cpan.org #24410] OS X Patch for 1.43
Date: Thu, 18 Jan 2007 18:36:14 +0800
To: bug-Audio-TagLib [...] rt.cpan.org
From: "Dongxu Ma" <dongxu.ma [...] gmail.com>
thanks for sharing info. to fix in next release. On 1/18/07, Scott Paul Robertson via RT <bug-Audio-TagLib@rt.cpan.org> wrote: Show quoted text
> > > Queue: Audio-TagLib > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=24410 > > > On Wed Jan 17 02:48:35 2007, DONGXU wrote:
> > normally the link path to perl core lib should not be explicitly > > specified here since it will be taken care by MakeMaker, have you tried > > omitting it?
> > I did try without it, and it fails with linker errors without it. If > there is a way to dynamically locate the core lib's path that would be > great, but I'm afraid I don't know how to do that. I know that it needs > it specified to work unfortunately. > >
-- Cheers, Dongxu __END__ http://search.cpan.org/~dongxu
applied in 1.50_01