Bug #24341 for grepmail: Test suite failures with Mail::Mbox::MessageParser 1.5000

Fri Jan 12 09:32:49 2007 paul [...] city-fan.org - Ticket created

Subject:	Test suite failures with Mail::Mbox::MessageParser 1.5000
Date:	Fri, 12 Jan 2007 14:32:08 +0000
To:	bug-grepmail [...] rt.cpan.org
From:	Paul Howarth <paul [...] city-fan.org>

After upgrading Mail::Mbox::MessageParser to 1.5000, the grepmail test suite fails in multiple places. Regressing Mail::Mbox::MessageParser back to 1.4005 results in the test suite passing. The attached build log is for Fedora Core 4 x86_64 but I observed exactly the same problem with Red Hat 9 i386. Regards, Paul.

Message body is not shown because it is too large.

Tue Feb 27 11:04:16 2007 ATOURBIN [...] cpan.org - Correspondence added 20 min

On Fri Jan 12 09:32:49 2007, paul@city-fan.org wrote: Show quoted text

> After upgrading Mail::Mbox::MessageParser to 1.5000, the grepmail test > suite fails in multiple places. Regressing Mail::Mbox::MessageParser > back to 1.4005 results in the test suite passing. The attached build log > is for Fedora Core 4 x86_64 but I observed exactly the same problem with > Red Hat 9 i386. > > Regards, Paul.

Hello, this patch should fix your problem. --- a/grepmail +++ b/grepmail @@ -1153,7 +1153,7 @@ sub Process_Mail_File # This is the main loop. It's executed once for each email # Direct access for performance reasons #while($folder_reader->end_of_file()) - while(!$folder_reader->{'end_of_file'}) + while(!$folder_reader->end_of_file) { dprint "Reading email" if $opts{'D'};

Tue Feb 27 11:04:17 2007 The RT System itself - Status changed from 'new' to 'open'

Tue Feb 27 13:07:12 2007 paul [...] city-fan.org - Correspondence added

Subject:	Re: [rt.cpan.org #24341] Test suite failures with Mail::Mbox::MessageParser 1.5000
Date:	Tue, 27 Feb 2007 18:06:40 +0000
To:	bug-grepmail [...] rt.cpan.org
From:	Paul Howarth <paul [...] city-fan.org>

Alexey Tourbin via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=24341 > > > On Fri Jan 12 09:32:49 2007, paul@city-fan.org wrote:

>> After upgrading Mail::Mbox::MessageParser to 1.5000, the grepmail test >> suite fails in multiple places. Regressing Mail::Mbox::MessageParser >> back to 1.4005 results in the test suite passing. The attached build log >> is for Fedora Core 4 x86_64 but I observed exactly the same problem with >> Red Hat 9 i386. >> >> Regards, Paul.

> > Hello, > > this patch should fix your problem. > > --- a/grepmail > +++ b/grepmail > @@ -1153,7 +1153,7 @@ sub Process_Mail_File > # This is the main loop. It's executed once for each email > # Direct access for performance reasons > #while($folder_reader->end_of_file()) > - while(!$folder_reader->{'end_of_file'}) > + while(!$folder_reader->end_of_file) > { > dprint "Reading email" if $opts{'D'}; >

Thanks; that works very nicely! Cheers, Paul.

Thu Mar 01 14:24:18 2007 david [...] coppit.org - Correspondence added

From:

david [...] coppit.org

On Tue Feb 27 11:04:16 2007, ATOURBIN wrote: Show quoted text

> this patch should fix your problem. > > --- a/grepmail > +++ b/grepmail > @@ -1153,7 +1153,7 @@ sub Process_Mail_File > # This is the main loop. It's executed once for each email > # Direct access for performance reasons > #while($folder_reader->end_of_file()) > - while(!$folder_reader->{'end_of_file'}) > + while(!$folder_reader->end_of_file) > { > dprint "Reading email" if $opts{'D'};

Gah! Two lessons for me: (1) ALWAYS retest grepmail when I update M:M:MessageParser, (2) NEVER use an internal interface, even for performance. I'll be releasing 5.3034 with this fix. Thanks to both of you for the report and patch. David

Thu Mar 01 14:25:16 2007 david [...] coppit.org - Status changed from 'open' to 'resolved'

Thu Mar 01 14:25:17 2007 david [...] coppit.org - Severity Critical added