Bug #24282 for SVN-Notify: Some SVNNotify feedback

Mon Jan 08 18:10:24 2007 mdoar [...] packetmotion.com - Ticket created

Subject:	Some SVNNotify feedback
Date:	Mon, 08 Jan 2007 15:09:51 -0800
To:	bug-SVN-Notify [...] rt.cpan.org
From:	Matt Doar <mdoar [...] packetmotion.com>

Firstly, thanks for a great tool! Here are some comments. 1. To get Module:Build to install on older instances of RedHat: I had to unset LANG See http://rt.cpan.org/Public/Bug/Display.html?id=19465 2. There are typos "refrences" and "expresion" in various places in the usage 3. The code is not currently checking for a missing %s in the --jira-url option 4. Jira matching did not work for me using -jira-url and HTML but --ticket-map worked fine 5. It might be a nice option to have the filenames link to the revision-url server rather than to the diffs lower down in the email? 6. Some examples of using --to-regex-amp for per-branch matching would be useful 7. Maybe add a suggestion about where verbose logging output goes? Perhaps as a canned example, my final command line looked with Jira links something like this: /usr/bin/svnnotify --repos-path "$REPOS" --revision "$REV" --to user-list@example.com --user-domain=example.com --subject-prefix "[svn]" --ticket-map '\b([A-Z]+-\d+)\b=http://jira/browse/%s' -H HTML --revision-url "http://svn:8080/changelog/scratch/?cs=%s" --with-diff --max-diff-length 4096 --author-url 'mailto:%s@example.com' --linkize ~Matt

Mon Mar 26 21:37:10 2007 david [...] kineticode.com - Correspondence added

Subject:	Re: [rt.cpan.org #24282] Some SVNNotify feedback
Date:	Mon, 26 Mar 2007 18:36:56 -0700
To:	bug-SVN-Notify [...] rt.cpan.org
From:	"David E. Wheeler" <david [...] kineticode.com>

On Jan 8, 2007, at 15:10, Matt Doar via RT wrote: Show quoted text

> Firstly, thanks for a great tool! Here are some comments.

Thanks. Show quoted text

> 1. To get Module:Build to install on older instances of RedHat: I > had to > unset LANG See http://rt.cpan.org/Public/Bug/Display.html?id=19465

Looks like Ken fixed that issue, eh? Show quoted text

> 2. There are typos "refrences" and "expresion" in various places in > the > usage

Thanks, fixed. Show quoted text

> 3. The code is not currently checking for a missing %s in the -- > jira-url > option

Thanks, fixed (for RT, Bugzilla, and Gnats, too). Show quoted text

> 4. Jira matching did not work for me using -jira-url and HTML but > --ticket-map worked fine

Hrm. What's the format for Jira URLs? What regular expression did you use in --ticket-map? Maybe it has changed? Show quoted text

> 5. It might be a nice option to have the filenames link to the > revision-url server rather than to the diffs lower down in the email?

I could see an option for that, I guess, but usually people want to jump to the diff in the email. Track works the same way, I notice (well, it has two links, but still…). Show quoted text

> 6. Some examples of using --to-regex-amp for per-branch matching would > be useful

Do you have any? I can't even remember it at the moment. Show quoted text

> 7. Maybe add a suggestion about where verbose logging output goes?

Done. It goes to STDOUT. Show quoted text

> Perhaps as a canned example, my final command line looked with Jira > links something like this: > > /usr/bin/svnnotify --repos-path "$REPOS" --revision "$REV" --to > user-list@example.com --user-domain=example.com --subject-prefix > "[svn]" > --ticket-map '\b([A-Z]+-\d+)\b=http://jira/browse/%s' -H HTML > --revision-url "http://svn:8080/changelog/scratch/?cs=%s" --with-diff > --max-diff-length 4096 --author-url 'mailto:%s@example.com' --linkize

Thanks, can I use that? Best, David

Mon Mar 26 21:37:11 2007 The RT System itself - Status changed from 'new' to 'open'

Tue Mar 27 10:54:52 2007 mdoar [...] packetmotion.com - Correspondence added

Subject:	Re: [rt.cpan.org #24282] Some SVNNotify feedback
Date:	Tue, 27 Mar 2007 07:54:12 -0700
To:	bug-SVN-Notify [...] rt.cpan.org
From:	Matt Doar <mdoar [...] packetmotion.com>

David Wheeler via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=24282 > > > On Jan 8, 2007, at 15:10, Matt Doar via RT wrote: > >

>> Firstly, thanks for a great tool! Here are some comments. >>

> > Thanks. > >

>> 1. To get Module:Build to install on older instances of RedHat: I >> had to >> unset LANG See http://rt.cpan.org/Public/Bug/Display.html?id=19465 >>

> > Looks like Ken fixed that issue, eh? > >

>> 2. There are typos "refrences" and "expresion" in various places in >> the >> usage >>

> > Thanks, fixed. > >

>> 3. The code is not currently checking for a missing %s in the -- >> jira-url >> option >>

> > Thanks, fixed (for RT, Bugzilla, and Gnats, too). > >

>> 4. Jira matching did not work for me using -jira-url and HTML but >> --ticket-map worked fine >>

> > Hrm. What's the format for Jira URLs? What regular expression did you > use in --ticket-map? Maybe it has changed? > >

>> 5. It might be a nice option to have the filenames link to the >> revision-url server rather than to the diffs lower down in the email? >>

> > I could see an option for that, I guess, but usually people want to > jump to the diff in the email. Track works the same way, I notice > (well, it has two links, but still…). > >

>> 6. Some examples of using --to-regex-amp for per-branch matching would >> be useful >>

> > Do you have any? I can't even remember it at the moment. > >

This is basically what I'm using at the moment. Feel free to use it in the documentation if you want to. author=`svnlook author $REPOS -r $REV` # The mail regexes should match all the top-level directories /usr/bin/svnnotify --repos-path "$REPOS" --revision "$REV" \ -x eng-bar@example.com,${EXTRAS}="^Bar" \ -x eng-foo@example.com,${EXTRAS}="^trunk/Foo|^branches/Foo|^tags/Foo" \ -x $author@example.com="^users" \ --user-domain example.com --subject-prefix "[svn]" --ticket-map '\b([A-Z]+-\d+)\b=http://jira/browse/%s' -H HTML::ColorDiff --revision-url "http://svn:8080/changelog/projects/?cs=%s" --with-diff --max-diff-length 1000000 --author-url 'mailto:%s@example.com' --linkize --subject-cx Show quoted text

>> 7. Maybe add a suggestion about where verbose logging output goes? >>

> > Done. It goes to STDOUT. > >

>> Perhaps as a canned example, my final command line looked with Jira >> links something like this: >> >> /usr/bin/svnnotify --repos-path "$REPOS" --revision "$REV" --to >> user-list@example.com --user-domain=example.com --subject-prefix >> "[svn]" >> --ticket-map '\b([A-Z]+-\d+)\b=http://jira/browse/%s' -H HTML >> --revision-url "http://svn:8080/changelog/scratch/?cs=%s" --with-diff >> --max-diff-length 4096 --author-url 'mailto:%s@example.com' --linkize >>

> > Thanks, can I use that? > >

Sure. Other ideas that I've added here, but not generalized, are: - The summary of each ticket is added like this "Foo bar DEV-123 [This is a bug about something]" with nothing if the bug tracker can't be contacted or the bug doesn't exist - Actually use max_diff_len in the HTML and HTML:Color code - Added a --admin email_address where any mail that doesn't match a regex is sent to, with a modified subject warning that the mail wasn't sent to anyone else - Tried adding custom headers to the messages (X-Context etc) but neither Outlook nor Thunderbird let me sort on them :-( - Added output from diffstat, e.g. Diffstat SystemServices/src/scripts/managerOperation.sh | 236 ------------------------ SystemServices/src/scripts/runManager.sh | 233 +++++++++++++++++++++++ SystemServices/src/scripts/setenv.sh | 10 + 3 files changed, 243 insertions(+), 236 deletions(-) Thanks again, ~Matt Show quoted text

> Best, > > David > > >

Sat Apr 07 18:21:32 2007 david [...] kineticode.com - Correspondence added

Subject:	Re: [rt.cpan.org #24282] Some SVNNotify feedback
Date:	Sat, 7 Apr 2007 15:21:00 -0700
To:	bug-SVN-Notify [...] rt.cpan.org
From:	"David E. Wheeler" <david [...] kineticode.com>

On Mar 27, 2007, at 07:54, Matt Doar via RT wrote: Show quoted text

>> Do you have any? I can't even remember it at the moment. >>

> This is basically what I'm using at the moment. Feel free to use it in > the documentation if you want to.

Thanks, I've added it as an example. Show quoted text

>> Thanks, can I use that?

> > Sure. Other ideas that I've added here, but not generalized, are:

Added the JIRA pattern as an example, too. Show quoted text

> - The summary of each ticket is added like this "Foo bar DEV-123 [This > is a bug about something]" with nothing if the bug tracker can't be > contacted or the bug doesn't exist

Uh, not sure what you're saying (asking for?) here. Show quoted text

> - Actually use max_diff_len in the HTML and HTML:Color code

Fixed in 2.65. Show quoted text

> - Added a --admin email_address where any mail that doesn't match a > regex is sent to, with a modified subject warning that the mail wasn't > sent to anyone else

Not a bad idea. Feel like implementing it and sending me a patch? Show quoted text

> - Tried adding custom headers to the messages (X-Context etc) but > neither Outlook nor Thunderbird let me sort on them :-(

Lame. Show quoted text

> - Added output from diffstat, e.g. > > > Diffstat > > SystemServices/src/scripts/managerOperation.sh | 236 > ------------------------ > SystemServices/src/scripts/runManager.sh | 233 +++++++++++++ > ++++++++++ > SystemServices/src/scripts/setenv.sh | 10 + > 3 files changed, 243 insertions(+), 236 deletions(-)

Someone else asked for this once, too. Again, I would welcome a patch. Best, David

Wed Feb 06 13:44:01 2008 dwheeler [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Feb 06 13:44:06 2008 dwheeler [...] cpan.org - Fixed in 2.66 added

Bug #24282 for SVN-Notify: Some SVNNotify feedback

Preferred bug tracker