Bug #24210 for Module-Install: absolute paths in BUNDLES.yml

Thu Jan 04 08:30:00 2007 marco.masetti [...] softeco.it - Ticket created

Subject:	absolute paths in BUNDLES.yml
Date:	Thu, 4 Jan 2007 14:21:09 +0100
To:	bug-Module-Install [...] rt.cpan.org
From:	Marco Masetti <marco.masetti [...] softeco.it>

perl -v: This is perl, v5.8.8 built for i686-linux pmvers inc::Module::Install: 0.64 ------------------------------------------------ Makefile.PL: use inc::Module::Install; WriteMakefile( NAME => 'ctm::Visum', VERSION_FROM => 'lib/ctm/Visum/FileSectionHandler.pm', PREREQ_PM => { HTML::Parser => 0, LWP::UserAgent => 0, URI => 0, Log::Log4perl => 0, }, ($] >= 5.005 ? ## Add these new keywords supported since 5.005 (ABSTRACT_FROM => 'lib/ctm/Visum.pm', AUTHOR => 'Marco Masetti <marco.masetti at softeco.it>') : ()), ); auto_bundle(); auto_install(); WriteAll(); ------------------------------------------------- This ends up in building a BUNDLES.yml file with absolute paths. This makes the make procedure at distribution site fetching modules from CPAN still. Setting paths relative solves the issue (installs bundled modules). Hope this help. Your sincerely, Marco. -- -------------------------------------------- Marco Masetti Project Manager - Research & Innovation Softeco Sismat SpA Via De Marini, 1 - Torre WTC 16149 - Genova phone: (+39) 010 6026.333/.1 fax : (+39) 010 6026.350 email: marco.masetti@softeco.it web : www.softeco.it -------------------------------------------- ILS : masetti@linux.it GLUG : http://genova.linux.it PMI : http://www.perl.it --------------------------------------------

Mon Mar 17 13:58:08 2008 goneri [...] cpan.org - Correspondence added

From:

GONERI [...] cpan.org

The problem comes from CPANPLUS's extract() that doesn't return a relative path anymore. Gonéri LE BOUDER A little hack: --- libmodule-install-perl-0.69.orig/lib/Module/Install/Admin/Bundle.pm +++ libmodule-install-perl-0.69/lib/Module/Install/Admin/Bundle.pm @@ -55,7 +55,11 @@ unlink $file; next unless ($extract_result); - $bundles{$name} = $extract_result; + if ($extract_result =~ /$bundle_dir\/(.*)/) { + $bundles{$name} = 'inc/BUNDLES/'.$1; + } else { + $bundles{$name} = $extract_result; + } $self->{already_bundled}{ $mod->package }++; }

Mon Mar 17 13:58:09 2008 The RT System itself - Status changed from 'new' to 'open'

Wed May 14 07:18:06 2008 bobtfish [...] bobtfish.net - Cc BOBTFISH added

Wed May 14 07:19:03 2008 bobtfish [...] bobtfish.net - Correspondence added

This is also hurting me. Would the author accept a patch (and tests) to deal with *both* CPANPLUS behaviors?

Sun Mar 07 00:29:55 2010 ishigaki [...] cpan.org - Correspondence added

Hi. Applied your patch in the trunk, though not sure if we should still use CPANPLUS backend just to download/extract things, especially as recently we have several online services from which we can retrieve package information. Anyway, this will hopefully be fixed in the next release. Thanks. On 2008-3-17 Mon 13:58:08, GONERI wrote: Show quoted text

> The problem comes from CPANPLUS's extract() that doesn't return a > relative path anymore. > > Gonéri LE BOUDER > > A little hack: > > > --- libmodule-install-perl-0.69.orig/lib/Module/Install/Admin/

Bundle.pm Show quoted text

> +++ libmodule-install-perl-0.69/lib/Module/Install/Admin/Bundle.pm > @@ -55,7 +55,11 @@ > > unlink $file; > next unless ($extract_result); > - $bundles{$name} = $extract_result; > + if ($extract_result =~ /$bundle_dir\/(.*)/) { > + $bundles{$name} = 'inc/BUNDLES/'.$1; > + } else { > + $bundles{$name} = $extract_result; > + } > $self->{already_bundled}{ $mod->package }++; > > }

Sun Mar 07 00:29:56 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Wed Mar 10 12:21:53 2010 ishigaki [...] cpan.org - Correspondence added

Hi. 0.95 is out. If you still have the problem, reopen this. Thanks.

Wed Mar 10 12:21:54 2010 The RT System itself - Status changed from 'patched' to 'open'

Wed Mar 10 12:21:57 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'