Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVN-Notify CPAN distribution.

Report information
The Basics
Id: 24138
Status: resolved
Priority: 0/
Queue: SVN-Notify
People
Owner: Nobody in particular
Requestors: iana [...] apple.com
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: 2.70
Attachments
smime.p7s

History Show all quoted text
  Fri Dec 29 01:16:08 2006 iana [...] apple.com - Ticket created
Subject: SVN::Notify::HTML::ColorDiff could (optionally?) word wrap the log message
Date: Fri, 29 Dec 2006 00:14:14 -0600
To: bug-svn-notify [...] rt.cpan.org
From: Ian Anderson <iana [...] apple.com>
I have just one small request for SVN::Notify::HTML::ColorDiff. Could it word wrap the yellow log message section? Maybe optionally? Currently I'm passing --css-url with css file that just says "#msg pre { white-space: pre-wrap; }" but that felt a little bit like overkill. Alternatively, could SV::Notify::HTML take a --css-file option? Thanks! Ian
Download smime.p7s
application/pkcs7-signature 2.3k

Message body not shown because it is not plain text.

  Mon Mar 26 21:28:03 2007 david [...] kineticode.com - Correspondence added
Subject: Re: [rt.cpan.org #24138] SVN::Notify::HTML::ColorDiff could (optionally?) word wrap the log message
Date: Mon, 26 Mar 2007 18:27:43 -0700
To: bug-SVN-Notify [...] rt.cpan.org
From: "David E. Wheeler" <david [...] kineticode.com>
On Dec 28, 2006, at 22:16, Ian Anderson via RT wrote: Show quoted text
> I have just one small request for SVN::Notify::HTML::ColorDiff. Could > it word wrap the yellow log message section? Maybe optionally? > Currently I'm passing --css-url with css file that just says "#msg pre > { white-space: pre-wrap; }" but that felt a little bit like overkill. > Alternatively, could SV::Notify::HTML take a --css-file option? > Thanks!
I just added --wrap-log, which will put the log message into `p` tags instead of `pre`. Look for a new release in the next few days. Thanks for the suggestion—a lot of people will be pleased with this improvement, I think. Best, David
  Mon Mar 26 21:28:04 2007 The RT System itself - Status changed from 'new' to 'open'
  Wed Apr 18 19:45:49 2007 iana [...] apple.com - Correspondence added
Subject: Re: [rt.cpan.org #24138] SVN::Notify::HTML::ColorDiff could (optionally?) word wrap the log message
Date: Wed, 18 Apr 2007 16:45:24 -0700
To: bug-SVN-Notify [...] rt.cpan.org
From: Ian Anderson <iana [...] apple.com>
On Mar 26, 2007, at 6:28 PM, David Wheeler via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=24138 > > > On Dec 28, 2006, at 22:16, Ian Anderson via RT wrote: >
>> I have just one small request for SVN::Notify::HTML::ColorDiff. >> Could >> it word wrap the yellow log message section? Maybe optionally? >> Currently I'm passing --css-url with css file that just says "#msg >> pre >> { white-space: pre-wrap; }" but that felt a little bit like overkill. >> Alternatively, could SV::Notify::HTML take a --css-file option? >> Thanks!
> > I just added --wrap-log, which will put the log message into `p` tags > instead of `pre`. Look for a new release in the next few days. > > Thanks for the suggestion—a lot of people will be pleased with this > improvement, I think. > > Best, > > David
I tried that out but it didn't work very well for us. It ate all of our hard newlines and changed the font in the log messages. Could -- wrap-log be modified to just change the CSS for the #msg pre id to add white-space: pre-wrap;? Ian
Download smime.p7s
application/pkcs7-signature 2.3k

Message body not shown because it is not plain text.

  Wed Feb 06 13:52:45 2008 dwheeler [...] cpan.org - Correspondence added
I've just modified --wrap-log in SVN to look for paragraphs and to split them up, so individual paragraphs will each be in a <p></p> tag. That should help quite a lot. In the next week or so, I plan to add support for a few different types of markup in the log message, including HTML, Markdown, and Trac. Best, David
  Wed Feb 06 14:15:26 2008 dwheeler [...] cpan.org - Severity Wishlist added
  Thu Feb 07 16:21:26 2008 dwheeler [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Feb 07 16:21:27 2008 dwheeler [...] cpan.org - Fixed in 2.67 added
  Mon Feb 18 14:51:54 2008 iana [...] apple.com - Correspondence added
Subject: Re: [rt.cpan.org #24138] SVN::Notify::HTML::ColorDiff could (optionally?) word wrap the log message
Date: Mon, 18 Feb 2008 11:51:07 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: Ian Anderson <iana [...] apple.com>
Thanks for looking at it, but it's still a little weird. It preserves the hard returns in our log messages now, but the message is cut up into a bunch of yellow boxes, one for each paragraph. It also changes the font from the fixed-width <pre> font to the proportional-width <p> font. Which probably isn't the end of the world, but switching the font just because you're wrapping the text seems a bit weird to me. I guess our --css-url file that says "#msg pre { white-space: pre- wrap; }" is still working fine for now. Ian On Feb 6, 2008, at 10:52 AM, David Wheeler via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=24138 > > > I've just modified --wrap-log in SVN to look for paragraphs and to > split > them up, so individual paragraphs will each be in a <p></p> tag. That > should help quite a lot. > > In the next week or so, I plan to add support for a few different > types > of markup in the log message, including HTML, Markdown, and Trac. > > Best, > > David
Download smime.p7s
application/pkcs7-signature 2.3k

Message body not shown because it is not plain text.

  Mon Feb 18 14:51:57 2008 The RT System itself - Status changed from 'resolved' to 'open'
  Tue Feb 19 14:27:05 2008 dwheeler [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #24138] SVN::Notify::HTML::ColorDiff could (optionally?) word wrap the log message
Date: Tue, 19 Feb 2008 11:26:09 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Feb 18, 2008, at 11:51, Ian Anderson via RT wrote: Show quoted text
> Thanks for looking at it, but it's still a little weird. It preserves > the hard returns in our log messages now, but the message is cut up > into a bunch of yellow boxes, one for each paragraph. It also changes > the font from the fixed-width <pre> font to the proportional-width <p> > font. Which probably isn't the end of the world, but switching the > font just because you're wrapping the text seems a bit weird to me. I > guess our --css-url file that says "#msg pre { white-space: pre- > wrap; }" is still working fine for now.
Thanks. I've modified it so that the paragraphs will now appear all in one yellow box. Since --wrap-log splits the message up into paragraphs, it made sense to me to use <p> instead of <pre>. But if you want more options, watch for the release in the next couple of days, in which you can optionally use Trac wiki syntax or write your own filter to format the log message however you like. :-) Best, David
  Wed Mar 12 18:03:30 2008 dwheeler [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed Mar 12 18:03:30 2008 dwheeler [...] cpan.org - Fixed in 2.70 added
  Wed Mar 12 18:03:30 2008 dwheeler [...] cpan.org - Fixed in 2.67 deleted