Bug #24104 for Algorithm-RabinKarp: t/util returns dubious

Tue Dec 26 15:57:41 2006 ACDALTON [...] cpan.org - Ticket created

Subject:

t/util returns dubious

FreeBSD 5.4-RELEASE, Perl 5.6.2: Testing (/usr/ports/textproc/p5-Algorithm-RabinKarp/work/Algorithm-RabinKarp-0.40)... PERL_DL_NONLAZY=1 /usr/local/bin/perl5.6.2 "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/construct....ok t/hash.........ok t/util.........dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 1-20 Failed 20/20 tests, 0.00% okay Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/util.t 255 65280 20 40 1-20 Failed 1/3 test scripts. 20/77 subtests failed. Files=3, Tests=77, 0 wallclock secs ( 0.46 cusr + 0.07 csys = 0.53 CPU) Oh well: No such file or directory at t/util.t line 16. # Looks like your test died before it could output anything. Failed 1/3 test programs. 20/77 subtests failed. *** Error code 35

Tue Dec 26 16:35:14 2006 nnunley [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #24104] t/util returns dubious
Date:	Tue, 26 Dec 2006 21:32:13 +0000
To:	bug-Algorithm-RabinKarp [...] rt.cpan.org
From:	"Norman Nunley, Jr" <nnunley [...] gmail.com>

Hello. Can you confirm that the failure is occurring on 'open my $fh...' in the test file? My development of A::RK is has been against 5.8. 'm willing to modify the tests slightly to allow it to work with 5.6.2, if necessary. Thanks for the bug report. Norman On 26 Dec 2006, at 20:57, via RT wrote: Show quoted text

> > Tue Dec 26 15:57:41 2006: Request 24104 was acted upon. > Transaction: Ticket created by ACDALTON > Queue: Algorithm-RabinKarp > Subject: t/util returns dubious > Broken in: 0.40 > Severity: Important > Owner: Nobody > Requestors: ACDALTON@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=24104 > > > > FreeBSD 5.4-RELEASE, Perl 5.6.2: > > Testing > (/usr/ports/textproc/p5-Algorithm-RabinKarp/work/Algorithm- > RabinKarp-0.40)... > PERL_DL_NONLAZY=1 /usr/local/bin/perl5.6.2 "-MExtUtils::Command::MM" > "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/construct....ok > t/hash.........ok > t/util.........dubious > Test returned status 255 (wstat 65280, 0xff00) > DIED. FAILED tests 1-20 > Failed 20/20 tests, 0.00% okay > Failed Test Stat Wstat Total Fail List of Failed > ---------------------------------------------------------------------- > --------- > t/util.t 255 65280 20 40 1-20 > Failed 1/3 test scripts. 20/77 subtests failed. > Files=3, Tests=77, 0 wallclock secs ( 0.46 cusr + 0.07 csys = > 0.53 CPU) > Oh well: No such file or directory at t/util.t line 16. > # Looks like your test died before it could output anything. > Failed 1/3 test programs. 20/77 subtests failed. > *** Error code 35 >

Tue Dec 26 16:35:17 2006 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 26 16:54:23 2006 ACDALTON [...] cpan.org - Correspondence added

On Tue Dec 26 16:35:14 2006, nnunley@gmail.com wrote: Show quoted text

> Hello. Can you confirm that the failure is occurring on 'open my > $fh...' in the test file? >

That is indeed the offending line. Show quoted text

> My development of A::RK is has been against 5.8. 'm willing to > modify the tests > slightly to allow it to work with 5.6.2, if necessary. >

Supporting older Perls is of course your choice. AFAICS, I don't think the module as a whole has any problems with 5.6 though. Show quoted text

> Thanks for the bug report. >

My pleasure, thanks for responding! =)

Tue Dec 26 20:10:41 2006 nnunley [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #24104] t/util returns dubious
Date:	Wed, 27 Dec 2006 01:10:12 +0000
To:	bug-Algorithm-RabinKarp [...] rt.cpan.org
From:	"Norman Nunley, Jr" <nnunley [...] gmail.com>

Can you confirm that Algorithm::RabinKarp 0.41 fixes the broken util.t tests for you? On 26 Dec 2006, at 21:54, via RT wrote: Show quoted text

> > Queue: Algorithm-RabinKarp > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=24104 > > > On Tue Dec 26 16:35:14 2006, nnunley@gmail.com wrote:

>> Hello. Can you confirm that the failure is occurring on 'open my >> $fh...' in the test file? >>

> > That is indeed the offending line. >

>> My development of A::RK is has been against 5.8. 'm willing to >> modify the tests >> slightly to allow it to work with 5.6.2, if necessary. >>

> > Supporting older Perls is of course your choice. AFAICS, I don't > think > the module as a whole has any problems with 5.6 though. >

>> Thanks for the bug report. >>

> > My pleasure, thanks for responding! =) >

Wed Dec 27 12:05:39 2006 ACDALTON [...] cpan.org - Correspondence added

On Tue Dec 26 20:10:41 2006, nnunley@gmail.com wrote: Show quoted text

> Can you confirm that Algorithm::RabinKarp 0.41 fixes the broken > util.t tests for you? >

It does if (and only if) you make the following minor, annoying, yet necessary change: use File::Temp qw(:seekable tempfile); instead of: use File::Temp qw(tempfile :seekable); If you're going to re-release right away, I will wait on the ports tree update. If not, I'll do a patch on our end until you see fit to release again. Just let me know. Thanks so much for your time, Norman! Aaron FreeBSD Ports Committer

Thu Dec 28 10:55:08 2006 nnunley [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #24104] t/util returns dubious
Date:	Thu, 28 Dec 2006 15:49:32 +0000
To:	bug-Algorithm-RabinKarp [...] rt.cpan.org
From:	"Norman Nunley, Jr" <nnunley [...] gmail.com>

I've released a patched version (0.41_1) that fixes the import args order. Sorry I botched these releases. Norman On 27 Dec 2006, at 17:05, via RT wrote: Show quoted text

> > Queue: Algorithm-RabinKarp > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=24104 > > > On Tue Dec 26 20:10:41 2006, nnunley@gmail.com wrote:

>> Can you confirm that Algorithm::RabinKarp 0.41 fixes the broken >> util.t tests for you? >>

> > It does if (and only if) you make the following minor, annoying, yet > necessary change: > > use File::Temp qw(:seekable tempfile); > > instead of: > > use File::Temp qw(tempfile :seekable); > > If you're going to re-release right away, I will wait on the ports > tree > update. If not, I'll do a patch on our end until you see fit to > release > again. Just let me know. > > Thanks so much for your time, Norman! > > Aaron > FreeBSD Ports Committer >

Thu Dec 28 11:04:10 2006 ACDALTON [...] cpan.org - Correspondence added

On Thu Dec 28 10:55:08 2006, nnunley@gmail.com wrote: Show quoted text

> I've released a patched version (0.41_1) that fixes the import args > order. >

Thanks for the re-release! Show quoted text

> Sorry I botched these releases. >

Naw, you didn't botch them. No one person can possibly predict all possible problems that can possibly arise. I appreciate your alacrity in dealing with the issue though! Cheers!

Thu Dec 28 12:58:59 2006 NNUNLEY [...] cpan.org - Correspondence added

I'll count the 0.41_1 release as fixing the compatibility issue with 5.6.1 unless you note otherwise.

Thu Dec 28 12:59:00 2006 NNUNLEY [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Dec 28 13:32:31 2006 ACDALTON [...] cpan.org - Correspondence added

On Thu Dec 28 12:58:59 2006, NNUNLEY wrote: Show quoted text

> I'll count the 0.41_1 release as fixing the compatibility issue with > 5.6.1 unless you note otherwise.

I can't test 5.6.1, but it works great for 5.6.2. Cheers!

Thu Dec 28 13:32:33 2006 The RT System itself - Status changed from 'resolved' to 'open'

Thu Nov 03 14:42:08 2011 NNUNLEY [...] cpan.org - Status changed from 'open' to 'resolved'