Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Mail-LocalDelivery CPAN distribution.

Report information
The Basics
Id: 2408
Status: resolved
Priority: 0/
Queue: Mail-LocalDelivery

People
Owner: Nobody in particular
Requestors: turner [...] mikomi.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.1
Fixed in: (no value)



Subject: Input check uses ref and not ISA
The constructor is using ref to determine the class if its input, ie. ref $stuff eq "Mail::Internet". It would be much more flexable to use ISA, ie. UNIVERSAL::isa($stuff,"Mail::Internet"). Patch is included.
--- LocalDelivery.pm~ 2002-06-07 09:37:47.000000000 -0400 +++ LocalDelivery.pm 2003-04-16 14:56:46.000000000 -0400 @@ -108,7 +108,7 @@ my $self; # What sort of stuff do we have? - if (ref $stuff eq "Mail::Internet" or ref $stuff eq "MIME::Entity"){ + if (UNIVERSAL::isa($stuff,"Mail::Internet") or UNIVERSAL::isa($stuff,"MIME::Entity")){ $self = $stuff; } elsif (ref $stuff eq "ARRAY" or ref $stuff eq "GLOB") { $self = new Mail::Internet($stuff);
Date: Wed, 16 Apr 2003 20:31:44 +0100
From: Simon Cozens <simon [...] simon-cozens.org>
To: via RT <bug-Mail-LocalDelivery [...] rt.cpan.org>
Subject: Re: [cpan #2408] Input check uses ref and not ISA
RT-Send-Cc:
via RT: Show quoted text
> This message about Mail-LocalDelivery was sent to you by TURNERA <TURNERA@cpan.org> via rt.cpan.org
Mail::LocalDelivery is deprecated. Please use Email::LocalDelivery instead. I suppose you could say that for everything in Mail::*. Simon -- Life would be so much easier if we could just look at the source code. -- Dave Olson