Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 24049
Status: resolved
Worked: 2 min
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: Kenneth.Schafer [...] mathworks.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Dec 22 12:36:50 2006 Kenneth.Schafer [...] mathworks.com - Ticket created
Subject: Same lines of code generating 2 similar warnings
Date: Fri, 22 Dec 2006 12:36:24 -0500
To: <bug-Perl-Critic [...] rt.cpan.org>
From: "Kenneth Schafer" <Kenneth.Schafer [...] mathworks.com>
Distribution name and version Perl-Critic-0.22 Perl version 5.8.6 Operating System vendor and version Linux Debian 3.x and Suse 9.3 Using Perl Critic 0.22 the same lines of code are generating two similar warnings. "Module does not end with "1; ..." and "Module does not end with true constant..." are getting generated at the same time from the same lines of code. Is this done purposely, or are these warnings redundant? Thank you, Ken Schafer
  Fri Dec 22 14:36:06 2006 chris [...] chrisdolan.net - Correspondence added
Subject: Re: [rt.cpan.org #24049] Same lines of code generating 2 similar warnings
Date: Fri, 22 Dec 2006 13:35:33 -0600
To: bug-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] chrisdolan.net>
On Dec 22, 2006, at 11:36 AM, Kenneth Schafer via RT wrote: Show quoted text
> Distribution name and version > Perl-Critic-0.22 > Perl version > 5.8.6 > Operating System vendor and version > Linux Debian 3.x and Suse 9.3 > > Using Perl Critic 0.22 the same lines of code are generating two > similar > warnings. > > > "Module does not end with "1; ..." and "Module does not end with true > constant..." are getting generated at the same time from the same > lines > of code. Is this done purposely, or are these warnings redundant? > > Thank you, > > Ken Schafer
Hi Ken, It sounds like you have both Perl::Critic and Perl::Critic::Lax installed, yes? The "true constant" message sounds like one from the latter package. The Lax project contains more liberal versions of some of the core Perl::Critic policies, so there is some duplication. We recommend that if you have Lax installed that you choose to disable either the Lax policy or the core policy that it mirrors. If I'm barking up the wrong tree, email back and we'll dig deeper. Chris -- Chris Dolan, Software Developer, http://www.chrisdolan.net/ Public key: http://www.chrisdolan.net/public.key vCard: http://www.chrisdolan.net/ChrisDolan.vcf
  Fri Dec 22 14:36:09 2006 The RT System itself - Status changed from 'new' to 'open'
  Fri Dec 22 15:16:48 2006 Kenneth.Schafer [...] mathworks.com - Correspondence added
Subject: RE: [rt.cpan.org #24049] Same lines of code generating 2 similar warnings
Date: Fri, 22 Dec 2006 15:16:26 -0500
To: <bug-Perl-Critic [...] rt.cpan.org>
From: "Kenneth Schafer" <Kenneth.Schafer [...] mathworks.com>
Chris, I checked, and you were right, Perl::Critic::Lax is installed. Thanks, Ken Show quoted text
-----Original Message----- From: Chris Dolan via RT [mailto:bug-Perl-Critic@rt.cpan.org] Sent: Friday, December 22, 2006 2:36 PM To: Kenneth Schafer Subject: Re: [rt.cpan.org #24049] Same lines of code generating 2 similar warnings <URL: http://rt.cpan.org/Ticket/Display.html?id=24049 > On Dec 22, 2006, at 11:36 AM, Kenneth Schafer via RT wrote:
> Distribution name and version > Perl-Critic-0.22 > Perl version > 5.8.6 > Operating System vendor and version > Linux Debian 3.x and Suse 9.3 > > Using Perl Critic 0.22 the same lines of code are generating two > similar > warnings. > > > "Module does not end with "1; ..." and "Module does not end with true > constant..." are getting generated at the same time from the same > lines > of code. Is this done purposely, or are these warnings redundant? > > Thank you, > > Ken Schafer
Hi Ken, It sounds like you have both Perl::Critic and Perl::Critic::Lax installed, yes? The "true constant" message sounds like one from the latter package. The Lax project contains more liberal versions of some of the core Perl::Critic policies, so there is some duplication. We recommend that if you have Lax installed that you choose to disable either the Lax policy or the core policy that it mirrors. If I'm barking up the wrong tree, email back and we'll dig deeper. Chris -- Chris Dolan, Software Developer, http://www.chrisdolan.net/ Public key: http://www.chrisdolan.net/public.key vCard: http://www.chrisdolan.net/ChrisDolan.vcf
  Fri Dec 22 15:47:16 2006 chris+rt [...] chrisdolan.net - Correspondence added 2 min
  Fri Dec 22 15:47:19 2006 chris+rt [...] chrisdolan.net - Status changed from 'open' to 'resolved'