Skip Menu |

This queue is for tickets about the Java CPAN distribution.

Report information
The Basics
Id: 2403
Status: new
Priority: 0/
Queue: Java

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: standard portability issues with Makefile.PL/test.pl
Hi. I strongly suggest you read `perldoc perlport' and `perldoc ExtUtils::MakeMaker'. Please use ExtUtils::MakeMaker's prompt function to prompt because it respects PERL_MM_USE_DEFAULT. You should prompt to run java_server_install.pl. For testing purposes, you should simply prompt to run JavaServer.jar from where it is currently (simplifies matters). You should use File::Spec when dealing with filenames (in your case, a few calls to File::Spec->canonpath are in order) And finally, you shouldn't be using system calls to copy files. The following is not nice if ($OS =~ /windows/i) { system("copy JavaServer.jar $lib"); } else { system("/bin/cp JavaServer.jar $lib"); } just use File::Copy, and avoid any and all such portability issues. BTW, for future reference, if you want to check $^O, check out http://perlmonks.com/index.pl?node_id=233481 or http://alma.ch/perl/perloses.htm for a comprehensive list. $^O on windows is not 'windows'.
From: ken.prows [...] online-rewards.com
I too had problems getting this module to pass the tests. The module itself is very cool (I just released XML::ApacheFOP which requires it), but the install tests seem to have a habit of failing. A big problem I found with the tests was getting them to pass when installing Java.pm remotely. The test script died in this scenario upon trying to load the GUI stuff. Perhaps make it an option on whether the GUI tests are run or not. Not everyone uses Java.pm for GUI stuff (which my module shows). If you are too busy, I would be willing to rewrite the test scripts for you. Other than the test scripts though, this is an excellent module. It works as advertised and made my life a lot easier :) Ken Prows