Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Perl-Critic CPAN distribution.

Report information
The Basics
Id: 23941
Status: resolved
Worked: 10 min
Priority: 0/
Queue: Test-Perl-Critic
People
Owner: Nobody in particular
Requestors: steve.kirkup [...] greatlodge.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Dec 14 15:11:50 2006 steve.kirkup [...] greatlodge.com - Ticket created
Subject: Test::Perl::Critic Bug with
Date: Thu, 14 Dec 2006 13:44:55 -0600 (CST)
To: bug-Test-Perl-Critic [...] rt.cpan.org
From: Steve Kirkup <steve.kirkup [...] greatlodge.com>
Jeff, I was playing with Test::Perl::Critic and ran into a problem. #--------------------- use Test::Perl::Critic; for (qw(Config.pm Division.pm Game.pm League.pm Manager.pm News.pm Player.pm Team.pm Webapp.pm)) { critic_ok( "lib/EEBL/$_" ); #Test one file } critic_ok("lib/EEBL.pm" ); #--------------------- This blows up because I did not declare a plan. However there is no interface for declaring a Test plan for individual files. I looked at the code and when using the all_critic_ok() you declare a test plan there. I think you forgot to allow something so that it can be manually overridden. (like in my case). Steve Kirkup
  Thu Dec 14 17:10:47 2006 chris [...] clotho.com - Correspondence added
Subject: Re: [rt.cpan.org #23941] Test::Perl::Critic Bug with
Date: Thu, 14 Dec 2006 16:10:21 -0600
To: bug-Test-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] clotho.com>
Steve, You might try like this: use Test::Perl::Critic; use Test::More tests => 12; critic_ok('Foo.pm'); ... Chris
  Thu Dec 14 17:10:49 2006 The RT System itself - Status changed from 'new' to 'open'
  Tue Dec 19 11:01:24 2006 steve.kirkup [...] greatlodge.com - Correspondence added
Subject: Re: [rt.cpan.org #23941] Test::Perl::Critic Bug with
Date: Tue, 19 Dec 2006 10:00:55 -0600 (CST)
To: bug-Test-Perl-Critic [...] rt.cpan.org
From: Steve Kirkup <steve.kirkup [...] greatlodge.com>
Chris, I don't have a problem with this fix. However, could the documentation be updated to reflect this solution? I also wonder, should critic_ok() be exported by default since it cannot be used without Test::More. Steve Kirkup Show quoted text
----- Original Message ----- From: chris@clotho.com via RT <bug-Test-Perl-Critic@rt.cpan.org> To: steve kirkup <steve.kirkup@greatlodge.com> Sent: Thursday, December 14, 2006 4:10:49 PM GMT-0600 US/Central Subject: Re: [rt.cpan.org #23941] Test::Perl::Critic Bug with <URL: http://rt.cpan.org/Ticket/Display.html?id=23941 > Steve, You might try like this: use Test::Perl::Critic; use Test::More tests => 12; critic_ok('Foo.pm'); ... Chris
  Tue Dec 19 11:12:20 2006 chris+rt [...] chrisdolan.net - Correspondence added 10 min
Steve, You are absolutely right. I just committed a rewritten SYNOPSIS and a few other doc changes. Thanks for the feedback! Chris On Tue Dec 19 11:01:24 2006, steve.kirkup@greatlodge.com wrote: Show quoted text
> Chris, > > I don't have a problem with this fix. However, could the > documentation be updated to reflect this solution? > > I also wonder, should critic_ok() be exported by default since it > cannot be used without Test::More. > > Steve Kirkup
  Tue Dec 19 11:12:23 2006 chris+rt [...] chrisdolan.net - Status changed from 'open' to 'resolved'