Skip Menu |

This queue is for tickets about the Net-SC CPAN distribution.

Report information
The Basics
Id: 23938
Status: resolved
Priority: 0/
Queue: Net-SC

People
Owner: Nobody in particular
Requestors: DAKKAR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.20
Fixed in: 1.22



Subject: Check for FQDN in request_socks5 is broken
The function request_socks5 checks the $peer_host parameter to see whether it should issue a request with a numeric address or a name. The check is: if ( $peer_host =~ /[a-z][A-Z]/) { which means: if the $peer_host variable contains a lower-case letter *followed by* an upper-case letter... It's quite clearly a typo, should have been: /[a-zA-Z]/. Or, even better: /[^0-9.]/ (that is, if there's any character which would dot be allowed in a IPv4 numeric dotted-quad address). The last regexp has been tested here, and works (I use Tor as a SOCKS proxy, and it stopped complaining)