Bug #23931 for ExtUtils-MakeMaker: Generated META.yml lacks trailing newline

Thu Dec 14 07:55:46 2006 smueller [...] cpan.org - Ticket created

Subject:

Generated META.yml lacks trailing newline

When you try to parse the ExtUtils-MakeMaker-6.31-generated META.yml with YAML (0.62), you get errors about missing trailing newlines. YAML::Syck and YAML::Tiny seem to be less restrictive. Sorry if this is really is a bug in YAML, but it really seems to point at MM. Steffen

Thu Dec 14 18:07:43 2006 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #23931] Generated META.yml lacks trailing newline
Date:	Thu, 14 Dec 2006 15:07:09 -0800
To:	bug-ExtUtils-MakeMaker [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] gmail.com>

Steffen Müller via RT wrote: Show quoted text

> Thu Dec 14 07:55:46 2006: Request 23931 was acted upon. > Transaction: Ticket created by SMUELLER > Queue: ExtUtils-MakeMaker > Subject: Generated META.yml lacks trailing newline > Broken in: 6.31 > Severity: Normal > Owner: Nobody > Requestors: SMUELLER@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=23931 > > > > When you try to parse the ExtUtils-MakeMaker-6.31-generated META.yml > with YAML (0.62), you get errors about missing trailing newlines. > > YAML::Syck and YAML::Tiny seem to be less restrictive. > > Sorry if this is really is a bug in YAML, but it really seems to point > at MM.

Unless the resulting META.yml file is invalid YAML, and I don't think there's a requirement for a trailing newline before EOF, I'd call that a bug in YAML.pm. Check with the YAML folks.

Thu Dec 14 18:07:45 2006 The RT System itself - Status changed from 'new' to 'open'

Sat Dec 16 03:20:26 2006 andreas.koenig.gmwojprw [...] franz.ak.mind.de - Correspondence added

Subject:	Re: [rt.cpan.org #23931] Generated META.yml lacks trailing newline
Date:	Sat, 16 Dec 2006 09:19:09 +0100
To:	bug-ExtUtils-MakeMaker [...] rt.cpan.org
From:	andreas.koenig.gmwojprw [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Thu, 14 Dec 2006 18:07:45 -0500, "Michael G Schwern via RT" <bug-ExtUtils-MakeMaker@rt.cpan.org> said:

Show quoted text

> Unless the resulting META.yml file is invalid YAML, and I don't > think there's a requirement for a trailing newline before EOF, I'd > call that a bug in YAML.pm. Check with the YAML folks.

Frankly, I consider it always impolite to write text files without trailing newlines. It's against the Internet Principle: be strict in what you emit. And even if the standard does neither demand nor recommend it, missing trailing newlines have caused so much grief in the past with other tools: concatenation, diff output, shell prompts eating the last line, etc... please reconsider. Thanks, -- andreas

Sat Dec 16 23:53:10 2006 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #23931] Generated META.yml lacks trailing newline
Date:	Sat, 16 Dec 2006 20:52:34 -0800
To:	bug-ExtUtils-MakeMaker [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] gmail.com>

andreas.koenig.gmwojprw@franz.ak.mind.de via RT wrote: Show quoted text

> > Unless the resulting META.yml file is invalid YAML, and I don't > > think there's a requirement for a trailing newline before EOF, I'd > > call that a bug in YAML.pm. Check with the YAML folks.

> > Frankly, I consider it always impolite to write text files without > trailing newlines. It's against the Internet Principle: be strict in > what you emit. And even if the standard does neither demand nor > recommend it, missing trailing newlines have caused so much grief in > the past with other tools: concatenation, diff output, shell prompts > eating the last line, etc... please reconsider.

Oh, I'll put the newline into META.yml just to make it work with YAML.pm. But if YAML.pm is misparsing they should know.

Fri Jun 29 03:48:29 2007 mschwern [...] cpan.org - Correspondence added

I am unable to reproduce this problem with MakeMaker 6.31 or 6.32. Here's an example of a MM 6.31 generated META.yml with a trailing newline. http://search.cpan.org/src/MSCHWERN/Test-Simple-0.70/META.yml Do you have a specific example of a META.yml file lacking a newline? Was it perhaps using Module::Install?

Fri Jun 29 03:48:34 2007 mschwern [...] cpan.org - Status changed from 'open' to 'stalled'

Sat Jun 30 07:34:48 2007 o6hhmk002 [...] sneakemail.com - Correspondence added

Subject:	Re: [rt.cpan.org #23931] Generated META.yml lacks trailing newline
Date:	Sat, 30 Jun 2007 13:33:37 +0200
To:	bug-ExtUtils-MakeMaker [...] rt.cpan.org
From:	Steffen Mueller <o6hhmk002 [...] sneakemail.com>

Michael G Schwern via RT schrieb: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=23931 > > > I am unable to reproduce this problem with MakeMaker 6.31 or 6.32. > > Here's an example of a MM 6.31 generated META.yml with a trailing newline. > http://search.cpan.org/src/MSCHWERN/Test-Simple-0.70/META.yml > > Do you have a specific example of a META.yml file lacking a newline? > Was it perhaps using Module::Install?

I just tried this with all three of the common build systems and all seemed to do the right thing in the newest versions. I also tried all of YAML, YAML::Syck, and YAML::Tiny. All versions are the newest available from CPAN. So I guess you can close the ticket. Either I had some borked installation of some of the involved modules or there have been changes to any of them. Thanks for following up on this. Best regards, Steffen

Sat Jun 30 07:34:55 2007 The RT System itself - Status changed from 'stalled' to 'open'

Sat Jun 30 12:04:16 2007 mschwern [...] cpan.org - Correspondence added

Does not exist.

Sat Jun 30 12:04:19 2007 mschwern [...] cpan.org - Status changed from 'open' to 'resolved'