Skip Menu |

This queue is for tickets about the Business-Barcode-EAN13 CPAN distribution.

Report information
The Basics
Id: 23904
Status: open
Priority: 0/
Queue: Business-Barcode-EAN13
People
Owner: Nobody in particular
Requestors: rthompson [...] bellacor.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Dec 12 13:42:25 2006 rthompson [...] bellacor.com - Ticket created
Subject: Additional barcode support
Date: Tue, 12 Dec 2006 12:41:39 -0600
To: <bug-Business-Barcode-EAN13 [...] rt.cpan.org>
From: "Rod Thompson" <rthompson [...] bellacor.com>

Message body is not shown because sender requested not to inline it.

Thanks for coding this module, you saved me about three days with your efforts. I've taken the liberty of re-coding the "check_digit" and "valid_barcode" routines to support UPC, GTIN and ISBN barcode validation. If they meet your standards, please update CPAN. Rod Thompson Integration Architect bellacor.com rthompson@bellacor.com Office: 651.294.2554
  Tue Dec 12 14:46:41 2006 tony [...] tmtm.com - Correspondence added
Subject: Re: [rt.cpan.org #23904] Additional barcode support
Date: Tue, 12 Dec 2006 19:45:53 +0000
To: bug-Business-Barcode-EAN13 [...] rt.cpan.org
From: Tony Bowden <tony [...] tmtm.com>
Rod Thompson via RT wrote: Show quoted text
> Thanks for coding this module, you saved me about three days with your > efforts. I've taken the liberty of re-coding the "check_digit" and > "valid_barcode" routines to support UPC, GTIN and ISBN barcode > validation. If they meet your standards, please update CPAN. >
I'm glad this was useful for you. I don't suppose you put together any test cases for your changes? Thanks, Tony
  Tue Dec 12 14:46:44 2006 The RT System itself - Status changed from 'new' to 'open'
  Wed Dec 13 11:42:23 2006 rthompson [...] bellacor.com - Correspondence added
Subject: RE: [rt.cpan.org #23904] Additional barcode support
Date: Wed, 13 Dec 2006 10:41:32 -0600
To: <bug-Business-Barcode-EAN13 [...] rt.cpan.org>
From: "Rod Thompson" <rthompson [...] bellacor.com>
Glad you pimped me on that, in putting formal test cases together, I found an error with the ISBN 10 check digit calculation. Here's the package and the test cases, I modified the value passed in the " Returns undef with invalid checkdigit" test case, otherwise I left the test cases intact. The " Picks correct barcode from a list, with non-existing preference, but only one valid barcode" fails on my system (ActivePERL on WinXP), but I didn't try to debug it. Rod Show quoted text
-----Original Message----- From: tony@tmtm.com via RT [mailto:bug-Business-Barcode-EAN13@rt.cpan.org] Sent: Tuesday, December 12, 2006 1:47 PM To: Rod Thompson Subject: Re: [rt.cpan.org #23904] Additional barcode support <URL: http://rt.cpan.org/Ticket/Display.html?id=23904 > Rod Thompson via RT wrote:
> Thanks for coding this module, you saved me about three days with your > efforts. I've taken the liberty of re-coding the "check_digit" and > "valid_barcode" routines to support UPC, GTIN and ISBN barcode > validation. If they meet your standards, please update CPAN. >
I'm glad this was useful for you. I don't suppose you put together any test cases for your changes? Thanks, Tony

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

  Wed Dec 13 13:45:18 2006 tony [...] tmtm.com - Correspondence added
Subject: Re: [rt.cpan.org #23904] Additional barcode support
Date: Wed, 13 Dec 2006 18:44:24 +0000
To: bug-Business-Barcode-EAN13 [...] rt.cpan.org
From: Tony Bowden <tony [...] tmtm.com>
Rod Thompson via RT wrote: Show quoted text
> Glad you pimped me on that, in putting formal test cases together, I > found an error with the ISBN 10 check digit calculation. Here's the > package and the test cases
Thanks for this. I'm in the process of moving house at the minute, so it'll be the New Year before I get around to looking at this in detail. Tony