Bug #23757 for Test-TAP-HTMLMatrix: make test fails because Test::TAP::Model fails

Sun Dec 03 17:31:08 2006 jkeenan [...] cpan.org - Ticket created

Subject:

make test fails because Test::TAP::Model fails

This distribution failed to install on Darwin, apparently because its prerequisite Test-TAP-Model also failed to install. I'm rating this failure as critical because Test-TAP-HTMLMatrix is required for the 'make smoke' call by which Parrot developers transmit smoke reports. I know that several other participants in the Chicago Perl Hackathon encountered this precise problem.

Subject:

perl-V.txt

Summary of my perl5 (revision 5 version 8 subversion 8) configuration: Platform: osname=darwin, osvers=8.7.0, archname=darwin-2level uname='darwin macintosh.local 8.7.0 darwin kernel version 8.7.0: fri may 26 15:20:53 pdt 2006; root:xnu-792.6.76.obj~1release_ppc power macintosh powerpc ' config_args='-de' hint=recommended, useposix=true, d_sigaction=define usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef useperlio=define d_sfio=undef uselargefiles=define usesocks=undef use64bitint=undef use64bitall=undef uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe -I/usr/local/include', optimize='-O3', cppflags='-no-cpp-precomp -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe -I/usr/local/include' ccversion='', gccversion='3.3 20030304 (Apple Computer, Inc. build 1495)', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=4321 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=8 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -L/usr/local/lib' libpth=/usr/local/lib /usr/lib libs=-ldbm -ldl -lm -lc perllibs=-ldl -lm -lc libc=/usr/lib/libc.dylib, so=dylib, useshrplib=false, libperl=libperl.a gnulibc_version='' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' ' cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib' Characteristics of this binary (from libperl): Compile-time options: PERL_MALLOC_WRAP USE_LARGE_FILES USE_PERLIO Built under darwin Compiled at Sep 13 2006 20:15:49 @INC: /usr/local/lib/perl5/5.8.8/darwin-2level /usr/local/lib/perl5/5.8.8 /usr/local/lib/perl5/site_perl/5.8.8/darwin-2level /usr/local/lib/perl5/site_perl/5.8.8 /usr/local/lib/perl5/site_perl/5.8.7/darwin-2level /usr/local/lib/perl5/site_perl/5.8.7 /usr/local/lib/perl5/site_perl/5.8.4/darwin-2level /usr/local/lib/perl5/site_perl/5.8.4 /usr/local/lib/perl5/site_perl .

Subject:

Test-Tap-HTMLMatrix.make.test.failures.txt

Message body is not shown because it is too large.

Sat Dec 09 02:37:49 2006 chromatic [...] cpan.org - Correspondence added

With my patch to Test::TAP::Model and this patch, all of the tests pass again. Note that the reporting ratios have changed in Test::Harness::Straps; apparently the number of tests run before bailing out is different from what the tests for this distribution expected.

diff -ur Test-TAP-HTMLMatrix-0.05/t/file_visual.t Test-TAP-HTMLMatrix-0.05_new/t/file_visual.t --- Test-TAP-HTMLMatrix-0.05/t/file_visual.t 2006-03-27 10:49:25.000000000 -0800 +++ Test-TAP-HTMLMatrix-0.05_new/t/file_visual.t 2006-12-08 23:19:50.000000000 -0800 @@ -4,6 +4,7 @@ use warnings; use Test::More tests => 15; +use Test::Harness::Results; my $m; @@ -24,32 +25,31 @@ file => "foo", }); -$r->{results}{max} = 1; -$r->{results}{passing} = 1; -$r->{results}{seen} = 1; +my $results = Test::Harness::Results->new(); +$r->{results} = $results; +$results->inc_max(); +$results->set_passing( 1 ); +$results->inc_seen(); is($f->str_status, "OK", "seen + ok = OK"); -$r->{results}{max} = 2; +$results->inc_max(); is($f->str_status, "FAILED", "seen != planned = FAILED"); -$r->{results}{max} = 1; -$r->{results}{seen} = 0; +$r->{results} = $results = Test::Harness::Results->new(); +$results->inc_max(); is($f->str_status, "FAILED", "no tests + ok = FAILED"); -$r->{results}{passing} = 0; -$r->{results}{seen} = 1; +$results->inc_seen(); is($f->str_status, "FAILED", "seen + fail = FAILED"); -$r->{results}{passing} = 1; +$results->set_passing( 1 ); $r->{events}[0]{type} = "bailout"; is($f->str_status, "BAILED OUT", "seen + ok + bailout = BAILED OUT"); -$r->{results}{passing} = 1; -$r->{results}{skip_all} = "foo"; +$results->set_skip_all( "foo" ); $r->{events} = []; is($f->str_status, "SKIPPED", "seen + ok + skip_all = SKIPPED"); -$r->{results}{seen} = 0; -$r->{results}{skip_all} = "foo"; +$r->{results} = $results = Test::Harness::Results->new(); +$results->set_skip_all( "foo" ); is($f->str_status, "SKIPPED", "no seen + ok + skip_all = SKIPPED"); - diff -ur Test-TAP-HTMLMatrix-0.05/t/inline_css.t Test-TAP-HTMLMatrix-0.05_new/t/inline_css.t --- Test-TAP-HTMLMatrix-0.05/t/inline_css.t 2006-03-27 10:49:24.000000000 -0800 +++ Test-TAP-HTMLMatrix-0.05_new/t/inline_css.t 2006-12-08 23:26:40.000000000 -0800 @@ -12,7 +12,7 @@ my $s = Test::TAP::Model::Visual->new; my $f = $s->start_file("foo"); -eval { $f->{results} = { $s->analyze("foo", [split /\n/, <<TAP]) } }; +eval { $f->{results} = $s->analyze("foo", [split /\n/, <<TAP]) }; 1..6 ok 1 foo not ok 2 bar diff -ur Test-TAP-HTMLMatrix-0.05/t/no_plan.t Test-TAP-HTMLMatrix-0.05_new/t/no_plan.t --- Test-TAP-HTMLMatrix-0.05/t/no_plan.t 2006-03-27 10:49:24.000000000 -0800 +++ Test-TAP-HTMLMatrix-0.05_new/t/no_plan.t 2006-12-08 23:20:10.000000000 -0800 @@ -16,7 +16,7 @@ my $s = Test::TAP::Model::Visual->new; my $f = $s->start_file("foo"); -eval { $f->{results} = { $s->analyze("foo", [split /\n/, <<TAP]) } }; +eval { $f->{results} = $s->analyze("foo", [split /\n/, <<TAP]) }; ok 1 foo ok 2 bar 1..2 diff -ur Test-TAP-HTMLMatrix-0.05/t/templ_output.t Test-TAP-HTMLMatrix-0.05_new/t/templ_output.t --- Test-TAP-HTMLMatrix-0.05/t/templ_output.t 2006-03-27 10:49:24.000000000 -0800 +++ Test-TAP-HTMLMatrix-0.05_new/t/templ_output.t 2006-12-08 23:30:20.000000000 -0800 @@ -16,7 +16,7 @@ my $s = Test::TAP::Model::Visual->new; my $f = $s->start_file("foo"); -eval { $f->{results} = { $s->analyze("foo", [split /\n/, <<TAP]) } }; +eval { $f->{results} = $s->analyze("foo", [split /\n/, <<TAP]) }; 1..6 ok 1 foo not ok 2 bar @@ -38,12 +38,12 @@ like($detail_html, qr/not ok 2 bar/, "subtest 2 line"); like($detail_html, qr/ok 3 gorch/, "subtest 3 line"); - like($detail_html, qr/66\.6\d%/, "contains percentage"); + like($detail_html, qr/80.00%/, "contains percentage"); like($detail_html, qr/BAILED OUT/, "something bailed out in there"); like($detail_html, qr/4\s+ok/is, "ok summary"); - like($detail_html, qr/2\s+failed/is, "contains fail summary"); + like($detail_html, qr/1\s+failed/is, "contains fail summary"); like($detail_html, qr/1\s+skipped/is, "contains skip summary"); like($detail_html, qr/2\s+todo/is, "contains skip summary"); like($detail_html, qr/1\s+unexpectedly\s+succeeded/is, "contains skip summary"); @@ -52,6 +52,6 @@ my $summary_html = $t->summary_html; like($summary_html, qr{<html.*/html>}s, "summary has <html> tags"); - like($summary_html, qr/66\.6\d%/, "contains percentage"); + like($summary_html, qr/80\.00%/, "contains percentage"); }

Sat Dec 09 02:37:52 2006 The RT System itself - Status changed from 'new' to 'open'

Sat Dec 09 08:28:57 2006 jkeen [...] verizon.net - Correspondence added

Subject:	Re: [rt.cpan.org #23757] make test fails because Test::TAP::Model fails
Date:	Sat, 09 Dec 2006 08:28:31 -0500
To:	bug-Test-TAP-HTMLMatrix [...] rt.cpan.org
From:	James Keenan <jkeen [...] verizon.net>

On Dec 9, 2006, at 2:37 AM, via RT wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=23757 > > > With my patch to Test::TAP::Model and this patch, all of the tests > pass > again. Note that the reporting ratios have changed in > Test::Harness::Straps; apparently the number of tests run before > bailing > out is different from what the tests for this distribution expected. > >

c: Are you saying that the problems were *only* in the tests? (I.e., that the module itself was okay?) That's what your diffs imply. Show quoted text

> diff -ur Test-TAP-HTMLMatrix-0.05/t/file_visual.t Test-TAP- > HTMLMatrix-0.05_new/t/file_visual.t

Show quoted text

> diff -ur Test-TAP-HTMLMatrix-0.05/t/inline_css.t Test-TAP- > HTMLMatrix-0.05_new/t/inline_css.t

Show quoted text

> diff -ur Test-TAP-HTMLMatrix-0.05/t/templ_output.t Test-TAP- > HTMLMatrix-0.05_new/t/templ_output.t

jimk

Sat Dec 09 14:54:11 2006 chromatic [...] cpan.org - Correspondence added

On Sat Dec 09 08:28:57 2006, jkeen@verizon.net wrote: Show quoted text

> c: Are you saying that the problems were *only* in the tests? > (I.e., that the module itself was okay?) > > That's what your diffs imply.

Yes. The module itself uses Test::TAP::Model appropriately, but violates the new encapsulation of Test::Harness::Results when setting up the testing environment. -- c

Sat Mar 10 13:32:16 2007 GAAL [...] cpan.org - Correspondence added

On Sat Dec 09 02:37:49 2006, CHROMATIC wrote: Show quoted text

> With my patch to Test::TAP::Model and this patch, all of the tests pass > again. Note that the reporting ratios have changed in > Test::Harness::Straps; apparently the number of tests run before bailing > out is different from what the tests for this distribution expected.

Thanks, applied. The ratios hadn't changed on my machine (2.64 here too), so I didn't apply that part of the patch.

Sat Mar 10 13:32:47 2007 GAAL [...] cpan.org - Status changed from 'open' to 'resolved'