Skip Menu |

This queue is for tickets about the GDGraph CPAN distribution.

Maintainer(s)' notes

There are plenty of good ideas of what people can do published here on the queue. Turning a patch from the tracker into a pull request is not one of them. In order to get maintainers' attention way more quickier, PR should have at least a sample included. We know it's hard to test images generating software, but it doesn't mean we can not test numbers produced by intermediate algorithms used to generate these images, so either a test or a sample.

Report information
The Basics
Id: 23755
Status: resolved
Priority: 0/
Queue: GDGraph
People
Owner: Nobody in particular
Requestors: jjanes [...] gnf.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.4308
Fixed in: 1.44
Attachments
as_is.png
GD_bug.pl
my_fix.png

History Show all quoted text
  Sun Dec 03 13:03:45 2006 jjanes [...] gnf.org - Ticket created
Subject: x_tick_number ignored
Date: Sun, 3 Dec 2006 10:03:21 -0800
To: <bug-GDGraph [...] rt.cpan.org>
From: "Jeff Janes" <jjanes [...] gnf.org>
In GD::Graph::axestype, in the sub set_max_min, the x axes _best_ends are set using the values of y_tick_number and y_min_range, rather than the values for x_tick_number and x_min_range. if (defined($self->{x_tick_number})) { if (defined($self->{x_min_value}) && defined($self->{x_max_value})) { $self->{true_x_min} = $self->{x_min_value}; $self->{true_x_max} = $self->{x_max_value}; } else { ($self->{true_x_min}, $self->{true_x_max}) = $self->{_data}->get_min_max_x; ($self->{x_min}, $self->{x_max}, $self->{x_tick_number}) = _best_ends($self->{true_x_min}, $self->{true_x_max}, @$self{'y_tick_number','y_min_range'}); } } I think the last line there should instead be: @$self{'x_tick_number','x_min_range'}); This change makes some of my graphs look better (without the change, often all of the data points are crowded into the left half of the charting area, because it always uses 5 ticks even when that is a bad choice.) Of course I can't be sure that this change doesn't break other things in other types of graphs. Thanks, Jeff Janes
  Wed Jan 03 23:28:30 2007 bwarfield [...] cpan.org - Correspondence added
If you could attach a script or snippet that demonstrates the problem you're describing (and optionally the output of that script), it would simplify my life somewhat, and probably improve the chances of my getting to this sometime in the finite future. That said, your diagnosis looks pretty plausible--I'll have to double-check that we're not both missing something important about that section, but I'd guess it's just a copy-paste error.
  Wed Jan 03 23:28:31 2007 The RT System itself - Status changed from 'new' to 'open'
  Wed Jan 03 23:36:24 2007 bwarfield [...] cpan.org - Severity Normal added
  Wed Jan 03 23:36:25 2007 bwarfield [...] cpan.org - Broken in 1.4308 added
  Thu Jan 04 13:43:08 2007 jjanes [...] gnf.org - Correspondence added
Subject: RE: [rt.cpan.org #23755] x_tick_number ignored
Date: Thu, 4 Jan 2007 10:42:35 -0800
To: <bug-GDGraph [...] rt.cpan.org>
From: "Jeff Janes" <jjanes [...] gnf.org>
The script is quite large, but most of it is just a patched copy of a sub from GD. Thanks, Jeff Show quoted text
-----Original Message----- From: Benjamin Warfield via RT [mailto:bug-GDGraph@rt.cpan.org] Sent: Wednesday, January 03, 2007 8:29 PM To: Jeff Janes Subject: [rt.cpan.org #23755] x_tick_number ignored <URL: http://rt.cpan.org/Ticket/Display.html?id=23755 > If you could attach a script or snippet that demonstrates the problem you're describing (and optionally the output of that script), it would simplify my life somewhat, and probably improve the chances of my getting to this sometime in the finite future. That said, your diagnosis looks pretty plausible--I'll have to double-check that we're not both missing something important about that section, but I'd guess it's just a copy-paste error.
Download my_fix.png
image/png 1k

Message body is not shown because sender requested not to inline it.

Download as_is.png
image/png 1k

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

  Thu Apr 26 11:20:51 2007 bwarfield [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Apr 26 11:20:55 2007 bwarfield [...] cpan.org - Fixed in 1.44 added