Skip Menu |

This queue is for tickets about the XML-Atom CPAN distribution.

Report information
The Basics
Id: 23595
Status: open
Priority: 0/
Queue: XML-Atom
People
Owner: Nobody in particular
Requestors: SMPETERS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.23
Fixed in: (no value)

History Show all quoted text
  Fri Nov 24 14:44:03 2006 SMPETERS [...] cpan.org - Ticket created
Subject: [PATCH] XML::Atom::Base warns from tests for XML::Feed
While testing XML::Feed with bleadperl, the following warnings came out of t/04-splice.t t/04-splice...........ok 1/3Use of uninitialized value $val in subroutine entry at /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm line 109. Use of uninitialized value $val in subroutine entry at /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm line 109. The following patch seems to silence the warnings while keeping the tests passing. --- lib/XML/Atom/Base.pm.old 2006-11-24 13:38:51.000000000 -0600 +++ lib/XML/Atom/Base.pm 2006-11-24 13:38:02.000000000 -0600 @@ -81,6 +81,7 @@ sub set { my $obj = shift; my($ns, $name, $val, $attr, $add) = @_; + return $val if ! defined $val; my $ns_uri = ref $ns eq 'XML::Atom::Namespace' ? $ns->{uri} : $ns; my @elem = childlist($obj->elem, $ns_uri, $name); if (!$add && @elem) {
  Fri Nov 24 16:47:56 2006 miyagawa [...] gmail.com - Correspondence added
CC: ben [...] sixapart.com
Subject: Re: [rt.cpan.org #23595] [PATCH] XML::Atom::Base warns from tests for XML::Feed
Date: Fri, 24 Nov 2006 13:47:04 -0800
To: bug-XML-Atom [...] rt.cpan.org
From: "Tatsuhiko Miyagawa" <miyagawa [...] gmail.com>
Thanks, but i'm not sure if it is a right behavior to just ignore setting undef values. Ben, what do you think? On 11/24/06, via RT <bug-XML-Atom@rt.cpan.org> wrote: Show quoted text
> > Fri Nov 24 14:44:03 2006: Request 23595 was acted upon. > Transaction: Ticket created by SMPETERS > Queue: XML-Atom > Subject: [PATCH] XML::Atom::Base warns from tests for XML::Feed > Broken in: 0.23 > Severity: (no value) > Owner: Nobody > Requestors: SMPETERS@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=23595 > > > > While testing XML::Feed with bleadperl, the following warnings came out > of t/04-splice.t > > t/04-splice...........ok 1/3Use of uninitialized value $val in > subroutine entry at /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm > line 109. > Use of uninitialized value $val in subroutine entry at > /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm line 109. > > The following patch seems to silence the warnings while keeping the > tests passing. > > --- lib/XML/Atom/Base.pm.old 2006-11-24 13:38:51.000000000 -0600 > +++ lib/XML/Atom/Base.pm 2006-11-24 13:38:02.000000000 -0600 > @@ -81,6 +81,7 @@ > sub set { > my $obj = shift; > my($ns, $name, $val, $attr, $add) = @_; > + return $val if ! defined $val; > my $ns_uri = ref $ns eq 'XML::Atom::Namespace' ? $ns->{uri} : $ns; > my @elem = childlist($obj->elem, $ns_uri, $name); > if (!$add && @elem) { > >
-- Tatsuhiko Miyagawa
  Fri Nov 24 16:47:57 2006 The RT System itself - Status changed from 'new' to 'open'
  Fri Nov 24 21:07:33 2006 steve [...] fisharerojo.org - Correspondence added
CC: SMPETERS [...] cpan.org
Subject: Re: [rt.cpan.org #23595] [PATCH] XML::Atom::Base warns from tests for XML::Feed
Date: Fri, 24 Nov 2006 20:07:10 -0600
To: "miyagawa [...] gmail.com via RT" <bug-XML-Atom [...] rt.cpan.org>
From: Steve Peters <steve [...] fisharerojo.org>
On Fri, Nov 24, 2006 at 04:47:58PM -0500, miyagawa@gmail.com via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=23595 > > > Thanks, > > but i'm not sure if it is a right behavior to just ignore setting > undef values. Ben, what do you think? >
No problem :) I wasn't sure what the right behavior is, but I do know that returning the undef works. Whatever works best for you should be fine. Also, if you want me to test anything out, please let me know. Thanks, Steve Peters steve@fisharerojo.org Show quoted text
> On 11/24/06, via RT <bug-XML-Atom@rt.cpan.org> wrote:
> > > > Fri Nov 24 14:44:03 2006: Request 23595 was acted upon. > > Transaction: Ticket created by SMPETERS > > Queue: XML-Atom > > Subject: [PATCH] XML::Atom::Base warns from tests for XML::Feed > > Broken in: 0.23 > > Severity: (no value) > > Owner: Nobody > > Requestors: SMPETERS@cpan.org > > Status: new > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=23595 > > > > > > > While testing XML::Feed with bleadperl, the following warnings came out > > of t/04-splice.t > > > > t/04-splice...........ok 1/3Use of uninitialized value $val in > > subroutine entry at /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm > > line 109. > > Use of uninitialized value $val in subroutine entry at > > /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm line 109. > > > > The following patch seems to silence the warnings while keeping the > > tests passing. > > > > --- lib/XML/Atom/Base.pm.old 2006-11-24 13:38:51.000000000 -0600 > > +++ lib/XML/Atom/Base.pm 2006-11-24 13:38:02.000000000 -0600 > > @@ -81,6 +81,7 @@ > > sub set { > > my $obj = shift; > > my($ns, $name, $val, $attr, $add) = @_; > > + return $val if ! defined $val; > > my $ns_uri = ref $ns eq 'XML::Atom::Namespace' ? $ns->{uri} : $ns; > > my @elem = childlist($obj->elem, $ns_uri, $name); > > if (!$add && @elem) { > > > >
> > > -- > Tatsuhiko Miyagawa
  Tue Nov 28 19:15:19 2006 steve [...] fisharerojo.org - Correspondence added
CC: SMPETERS [...] cpan.org
Subject: Re: [rt.cpan.org #23595] [PATCH] XML::Atom::Base warns from tests for XML::Feed
Date: Tue, 28 Nov 2006 18:14:46 -0600
To: "steve [...] fisharerojo.org via RT" <bug-XML-Atom [...] rt.cpan.org>
From: Steve Peters <steve [...] fisharerojo.org>
On Fri, Nov 24, 2006 at 09:07:34PM -0500, steve@fisharerojo.org via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=23595 > > > On Fri, Nov 24, 2006 at 04:47:58PM -0500, miyagawa@gmail.com via RT wrote:
> > > > <URL: http://rt.cpan.org/Ticket/Display.html?id=23595 > > > > > Thanks, > > > > but i'm not sure if it is a right behavior to just ignore setting > > undef values. Ben, what do you think? > >
> No problem :) > > I wasn't sure what the right behavior is, but I do know that returning > the undef works. Whatever works best for you should be fine. Also, if > you want me to test anything out, please let me know. > > Thanks, > > Steve Peters > steve@fisharerojo.org >
> > On 11/24/06, via RT <bug-XML-Atom@rt.cpan.org> wrote:
> > > > > > Fri Nov 24 14:44:03 2006: Request 23595 was acted upon. > > > Transaction: Ticket created by SMPETERS > > > Queue: XML-Atom > > > Subject: [PATCH] XML::Atom::Base warns from tests for XML::Feed > > > Broken in: 0.23 > > > Severity: (no value) > > > Owner: Nobody > > > Requestors: SMPETERS@cpan.org > > > Status: new > > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=23595 > > > > > > > > > > While testing XML::Feed with bleadperl, the following warnings came out > > > of t/04-splice.t > > > > > > t/04-splice...........ok 1/3Use of uninitialized value $val in > > > subroutine entry at /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm > > > line 109. > > > Use of uninitialized value $val in subroutine entry at > > > /tmp/bleadperl/lib/site_perl/5.9.5/XML/Atom/Base.pm line 109. > > > > > > The following patch seems to silence the warnings while keeping the > > > tests passing. > > > > > > --- lib/XML/Atom/Base.pm.old 2006-11-24 13:38:51.000000000 -0600 > > > +++ lib/XML/Atom/Base.pm 2006-11-24 13:38:02.000000000 -0600 > > > @@ -81,6 +81,7 @@ > > > sub set { > > > my $obj = shift; > > > my($ns, $name, $val, $attr, $add) = @_; > > > + return $val if ! defined $val; > > > my $ns_uri = ref $ns eq 'XML::Atom::Namespace' ? $ns->{uri} : $ns; > > > my @elem = childlist($obj->elem, $ns_uri, $name); > > > if (!$add && @elem) { > > >
Actually, it appears that XML::RSS 1.20 is the culprit. There is some sort of regression in the API where it used to return '', but now returns undef instead. You may close this ticket while I'll open one in XML::RSS instead. Steve Peters steve@fisharerojo.org