Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVN-Notify CPAN distribution.

Report information
The Basics
Id: 23557
Status: resolved
Priority: 0/
Queue: SVN-Notify

People
Owner: Nobody in particular
Requestors: lsilverman [...] trackabout.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 2.67



Subject: BUG w/fix: Long single-line log messages are unreadable in Outlook 2003
Date: Wed, 22 Nov 2006 14:45:18 -0500
To: <bug-SVN-Notify [...] rt.cpan.org>
From: "Larry Silverman" <lsilverman [...] trackabout.com>
Download Outlook.jpg
image/jpeg 23.6k
Outlook.jpg
Here's a screenshot of what I'm talking about: In this particular case, the checkin log message contained a single long line of text with no trailing carriage return. In Html.pm, the Log Message is being formatted using a pre tag, and the CSS speficies the pre tag should use overflow:auto. When viewing the email in my copy of Outlook 2003 (I assume it's using my IE7 to render), the Log Message is completely illegibile. The horizontal scrollbar appears and completely obstructs the log message. My solution was to add an inline style to the <pre> tags surrounding the log message. I chose to use an inline style instead of modifying the CSS because this problem only affects the log message, as it's likely the only place where a single line would be rendered in pre tags. diffs and patches would almost certainly be more than one line. I could have added a new class and assigned the class to the pre tag also. Anyway, the only change is to set style="word-wrap: break-word". This allows wrapping. This effectively eliminates the horizontal scrollbar altogether, allowing the log message to wrap. For me, that's just fine, since there's no great benefit to preventing a Log Message from wrapping. I'm not a fan of the horizontal scrollbars to begin with. Hope this helps, Larry Silverman Chief Technology Officer TrackAbout, Inc. www.trackabout.com
Subject: Re: [rt.cpan.org #23557] BUG w/fix: Long single-line log messages are unreadable in Outlook 2003
Date: Mon, 27 Nov 2006 09:49:04 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: "David E. Wheeler" <david [...] kineticode.com>
On Nov 22, 2006, at 11:46, Larry Silverman via RT wrote: Show quoted text
> Anyway, the only change is to set style="word-wrap: break-word". This > allows wrapping. > > This effectively eliminates the horizontal scrollbar altogether, > allowing the log message to wrap. For me, that's just fine, since > there's no great benefit to preventing a Log Message from > wrapping. I'm > not a fan of the horizontal scrollbars to begin with.
Hrm. This word-wrap is an IE-only invention, AFAICT. I wonder if the same thing could be done using CSS used by other browsers…doesn't look like it: http://www.codingforums.com/archive/index.php?t-60068.html Best, David
On Mon Nov 27 12:49:28 2006, david@kineticode.com wrote: Show quoted text
> Hrm. This word-wrap is an IE-only invention, AFAICT. I wonder if the > same thing could be done using CSS used by other browsers…doesn't > look like it: > > http://www.codingforums.com/archive/index.php?t-60068.html
I've added a new option, in response to Ticket #24138. This new option, --wrap-log, puts the log message into <p> tags instead of <pre>. I think that this new option will solve your problem. Watch for a release in the next few days. Best, David
On Tue Mar 27 02:50:58 2007, DWHEELER wrote: Show quoted text
> I've added a new option, in response to Ticket #24138. This new option, > --wrap-log, puts the log message into <p> tags instead of <pre>. I think > that this new option will solve your problem. Watch for a release in the > next few days.
And I've just improved it so that it tries to identify individual paragraphs, instead of wrapping the entire log message in a single paragraph. Look for that improvement in a new release in the next few days. Best, David