Bug #23529 for Test-CheckManifest: Ignore .svn directory contents (or by filter)

Tue Nov 21 21:52:52 2006 claco [...] cpan.org - Ticket created

Subject:

Ignore .svn directory contents (or by filter)

Now that I can specify directories to ignore (thanks!), It's now complaining about .svn directory contents. IT would be nice to change those excludes to filters: ['/t/var', '*.svn']. -- peline/.svn/text-base/WriteToStash.pm.svn-base, C:/Development/CPAN/Handel/t/lib/Handel/TestPlugins/.svn/entries, C:/Development/CPAN/Hande /t/lib/Handel/TestPlugins/.svn/format, C:/Development/CPAN/Handel/t/lib/Handel/TestPlugins/.svn/prop-base/First.pm.svn-base, C:/Development CPAN/Handel/t/lib/Handel/TestPlugins/.svn/text-base/First.pm.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/all-wcprops, C:/Development/CP N/Handel/t/sql/.svn/entries, C:/Development/CPAN/Handel/t/sql/.svn/format, C:/Development/CPAN/Handel/t/sql/.svn/prop-base/cart_create_tabl .sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/prop-base/cart_delete_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/prop-ba e/cart_fake_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/prop-base/order_create_table.sql.svn-base, C:/Development/CPAN/Handel/ /sql/.svn/prop-base/order_delete_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/prop-base/order_fake_data.sql.svn-base, C:/Develo ment/CPAN/Handel/t/sql/.svn/prop-base/test.sqlite.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/cart_create_table.sql.svn-b se, C:/Development/CPAN/Handel/t/sql/.svn/text-base/cart_delete_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/cart_fak _data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/order_create_table.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/ ext-base/order_delete_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/order_fake_data.sql.svn-base, C:/Development/CPAN/ andel/t/sql/.svn/text-base/test.sqlite.sql.svn-base # Looks like you failed 1 test of 1. t/manifest....dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 1 Failed 1/1 tests, 0.00% okay Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/manifest.t 1 256 1 1 1

Tue Nov 21 21:57:31 2006 claco [...] chrislaco.com - Correspondence added

CC:	CLACO [...] cpan.org
Subject:	Re: [rt.cpan.org #23529] AutoReply: Ignore .svn directory contents (or by filter)
Date:	Tue, 21 Nov 2006 21:56:33 -0500
To:	bug-Test-CheckManifest [...] rt.cpan.org
From:	"Christopher H. Laco" <claco [...] chrislaco.com>

Show quoted text

> Now that I can specify directories to ignore (thanks!), It's now > complaining about .svn directory contents. IT would be nice to change > those excludes to filters: ['/t/var', '*.svn'].

Or maybe regexes instead: excludes => ['/t/var', qw/\.svn/] -=Chris

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Tue Nov 21 21:57:32 2006 The RT System itself - Status changed from 'new' to 'open'

Wed Nov 22 13:27:57 2006 claco [...] cpan.org - Correspondence added

From:

CLACO [...] cpan.org

On Tue Nov 21 21:57:31 2006, claco@chrislaco.com wrote: Show quoted text

> > Now that I can specify directories to ignore (thanks!), It's now > > complaining about .svn directory contents. IT would be nice to change > > those excludes to filters: ['/t/var', '*.svn'].

> > Or maybe regexes instead: > > excludes => ['/t/var', qw/\.svn/] > > -=Chris >

Here's a patch for the easy way out...ignoring .svn directories...

--- Test/CheckManifest.pm.orig Tue Nov 21 16:22:10 2006 +++ Test/CheckManifest.pm Wed Nov 22 13:19:42 2006 @@ -56,6 +56,7 @@ wanted => sub{ my $file = $File::Find::name; push(@dir_files,Cwd::realpath($file)) if -f $File::Find::name and $File::Find::name !~ m!/blib/! + and $File::Find::name !~ m!/\.svn/! and !_is_excluded($_,$arref)}},$home); #print STDERR Dumper(\@files,\@dir_files);

Thu Nov 23 17:41:12 2006 claco [...] cpan.org - Correspondence added

From:

CLACO [...] cpan.org

I just installed 0.07, and I can't get the filter to work: use Test::CheckManifest; ok_manifest({filter => [qr/\.svn/]},'Filter: \.svn'); still yields: .sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/prop-base/order_delete_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/prop-ba se/order_fake_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/prop-base/test.sqlite.sql.svn-base, C:/Development/CPAN/Handel/t/sql/ .svn/text-base/cart_create_table.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/cart_delete_data.sql.svn-base, C:/Development /CPAN/Handel/t/sql/.svn/text-base/cart_fake_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/order_create_table.sql.svn-ba se, C:/Development/CPAN/Handel/t/sql/.svn/text-base/order_delete_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/order_fa ke_data.sql.svn-base, C:/Development/CPAN/Handel/t/sql/.svn/text-base/test.sqlite.sql.svn-base # Looks like you failed 1 test of 1. t/manifest....dubious This is on win32, so there's probably something path related going on as the tests don't pass either: t/CheckManifest_Pod_Coverage....Undefined subroutine &main::all_modules called at t/CheckManifest_Pod_Coverage.t line 10. # Looks like your test died before it could output anything. t/CheckManifest_Pod_Coverage....dubious Test returned status 255 (wstat 65280, 0xff00) t/Test-CheckManifest............ok 1/10Bad data in C:\Test-CheckManifest-0.7\t at t/Test-CheckManifest.t line 20. # Looks like you planned 10 tests but only ran 2. # Looks like your test died just after 2. t/Test-CheckManifest............dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 3-10 Failed 8/10 tests, 20.00% okay Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/CheckManifest_Pod_Coverage.t 255 65280 ?? ?? ?? t/Test-CheckManifest.t 255 65280 10 16 3-10 Failed 2/4 test scripts. 8/14 subtests failed. Files=4, Tests=14, 0 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) Failed 2/4 test programs. 8/14 subtests failed. NMAKE : fatal error U1077: 'C:\WINDOWS\system32\cmd.exe' : return code '0xff' Stop.

Fri Nov 24 06:50:02 2006 RENEEB [...] cpan.org - Correspondence added

I will have a look at it this weekend. I have no windows machine at work, so I have to do it at home...

Fri Nov 24 06:50:33 2006 RENEEB [...] cpan.org - Taken

Sun Nov 26 14:02:39 2006 RENEEB [...] cpan.org - Correspondence added

I've no idea what goes wrong. I've one test in the test script with exactly that statement - and it works (either win32 and linux)

Sun Nov 26 14:05:02 2006 claco [...] chrislaco.com - Correspondence added

CC:	CLACO [...] cpan.org
Subject:	Re: [rt.cpan.org #23529] Ignore .svn directory contents (or by filter)
Date:	Sun, 26 Nov 2006 14:04:45 -0500
To:	bug-Test-CheckManifest [...] rt.cpan.org
From:	"Christopher H. Laco" <claco [...] chrislaco.com>

via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=23529 > > > I've no idea what goes wrong. I've one test in the test script with > exactly that statement - and it works (either win32 and linux) > >

Ny bet is on rel2abs, and version issues of various File::Specs on win32.... What version of perl/File::Spec are you testing under on win32?

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Sun Nov 26 14:07:17 2006 RENEEB [...] cpan.org - Correspondence added

Show quoted text

> Ny bet is on rel2abs, and version issues of various File::Specs on

win32.... Show quoted text

> > What version of perl/File::Spec are you testing under on win32? >

It's 3.12... And you?

Sun Nov 26 14:10:05 2006 claco [...] chrislaco.com - Correspondence added

CC:	CLACO [...] cpan.org
Subject:	Re: [rt.cpan.org #23529] Ignore .svn directory contents (or by filter)
Date:	Sun, 26 Nov 2006 14:09:51 -0500
To:	bug-Test-CheckManifest [...] rt.cpan.org
From:	"Christopher H. Laco" <claco [...] chrislaco.com>

via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=23529 > >

>> Ny bet is on rel2abs, and version issues of various File::Specs on

> win32....

>> What version of perl/File::Spec are you testing under on win32? >>

> > It's 3.12... And you? > > >

3.19 under 5.8.4

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Mon Nov 27 04:53:41 2006 RENEEB [...] cpan.org - Correspondence added

CLACO found the bug and it is fixed in 0.9

Mon Nov 27 04:53:42 2006 RENEEB [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #23529 for Test-CheckManifest: Ignore .svn directory contents (or by filter)

Preferred bug tracker