Skip Menu |

This queue is for tickets about the Log-Dispatch-FileRotate CPAN distribution.

Report information
The Basics
Id: 23376
Status: resolved
Worked: 10 min
Priority: 0/
Queue: Log-Dispatch-FileRotate

People
Owner: cpan [...] mlp-consulting.com.au
Requestors: Ateeq.Altaf [...] talis.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: <bug-Log-Dispatch-FileRotate [...] rt.cpan.org>
Subject: Log-Dispatch-FileRotate-1.15
Date: Thu, 16 Nov 2006 15:21:29 -0000
To: <markpf [...] mlp-consulting.com.au>
From: "Ateeq Altaf" <Ateeq.Altaf [...] talis.com>
Hi Mark I think you have a bug in your _gen_occurrence function at line 450 where you're not giving the match the $pat variable:- --- FileRotate.pm.orig 2006-11-16 15:05:42.000000000 +0000 +++ FileRotate.pm 2006-11-16 15:05:48.000000000 +0000 @@ -446,7 +446,7 @@ } else # years { - my($yrs) = m/^(\d+):/; + my($yrs) = $pat =~ m/^(\d+):/; $yrs = 1 unless $yrs; my $months = $yrs * 4 * 12; Regards Ateeq Ateeq A Altaf Technical Consultant, Talis 0870 400 5440 ateeq.altaf@talis.com The very latest from Talis read the latest news at www.talis.com/news listen to our podcasts www.talis.com/podcasts see us at these events www.talis.com/events join the discussion here www.talis.com/forums join our developer community www.talis.com/tdn and read our blogs www.talis.com/blogs Any views or personal opinions expressed within this email may not be those of Talis Information Ltd. The content of this email message and any files that may be attached are confidential, and for the usage of the intended recipient only. If you are not the intended recipient, then please return this message to the sender and delete it. Any use of this e-mail by an unauthorised recipient is prohibited.
OK your patch seems good. I'll roll it into the next version. On holidays at the moment not back for two weeks - so dont hold your breath I'll give myself a reminder to make the changes when I return. -- cheers markpf
Log-Dispatch-FileRotate-1.16 now has patch applied. -- cheers markpf