Skip Menu |

This queue is for tickets about the warnings-compat CPAN distribution.

Report information
The Basics
Id: 23117
Status: resolved
Priority: 0/
Queue: warnings-compat

People
Owner: SAPER [...] cpan.org
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.02
Fixed in: 0.03



Subject: 5.6 and up + "make install UNINST=1" == t3h broken
warnings-compat will install its own warnings.pm without regard for whether there's one already installed. On 5.6 and up this usually works because the warnings.pm in the core library shadows the crippled one installed by warnings-compat into sitelib. But if the user installs with "make install UNINST=1" the core version is deleted and Perl runs the compat version. This means things like "no warnings 'uninitalized'" mysteriously stop working. I had to debug just such a problem today. warnings-compat should check if the Perl version is >= 5.6 and if so do not install. You can accomplish this by setting PM => {} in your Makefile.PL. I also fixed the abstract generation (ABSTRACT_FROM unfortunately looks for DISTNAME not NAME) and noticed that Test::Distribution does not work with -T on in 5.8.8.
Subject: warnings.patch
==== Patch <warnings> level 1 Source: 9c88509d-e914-0410-b01c-b9530614cbfe:/local/warnings-compat:25855 Target: 9c88509d-e914-0410-b01c-b9530614cbfe:/vendor/warnings-compat:25849 Log: r25852@windhund: schwern | 2006-11-12 18:24:14 -0600 local copy of warnings-compat r25853@windhund: schwern | 2006-11-12 18:28:13 -0600 Test::Distribution is not taint safe. r25854@windhund: schwern | 2006-11-12 18:34:44 -0600 Make it so warnings-compat does not install on 5.6 and up as they already have warnings.pm and this one is crippled. r25855@windhund: schwern | 2006-11-12 18:35:29 -0600 Fix the abstract generation as the DISTNAME does not match the NAME. MakeMaker should probably use NAME or both. === t/pod.t ================================================================== --- t/pod.t (revision 25849) +++ t/pod.t (patch warnings level 1) @@ -3,4 +3,5 @@ use Test::More; eval "use Test::Pod 1.14"; plan skip_all => "Test::Pod 1.14 required for testing POD" if $@; +plan skip_all => "No POD files to test" unless Test::Pod::all_pod_files(); all_pod_files_ok(); === t/warnings.t ================================================================== --- t/warnings.t (revision 25849) +++ t/warnings.t (patch warnings level 1) @@ -1,6 +1,12 @@ #!perl -T use strict; -use Test::More tests => 18; +use Test::More; +if( $] >= 5.006 ) { + plan skip_all => "$] has its own warnings"; +} +else { + plan tests => 18; +} # warnings have been enabled by Test::Harness, so we must disable them === t/distchk.t ================================================================== --- t/distchk.t (revision 25849) +++ t/distchk.t (patch warnings level 1) @@ -1,4 +1,4 @@ -#!perl -T +#!perl use strict; use Test::More; eval "use Test::Distribution not => [qw(versions podcover use)]"; === Makefile.PL ================================================================== --- Makefile.PL (revision 25849) +++ Makefile.PL (patch warnings level 1) @@ -7,11 +7,12 @@ LICENSE => 'perl', AUTHOR => 'Sébastien Aperghis-Tramoni <sebastien@aperghis.net>', VERSION_FROM => 'lib/warnings.pm', - ABSTRACT_FROM => 'lib/warnings.pm', + ABSTRACT => 'warnings.pm emulation for perl-5.6 Perls', PREREQ_PM => { 'Test::More' => 0, }, PL_FILES => {}, + ($] >= 5.006 ? (PM => {}) : ()), dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', }, clean => { FILES => 'warnings-compat-*' }, ); ==== BEGIN SVK PATCH BLOCK ==== Version: svk 1.08 (darwin) eJyNVlFv2zYQNjCsw4S975VrVSQB5oSkSFpSUC8DmgLFkixrs70NAkVSsRBFNCQ6aVAVqLdiT91/ 3lGy0yRLiwg2TPHuvvvu45H0i+Zkd4900ynuQoK713/8kqbH0qnZU8K6UHRGl842Ie8qc2GqMOoq exqyrpbnBqytXTTKD5xsTo3zg1KdGTedEoCLB7j9HmIN26Pm0tm6DZMePnONMSHpxN6k24v8JwtJ 0rUGLD1s1piLsi1tDTQojzkHF/AnEG/nps4aa921ifpo3KnKtibz8B6Se38aQkl9gC4bo4DTFcy6 Hmkd3TuKNXBRVkCMdIfyzPjx9vHBLe+eKV/luglK9tgqaXQLa9K5nbnV266ncyspu52UguelbOqy Pm3vc+d3ObodXbYg8Nkd789ypCAVYPVWOZ9XV5kzb5w2lZM974h2lMVYRiaeaJoTrQvKSBRNIikT wTkTCvJSWOOj0Wj5/TJ/lI2WX43eZ/NK1qg9K+eZrCr0bIoeH1l0/Otz5Km2yFnkTOseo0UNry06 gRdoDqvTFPwzkKevqd3c2g1uTWT2zM+BtDdWeCh/oKuUYUokk1yQiVS5wNpww6KISB5pZtgXC2Ye YUIFkQwzgnWSYA1VyrjI6USYHEtGYgidDAV/PPl3/M0yeL8MRh+fkCc/zE1TofFJsGgNal1TKrfb j4fqDm1jdoOy2EThn2j6DPFtjAXaQm8DBM//BQOvmWxR6VpkL2u0boTHu8G7wFQAeyPQi9n6KBKD +V51htqkSlhMpOAJVdokmgtYS65ZpEwSa/FFdXivLy+gozDJsUkkliRWnE4mMgFpOAfkkK67IV7y rx/9M1rufDsocy+rHhNTnEdcsUIbRhVNDDGYFtSQIhKxNuqLrESPYGJaGCk0jyOsMI20iPKiSAqJ lZzEcUjxitaHyYfFd0s6+isZvYefZfD3GN14QMKN6y03P0fmfFFJB8cOKmyDfBljvi3QMQzajR/7 BTh+tf9q/7fs+NAHD2vin41Pq77hLXjwfrcKOshevDzYf30n99uVefNmi/yENlfg77ZQija3tu6V shciZ6KANWVSE66JElGEJaZGysLEuOiPWDi6qOhQ448GundZ1nq2qHWKUKtml6apUYcopB0TMiYU GiqlLCUMjbHAOECVVbJCys6vkC2um3Ks7PlcumBAjR6EGqckWqMOWj0v/a7JF73eZYtq65CTZe1Q C/y3V+jsIegRS9k1Z390wz5Crb1LGGlrhjxl3Tq/8yCzX2BZa7SYI9h/bmaukKwaI/VVADvywqCb DeId3QzI2tp4zqopoUWNXrPlD2LLU5qs2b4o3/ikSOaghlQOnZraNEMTDnzQ85evT45+Ptz/RP/c 36u9zc9D8qFq/21QO7OLSqN5Y3OZV1fIn0l9OLR0bt1sOwjjbl3UdEq7YRPDtX3S371p+ntdXpim ldVT0cHND8rN4G8AXMnwsliU2gfs9K2xc0fh9R0URqJLVBxznOixSQgb+xN2nGOixnnCIywIU3lh plu0+2ySqNu5MLW2zf1ZWPLQLKHgD/JL7y8q7Uv6DykIz9U= ==== END SVK PATCH BLOCK ====
Subject: Re: [rt.cpan.org #23117] 5.6 and up + "make install UNINST=1" == t3h broken
Date: Mon, 13 Nov 2006 02:47:37 +0100
To: bug-warnings-compat [...] rt.cpan.org
From: Sébastien Aperghis-Tramoni <maddingue [...] free.fr>
Show quoted text
> warnings-compat should check if the Perl version is >= 5.6 and if > so do > not install. You can accomplish this by setting PM => {} in your > Makefile.PL. > > I also fixed the abstract generation (ABSTRACT_FROM unfortunately > looks > for DISTNAME not NAME) and noticed that Test::Distribution does not > work > with -T on in 5.8.8.
Thanks, applied and uploaded on the CPAN. Show quoted text
> The uploaded file > > warnings-compat-0.03.tar.gz > > has entered CPAN as > > file: $CPAN/authors/id/S/SA/SAPER/warnings-compat-0.03.tar.gz > size: 4308 bytes > md5: 72632598b4f941300c5b81a3b5edde46
-- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.