Skip Menu |

This queue is for tickets about the File-Tail CPAN distribution.

Report information
The Basics
Id: 22903
Status: resolved
Priority: 0/
Queue: File-Tail

People
Owner: Nobody in particular
Requestors: mpapet [...] yahoo.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.99.3
Fixed in: (no value)



Subject: Fails Test on Win32
Hi, I'm using Strawberry-Perl and file::Tail doesn't pass test. It looks like you are using unixish mv for copy which win32 doesn't understand. Output follows: Show quoted text
cpan> install File::Tail
CPAN: Storable loaded ok Going to read C:\DOCUME~1\michael\LOCALS~1\Temp\1\cpan\Metadata Database was generated on Wed, 08 Nov 2006 16:24:47 GMT Running install for module File::Tail Running make for M/MG/MGRABNAR/File-Tail-0.99.3.tar.gz CPAN: Digest::SHA loaded ok CPAN: Compress::Zlib loaded ok Checksum for C:\DOCUME~1\michael\LOCALS~1\Temp\1\cpan\sources\authors\id\M\MG\MG RABNAR\File-Tail-0.99.3.tar.gz ok Scanning cache C:\DOCUME~1\michael\LOCALS~1\Temp\1\cpan\build for sizes CPAN: Archive::Tar loaded ok File-Tail-0.99.3/ File-Tail-0.99.3/META.yml File-Tail-0.99.3/t/ File-Tail-0.99.3/t/20tail.t File-Tail-0.99.3/t/30name_change.t File-Tail-0.99.3/t/10open.t File-Tail-0.99.3/select_demo File-Tail-0.99.3/Tail.pm.debug File-Tail-0.99.3/Changes File-Tail-0.99.3/logwatch File-Tail-0.99.3/MANIFEST File-Tail-0.99.3/Tail.pm File-Tail-0.99.3/Makefile.PL File-Tail-0.99.3/README Removing previously used C:\DOCUME~1\michael\LOCALS~1\Temp\1\cpan\build\File-Tai l-0.99.3 CPAN.pm: Going to build M/MG/MGRABNAR/File-Tail-0.99.3.tar.gz File::Tail will be installed without debugging information. This information isn't usefull unless you intend to tinker with the code. To install with debugging enabled, use: perl Makefile.PL LOGIT Checking if your kit is complete... Looks good Writing Makefile for File::Tail CPAN: YAML loaded ok cp Tail.pm blib\lib\File\Tail.pm C:\strawberry-perl\dmake\bin\dmake.EXE -- OK Running make test C:\strawberry-perl\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harnes s(0, 'blib\lib', 'blib\arch')" t/*.t t/10open...........NOK 5/6'mv' is not recognized as an internal or external comm and, operable program or batch file. t/10open...........FAILED tests 3-6 Failed 4/6 tests, 33.33% okay t/20tail...........NOK 2/7Use of uninitialized value in concatenation (.) or str ing at t/20tail.t line 82. t/20tail...........NOK 3/7Use of uninitialized value in concatenation (.) or str ing at t/20tail.t line 82. t/20tail...........FAILED tests 1-7 Failed 7/7 tests, 0.00% okay t/30name_change....FAILED tests 1-2 Failed 2/2 tests, 0.00% okay Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/10open.t 6 4 3-6 t/20tail.t 7 7 1-7 t/30name_change.t 2 2 1-2 Failed 3/3 test scripts. 13/15 subtests failed. Files=3, Tests=15, 147 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) Failed 3/3 test programs. 13/15 subtests failed. dmake.EXE: Error code 255, while making 'test_dynamic' C:\strawberry-perl\dmake\bin\dmake.EXE test -- NOT OK Running make install make test had returned bad status, won't install without force Failed during this command: MGRABNAR/File-Tail-0.99.3.tar.gz : make_test NO
From: SMUELLER [...] cpan.org
On Wed Nov 08 13:43:29 2006, mpapet@yahoo.com wrote: Show quoted text
> I'm using Strawberry-Perl and file::Tail doesn't pass test. It looks > like you are using unixish mv for copy which win32 doesn't understand. > Output follows:
[...] It wasn't just the "mv", there was a line-ending related bug in the module code. I fixed both problems. Since the changes affect several files, I'm too lazy to create a diff. I attached a fixed distribution which is ready to be uploaded to PAUSE. The Changes file has all of my changes documented. To the author: If you would like me to make the release for you, you can make me a co-maintainer via the PAUSE (pause.perl.org) interface. Then, I can upload the distribution for you. I'd probably do some more distribution-structure related fixes, too. Of course, you retain the copyright! Steffen
Download File-Tail-0.99.4.tar.gz
application/x-gzip 22.7k

Message body not shown because it is not plain text.

I took a look at 0.99.4. Wouldn't it be better to only use "binmode FH" on test scripts (*.t) instead of working on internal buffers, only for Win32? AFAIK, using binmode automatically cancels any platform differences.
I reread the binmode section of the doc pages several times, and from that I don't think that setting binmode on windows systems would do what we want. After all, File::Tail is meant for text files, and binmode should be set for binary files and NOT text files.