Bug #2285 for XML-RSS: encoding: doesn't escape emdashes

Tue Mar 25 17:17:19 2003 Guest - Ticket created

Subject:

doesn't escape emdashes

if an item contains an emdash character (\227), XML::RSS lets it through without escaping it. this results in non well-formed XML. since XML::RSS properly escapes other things like '<' and '&', i'm assuming that always producing well-formed output is one of the goals.

Sat Apr 26 23:28:12 2003 KELLAN [...] cpan.org - Correspondence added

Would you happen to have a sample RSS feed that shows the problem available? Thanks kellan [guest - Tue Mar 25 17:17:19 2003]: Show quoted text

> if an item contains an emdash character (\227), XML::RSS lets it > through without escaping it. this results in non well-formed XML. > since XML::RSS properly escapes other things like '<' and '&', i'm > assuming that always producing well-formed output is one of the > goals.

Sat Apr 26 23:28:31 2003 KELLAN [...] cpan.org - Taken

Sat Oct 04 00:25:59 2003 gwilliams [...] cpan.org - Correspondence added

From:

Gregory Williams

[guest - Tue Mar 25 17:17:19 2003]: Show quoted text

> if an item contains an emdash character (\227), XML::RSS lets it > through without escaping it. this results in non well-formed XML. > since XML::RSS properly escapes other things like '<' and '&', i'm > assuming that always producing well-formed output is one of the > goals.

I'm not sure if this affects the issue, but (AFAIK) \227 is only an emdash in a Microsoft codepage. The emdash in Unicode is U+2014: —. The mdash doesn't exist in ISO-8859-1.

Sun Nov 23 01:40:49 2003 KELLAN [...] cpan.org - Status changed from 'new' to 'stalled'

Mon Dec 08 09:59:59 2003 RSOD [...] cpan.org - Correspondence added

Subject:	How to duplicate this bug.
From:	perl [...] crystalflame.net

[guest - Tue Mar 25 17:17:19 2003]: Show quoted text

> if an item contains an emdash character (\227), XML::RSS lets it > through without escaping it. this results in non well-formed XML. > since XML::RSS properly escapes other things like '<' and '&', i'm > assuming that always producing well-formed output is one of the > goals.

Create a basic RSS feed with a dc:subject of "This & that", plain ASCII. Output the RSS feed using $rss->as_string. The resulting RSS feed will fail to validate as proper XML, as the '&' in the subject has not been encoded to the ASCII string '&' in the resultant RSS output. This is contrary to the documentation, which states that as_string will encode special characters. This bug is responsible for virtually all of the reported problems I've seen with XML::RSS, as well as virtually all of the resentment. May I ask why it's been stalled?

Mon Dec 08 10:00:00 2003 The RT System itself - Status changed from 'stalled' to 'open'

Tue Apr 20 22:46:47 2004 KELLAN [...] cpan.org - Subject changed from 'doesn't escape emdashes' to 'encoding: doesn't escape emdashes'

Sun Feb 05 15:26:31 2006 Guest - Correspondence added

On Mon Dec 08 09:59:59 2003, RSOD wrote: Show quoted text

> This is contrary to the documentation, which states that as_string > will encode special > characters. > > This bug is responsible for virtually all of the reported problems > I've seen with XML::RSS, > as well as virtually all of the resentment. May I ask why it's been > stalled?

Is this ever going to be fixed, or should I just s/&/&/g?

Tue Feb 14 04:51:16 2006 Guest - Ticket #17634: Ticket created

Subject:

Encoding of special characters in 'source' field of RSS 2.0 items

Special characters (e.g. '&') in the 'source' field of items are not being encoded when generating RSS 2.0, although they are being correctly encoded in the 'sourceUrl' field. It appears that '$self->encode($item->{source})' is missing in line 1234 of RSS.pm ver 1.05

Sat Mar 11 18:55:16 2006 ABH [...] cpan.org - Ticket #17634: Merged into ticket #2285

Sat Mar 11 18:55:16 2006 ABH [...] cpan.org - Merged into ticket #2285

Thu Oct 19 16:52:15 2006 ABH [...] cpan.org - Correspondence added

the source encoding is done in r7957, will be released as 1.11. (the emdashes thing should be fixed as part of the "use HTML::Entities" change, also in 1.11).

Thu Oct 19 16:52:18 2006 ABH [...] cpan.org - Status changed from 'open' to 'resolved'