Bug #22546 for Archive-Any: Don't include Test modules in your manifest

Tue Oct 24 11:59:32 2006 develop [...] traveljury.com - Ticket created

Subject:

Don't include Test modules in your manifest

Your manifest file includes Test::More and Test::Warn which forces me to install them, when I don't want to. It also uses Test::Pod::Coverage, but doesn't include it in the manifest, so the installation fails. Please make the test modules optional. If they're installed, great, otherwise skip.

Tue Oct 24 14:31:44 2006 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #22546] Don't include Test modules in your manifest
Date:	Tue, 24 Oct 2006 11:29:57 -0700
To:	bug-Archive-Any [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] gmail.com>

via RT wrote: Show quoted text

> Your manifest file includes Test::More and Test::Warn which forces me to > install them, when I don't want to. It also uses Test::Pod::Coverage, > but doesn't include it in the manifest, so the installation fails. > > Please make the test modules optional. If they're installed, great, > otherwise skip.

When you say "manifest" I think you mean "prerequisites". Archive::Any does not list any test modules in its MANIFEST file nor does it ship with them. Yes, Test::More and Test::Warn can be declared as "build_requires". Test::Pod::Coverage should be a "build_recommends" but I'm not sure if MB supports that. The pod-coverage.t should replace its "use Pod::Coverage tests => 2" with "plan tests => 2". Hop to it, Clint. :)

Tue Oct 24 14:31:44 2006 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 24 15:02:11 2006 develop [...] traveljury.com - Correspondence added

Show quoted text

> When you say "manifest" I think you mean "prerequisites". > Archive::Any does not list any test modules in its MANIFEST file nor > does it ship with them.

Sorry - I didn't look at the files, just that the installation via CPAN was (1) wanting to install Test::More and Test::Warn, and then was failing because Test::Pod::Coverage was not installed. Show quoted text

> > Yes, Test::More and Test::Warn can be declared as "build_requires".

But should it? None of the hundreds of CPAN modules I've installed have required it, why does this one? I may be completely wrong here - I'm not familiar with the Test frameworks at all... Show quoted text

> Test::Pod::Coverage should be a "build_recommends" but I'm not sure if > MB supports that. > > The pod-coverage.t should replace its "use Pod::Coverage tests => 2" > with "plan tests => 2". > > Hop to it, Clint. :)

I would but for (1) current deadlines and (2) see the above note about not knowing the Test frameworks and then see point (1) again ;) Clint

Tue Oct 24 16:05:03 2006 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #22546] Don't include Test modules in your manifest
Date:	Tue, 24 Oct 2006 13:03:36 -0700
To:	bug-Archive-Any [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] gmail.com>

via RT wrote: Show quoted text

>> Yes, Test::More and Test::Warn can be declared as "build_requires".

> > But should it? None of the hundreds of CPAN modules I've installed have > required it, why does this one? I may be completely wrong here - I'm > not familiar with the Test frameworks at all...

You're completely wrong here. :) Its hard to find a CPAN module these days which does not require Test::More. In fact, it takes some talent and effort to get anything done without having it installed so I'm curious how you managed that. The polite ones using Module::Build use build_requires but most simply require it outright. Test::Warn is slightly less pervasive but still very common. These pages have some information on that: http://cpants.perl.org/dist/Test-Simple http://cpants.perl.org/dist/Test-Warn http://cpants.perl.org/dist/Test-Pod-Coverage In the CPAN model you run the tests as part of the install process. Running the tests is optional but highly, highly recommended. All changing it to "build_requires" means is certain smart CPAN shells (CPANPLUS) will download and build the build_requires modules but not install them. Others just treat "build_requires" like a regular "requires". This often isn't worth the trouble for common testing modules as this means you have to continually rebuild the build_requires modules each time you install something. Why is installing the test modules troublesome? Show quoted text

>> Test::Pod::Coverage should be a "build_recommends" but I'm not sure if >> MB supports that. >> >> The pod-coverage.t should replace its "use Pod::Coverage tests => 2" >> with "plan tests => 2". >> >> Hop to it, Clint. :)

> > I would but for (1) current deadlines and (2) see the above note about > not knowing the Test frameworks and then see point (1) again ;) > > Clint

Sorry, what an unlikely name collision. The Clint I was referring to is CMOORE, the maintainer of Archive::Any.

Wed Oct 25 06:34:54 2006 clint [...] traveljury.com - Correspondence added

Subject:	Re: [rt.cpan.org #22546] Don't include Test modules in your manifest
Date:	Wed, 25 Oct 2006 12:33:39 +0200
To:	bug-Archive-Any [...] rt.cpan.org
From:	Clinton Gormley <clint [...] traveljury.com>

Show quoted text

> You're completely wrong here. :) > > Its hard to find a CPAN module these days which does not require > Test::More. In fact, it takes some talent and effort to get anything > done without having it installed so I'm curious how you managed that. > The polite ones using Module::Build use build_requires but most simply > require it outright. Test::Warn is slightly less pervasive but still > very common. These pages have some information on that: > http://cpants.perl.org/dist/Test-Simple > http://cpants.perl.org/dist/Test-Warn > http://cpants.perl.org/dist/Test-Pod-Coverage > > In the CPAN model you run the tests as part of the install process. > Running the tests is optional but highly, highly recommended.

What you say makes absolute sense. I tried installing Archive::Any on a different machine, and this time actually looked at the output. And of course I DO have Test::More installed. It installed Test::Warn, and then failed because of Test::POD::Coverage. I'll get back in my box now. Show quoted text

>

> >> > >> Hop to it, Clint. :)

> > > > I would but for (1) current deadlines and (2) see the above note

> about

> > not knowing the Test frameworks and then see point (1) again ;) > > > > Clint

> > Sorry, what an unlikely name collision. The Clint I was referring to > is CMOORE, the maintainer of Archive::Any.

Yeah, hop to it CLINT ;) Show quoted text

>

Show quoted text

________________________________________________________________________ Clinton Gormley clinton@traveljury.com www.TravelJury.com - For travellers, By travellers

Mon Jun 01 06:31:58 2009 cmoore [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #22546 for Archive-Any: Don't include Test modules in your manifest

Preferred bug tracker