Bug #22512 for rpm-build-perl: [PATCH] Fix for Bareword "Carp::confess" not allowed while "strict subs"

Mon Oct 23 14:04:10 2006 SMPETERS [...] cpan.org - Ticket created

Subject:

[PATCH] Fix for Bareword "Carp::confess" not allowed while "strict subs"

Currently, I'm getting errors when trying to use B::PerlReq. The error I get is that Perl is thinking Carp::confess is a bareword. Adding parentheses seems to fix the problem. My patch is attached below. --- lib/B/PerlReq.pm.old 2006-10-23 12:50:58.000000000 -0500 +++ lib/B/PerlReq.pm 2006-10-23 12:55:37.000000000 -0500 @@ -329,7 +329,7 @@ $| = 1; local $SIG{__DIE__} = sub { print STDERR "# died at $0 line $CurLine:\n# @_"; - require Carp; Carp::confess; + require Carp; Carp::confess(); }; grok_blocks(); grok_main();

Thu Oct 26 16:05:49 2006 ATOURBIN [...] cpan.org - Correspondence added

On Mon Oct 23 14:04:10 2006, SMPETERS wrote: Show quoted text

> Currently, I'm getting errors when trying to use B::PerlReq. The

error Show quoted text

> I get is that Perl is thinking Carp::confess is a bareword. Adding > parentheses seems to fix the problem. My patch is attached below.

Thanks for the report. Which version of perl do you use? Does `perl -c lib/B/PerlReq.pm' pass syntax check?

Thu Oct 26 16:05:50 2006 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 26 23:52:44 2006 ATOURBIN [...] cpan.org - Correspondence added

It looks like that with perl-5.8.x, Carp is already preloaded somewhere in BEGIN. I checked and I think it is warnings.pm. If you use recent perl-5.9.x, warnings.pm now modified to load Carp.pm as needed. So 'Carp::confess' bareword is suddenly a problem. And warnings.pm is preloaded from vars.pm, which is preloaded from File/Spec.pm. Guess what. That's cool!

Fri Nov 17 13:44:38 2006 SMPETERS [...] cpan.org - Correspondence added

From:

SMPETERS [...] cpan.org

On Thu Oct 26 23:52:44 2006, ATOURBIN wrote: Show quoted text

> It looks like that with perl-5.8.x, Carp is already preloaded > somewhere in BEGIN. I checked and I think it is warnings.pm. If you > use recent perl-5.9.x, warnings.pm now modified to load Carp.pm as > needed. So 'Carp::confess' bareword is suddenly a problem. > > And warnings.pm is preloaded from vars.pm, which is preloaded from > File/Spec.pm. Guess what. That's cool!

Yes, I did test this with Perl 5.9.5 to help make sure modules are working with bleadperl in preparation for the eventual Perl 5.10 release. You're also correct that a change in warnings.pm to stop Carp from being loaded with warnings (and lower the memory used) is the cause of this suddenly appearing.

Wed Apr 25 12:47:03 2007 ATOURBIN [...] cpan.org - Correspondence added

Fixed in 0.6.2.

Wed Apr 25 12:47:07 2007 ATOURBIN [...] cpan.org - Status changed from 'open' to 'resolved'