Bug #22506 for Template-Toolkit: [PATCH] Stash.xs fails to compile with bleadperl

Mon Oct 23 11:25:30 2006 SMPETERS [...] cpan.org - Ticket created

Subject:

[PATCH] Stash.xs fails to compile with bleadperl

A missing pair of parens causes Template-Toolkit 2.15 to fail to compile with bleadperl. The following patch fixes the problem. --- xs/Stash.xs.old 2006-10-23 10:22:37.000000000 -0500 +++ xs/Stash.xs 2006-10-23 10:23:22.000000000 -0500 @@ -499,7 +499,7 @@ } /* drop-through if not an object or method not found */ - switch SvTYPE(SvRV(root)) { + switch (SvTYPE(SvRV(root))) { case SVt_PVHV: /* HASH */ roothv = (HV *) SvRV(root);

Wed Jan 10 09:56:47 2007 SMPETERS [...] cpan.org - Correspondence added

From:

SMPETERS [...] cpan.org

On Mon Oct 23 11:25:30 2006, SMPETERS wrote: Show quoted text

> A missing pair of parens causes Template-Toolkit 2.15 to fail to compile > with bleadperl. The following patch fixes the problem. >

Actually, there is also some test code that fails an assertion, so, the following patch fixes the compilation and the test failures. --- xs/Stash.xs.old 2007-01-09 20:27:49.000000000 -0600 +++ xs/Stash.xs 2007-01-09 22:06:30.000000000 -0600 @@ -499,7 +499,7 @@ } /* drop-through if not an object or method not found */ - switch SvTYPE(SvRV(root)) { + switch (SvTYPE(SvRV(root))) { case SVt_PVHV: /* HASH */ roothv = (HV *) SvRV(root); @@ -991,7 +991,7 @@ STRLEN jlen; char *joint; - if ((svp = av_fetch(args, 0, FALSE)) != NULL) { + if (args && (svp = av_fetch(args, 0, FALSE)) != NULL) { joint = SvPV(*svp, jlen); } else { joint = " ";

Wed Aug 06 08:57:54 2008 cpan [...] wardley.org - Correspondence added

This patch was applied in v2.19 and the problem appears to be fixed.

Wed Aug 06 08:57:56 2008 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 06 08:57:56 2008 cpan [...] wardley.org - Status changed from 'open' to 'resolved'