Bug #22425 for DBIx-Class-Schema-Loader: test failure

Sun Oct 22 13:44:20 2006 alexchorny [...] gmail.com - Ticket created

Subject:

test failure

ActiveState perl v5.8.7 built for MSWin32-x86-multi-thread Binary build 813 DBIx::Class 0.07002 SQL::Abstract::Limit 0.12 See attached test log. ------- Alexandr Ciornii, http://chorny.net

Subject:

error.log

Download error.log
application/octet-stream 5k

Message body not shown because it is not plain text.

Tue Oct 24 01:38:53 2006 blblack [...] gmail.com - Correspondence added

On Sun Oct 22 13:44:20 2006, alexchorny@gmail.com wrote: Show quoted text

> ActiveState perl v5.8.7 built for MSWin32-x86-multi-thread > Binary build 813 > > DBIx::Class 0.07002 > SQL::Abstract::Limit 0.12 > > See attached test log. >

Can you please make an effort to determine what the actual cause is? I don't use any Win32-like platforms, and various *nix-like platforms are reporting good on make test, so I suspect its a Win32-ism that needs to be worked around.

Tue Oct 24 01:38:54 2006 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 24 18:15:27 2006 blblack [...] gmail.com - Given to BLBLACK

Thu Oct 26 04:38:30 2006 alexchorny [...] gmail.com - Correspondence added

From:

Alexandr Ciornii <alexchorny [...] gmail.com>

Error is in $abs_dump_dir = Cwd::abs_path($self->dump_directory) if $self->dump_directory; line from DBIx::Class::Schema::Loader::Base. Cwd::abs_path == Cwd::fast_abs_path on MSWin32. It checks that directory exists. _perl_abs_path which is used on *nix has special case if directory does not exists. Patch: replace this line with use File::Spec; $abs_dump_dir = (\&Cwd::abs_path eq \&Cwd::fast_abs_path ? File::Spec->rel2abs($self->dump_directory) : Cwd::abs_path($self->dump_directory)) if $self->dump_directory; Tests pass with this line. Tested on Windows and Linux. P.S. _ensure_dump_subdirs should use File::Spec. ------- Alexandr Ciornii, http://chorny.net

Mon Nov 20 19:19:06 2006 blblack [...] gmail.com - Fixed in 0.03009 added

Mon Nov 20 19:19:31 2006 blblack [...] gmail.com - Correspondence added

Fixed in 0.03009 I'm pretty sure. Reopen if I didn't get it right :)

Mon Nov 20 19:19:33 2006 blblack [...] gmail.com - Status changed from 'open' to 'resolved'