Bug #22195 for HTML-FillInForm: [PATCH]FillInForm doesn't work properly when handling value like [0]

Wed Oct 18 23:31:00 2006 islue [...] cpan.org - Ticket created

Subject:

[PATCH]FillInForm doesn't work properly when handling value like [0]

If the $fdat is something like { foo => [0] } then it won't work as expected.

Subject:

diff.txt

diff -r HTML-FillInForm-1.06.orig/lib/HTML/FillInForm.pm HTML-FillInForm-1.06/lib/HTML/FillInForm.pm 132c132 < $value = (shift @$value || '') if ref($value) eq 'ARRAY'; --- > $value = (defined $value->[0] ? $value->[0] : '') if ref($value) eq 'ARRAY'; 135c135 < $value = (shift @$value || '') if ref($value) eq 'ARRAY'; --- > $value = (defined $value->[0] ? $value->[0] : '') if ref($value) eq 'ARRAY'; 138c138 < $value = ($value->[0] || '') if ref($value) eq 'ARRAY'; --- > $value = (defined $value->[0] ? $value->[0] : '') if ref($value) eq 'ARRAY'; 214c214 < $value = (shift @$value || '') if ref($value) eq 'ARRAY'; --- > $value = (defined $value->[0] ? $value->[0] : '') if ref($value) eq 'ARRAY';

Sun Jan 14 16:09:27 2007 alexchorny [...] gmail.com - Correspondence added

Subject:	FillInForm doesn't work properly when handling value like [0]
From:	Alexandr Ciornii <alexchorny [...] gmail.com>

On Oct 18 23:31:00 2006, ISLUE wrote: Show quoted text

> If the $fdat is something like > { foo => [0] } > then it won't work as expected.

Works in my case (HTML::FillInForm 1.06). Can you provide small example where it does not work as expected? ------- Alexandr Ciornii, http://chorny.net

Sun Jan 14 16:09:28 2007 The RT System itself - Status changed from 'new' to 'open'

Sun Feb 18 04:11:38 2007 islue [...] cpan.org - Correspondence added

The bug affects the elements below: input type text/hidden/password/radio textarea Here is an example of input type radio. -- http://islue.blogspot.com/

#!/usr/bin/perl use strict; use warnings; use HTML::FillInForm; my $fif = new HTML::FillInForm; local $/; my $html = <DATA>; my $fdat1 = { foo => 0 }; my $fdat2 = { foo => [0] }; my $output1 = $fif->fill( scalarref => \$html, fdat => $fdat1 ); my $output2 = $fif->fill( scalarref => \$html, fdat => $fdat2 ); print "$output1\n"; print "$output2\n"; __END__ <html> <body> <form> <input type="radio" name="foo" value="1"></input> <input type="radio" name="foo" value="0"></input> </form> </body> </html>

Thu Aug 02 15:18:22 2007 TJMATHER [...] cpan.org - Correspondence added

Ended up adapting slightly different patch from Paul Miller

Thu Aug 02 15:18:41 2007 TJMATHER [...] cpan.org - Status changed from 'open' to 'resolved'