Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Email-MIME CPAN distribution.

Report information
The Basics
Id: 22142
Status: resolved
Worked: 5 min
Priority: 0/
Queue: Email-MIME
People
Owner: Nobody in particular
Requestors: bobtfish [...] bobtfish.net
jns [...] gellyfish.com
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 1.854
Fixed in: 1.855

History Show all quoted text
  Tue Oct 17 05:12:35 2006 jns [...] gellyfish.co.uk - Ticket created
Subject: as_string broken in 1.854
Hi, It appears the stringify test is failing in 1.854, probably due to a change in the private methods in Email::Simple. This should fix it: --- lib/Email/MIME.pm~ 2006-10-17 10:03:07.027808680 +0100 +++ lib/Email/MIME.pm 2006-10-17 10:03:23.636283808 +0100 @@ -17,7 +17,7 @@ sub as_string { my $self = shift; - return $self->__head->as_string + return $self->_headers_as_string . ($self->{mycrlf} || "\n") . $self->body_raw; }
  Tue Oct 17 17:41:25 2006 bobtfish [...] bobtfish.net - Requestor BOBTFISH added
  Tue Oct 17 17:42:27 2006 bobtfish [...] bobtfish.net - Correspondence added
I've also been bitten by this..
  Tue Oct 17 17:42:28 2006 bobtfish [...] bobtfish.net - Status changed from 'new' to 'open'
  Thu Oct 19 06:34:24 2006 ash_rtcpan [...] firemirror.com - Correspondence added 5 min
On Tue Oct 17 17:42:27 2006, BOBTFISH wrote: Show quoted text
> I've also been bitten by this..
I manged to make the tests pass by changing line 21 as follows: --- lib/Email/MIME.pm 2006-10-19 11:31:55.409304386 +0100 +++ blib/lib/Email/MIME.pm 2006-10-19 11:35:29.449304386 +0100 @@ -17,7 +17,7 @@ sub as_string { my $self = shift; - return $self->__header_as_string + return join("\n", $self->header) . ($self->{mycrlf} || "\n") . $self->body_raw; }
  Thu Oct 19 06:42:19 2006 ash_rtcpan [...] firemirror.com - Correspondence added
That prolly should have been - also the tests could do with fixing more if the previous patch worked. On Thu Oct 19 06:34:24 2006, ASH wrote: Show quoted text
> On Tue Oct 17 17:42:27 2006, BOBTFISH wrote:
> > I've also been bitten by this..
> > I manged to make the tests pass by changing line 21 as follows: > > --- lib/Email/MIME.pm 2006-10-19 11:31:55.409304386 +0100 > +++ blib/lib/Email/MIME.pm 2006-10-19 11:35:29.449304386 +0100 > @@ -17,7 +17,6 @@ > > sub as_string { > my $self = shift; > - return $self->__header_as_string > - . ($self->{mycrlf} || "\n") > + return join(($self->{mycrlf} || "\n", $self->header) > . $self->body_raw; > } > >
  Thu Oct 19 13:20:17 2006 bobtfish [...] bobtfish.net - Reference by ticket #22274 added
  Thu Oct 19 13:21:20 2006 bobtfish [...] bobtfish.net - Reference by ticket #22273 added
  Thu Oct 19 13:22:02 2006 bobtfish [...] bobtfish.net - Correspondence added
From: bobtfish [...] bobtfish.net
The changes in Email::MIME also breaks: Email::Abstract Email::MIME::Modifier Probably others...
  Fri Oct 20 09:04:09 2006 jns [...] gellyfish.com - Correspondence added
Subject: Re: [rt.cpan.org #22142] as_string broken in 1.854
Date: Fri, 20 Oct 2006 14:02:38 +0100
To: bug-Email-MIME [...] rt.cpan.org
From: Jonathan Stowe <jns [...] gellyfish.com>
On Thu, 2006-10-19 at 13:22 -0400, Tomas Doran via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=22142 > > > The changes in Email::MIME also breaks: > > Email::Abstract > Email::MIME::Modifier
Looks like this is fixed in the version of Email::MIME and Email::Simple release yesterday. /J\
  Fri Oct 20 09:07:09 2006 jns [...] gellyfish.co.uk - Fixed in 1.855 added
  Tue Nov 21 08:10:03 2006 rjbs [...] cpan.org - Correspondence added
Indeed, fixed in 1.855 -- rjbs
  Tue Nov 21 08:10:18 2006 rjbs [...] cpan.org - Status changed from 'open' to 'resolved'