Bug #22092 for RT-Client-REST: Problem with RT::Client::REST::ticket-> Comment and ill formed ticket id

Fri Oct 13 14:20:44 2006 william.george [...] vonage.com - Ticket created

CC:	"Dmitri Tikhonov" <Dmitri.Tikhonov [...] vonage.com>
Subject:	Problem with RT::Client::REST::ticket-> Comment and ill formed ticket id
Date:	Fri, 13 Oct 2006 14:20:11 -0400
To:	<bug-RT-Client-REST [...] rt.cpan.org>
From:	"William George" <william.george [...] vonage.com>

I executed a comment on a ticket with a mal-formed id in the form "xxxxxx\n". Apparently this trips up http: RT/2.0.15 200 Ok # Invalid object specification: 'ticket/1234 /comment' Ticket: 1234 Action: comment The end result is that no exception is thrown from REST for this condition (and the Comment isn't actually posted) William George Sr. Systems Architect Vonage <http://www.vonage.com/images/Vonage_Signature.jpg> | 23 Main Street | Holmdel, NJ 07733 t: (732) 333-1184 | c: (732) 718-2640 e: <mailto:william.George@vonage.com> William.George@vonage.com w: <http://www.vonage.com/> www.vonage.com NOTE: The information contained in this email message is considered confidential and proprietary to the sender and is intended solely for review and use by the named recipient. Any unauthorized review, use or distribution is strictly prohibited. If you have received this message in error, please advise the sender by reply email and delete the message.

Fri Oct 13 14:28:23 2006 DMITRI [...] cpan.org - Severity Normal added

Fri Oct 13 14:28:24 2006 DMITRI [...] cpan.org - Broken in 0.27 added

Fri Oct 13 14:29:33 2006 DMITRI [...] cpan.org - Correspondence added

Yeah, it should really throw an exception if it cannot post a comment. I will fix it in the next release. - Dmitri.

Fri Oct 13 14:29:35 2006 The RT System itself - Status changed from 'new' to 'open'

Fri Oct 13 15:36:08 2006 DMITRI [...] cpan.org - Taken

Fri Oct 13 16:38:54 2006 DMITRI [...] cpan.org - Correspondence added

This would be really easy to do only if the server did not return 'OK' status. Otherwise, we have to do funny processing of the messages and try to figure them out. Oh well, I guess that's what we have to do. - Dmitri.

Thu Apr 09 09:16:51 2009 jpierce [...] cpan.org - Correspondence added

On Fri Oct 13 16:38:54 2006, DMITRI wrote: Show quoted text

> This would be really easy to do only if the server did not return 'OK' > status. Otherwise, we have to do funny processing of the messages and > try to figure them out.

Did this happen? It's hard to tell. While there's RT::Client::REST::InvalidParameterValueException, I don't see any exceptions being called in the code.

Thu May 08 23:14:37 2014 DMITRI [...] cpan.org - Correspondence added

On Thu Apr 09 09:16:51 2009, JPIERCE wrote: Show quoted text

> Did this happen?

No. We will need to do at least two of the following. 1. See whether the latest version of RT still returns OK when invalid ID is given to it. 2. See we can reliably detect when there is RT exception when it says all is OK. This may mean parsing every response received, vast majority of which would be in vain. I do not like this approach. 3. Validate ticket ids in RT::Client::REST -- do not include newlines into URIs. This is the right thing to do anyway.

Tue Apr 10 01:30:42 2018 dean [...] fragfest.com.au - Correspondence added

idle for nearly 10 years. closing

Tue Apr 10 01:30:44 2018 dean [...] fragfest.com.au - Status changed from 'open' to 'resolved'