Show quoted text>>>>> On Wed, 03 Jan 2007 19:35:50 -0500, "Michael_G_Schwern via RT" <bug-CPAN@rt.cpan.org> said:
> FWIW I don't agree that normal CPAN shell output should be so prominent.
> It should be distinct from build output, but does not have the same
> visual priority as a warning.
We are in violent agreement. This is why I made it configurable.
Show quoted text > Could you remove the "on_white" then from both colorize_print and
> colorize_warn?
So that we really fuck up terminals that have a blue background?
Show quoted text > It looks horrid against a non-white background
This seems to be your main point. But on any default background you
will find combinations that look horrid, so we cannot always win here.
Show quoted text > and against white it isn't doing anything.
Not true on my xterm. My xterm uses a different white for the default
background than for the on_white background.
But what is more important is that "blue on_white" does an infinitely
better job on a terminal that has a blue background. Because if the
background is blue and the foreground color is blue and the on_white
is missing, then the user will not see any further output from the
shell.
Show quoted text > Bold blue and red should stand out plenty against a sane
> background.
This is why it is configurable.
The only thing I could come up with quickly is to write a small
colordemo and inject it before I ask the questions.
if ($CPAN::META->has_inst("Term::ANSIColor")) {
my $T="gYw";
print " on_ on_y ".
" on_ma on_\n";
print " on_black on_red green ellow ".
"on_blue genta on_cyan white\n";
for my $FG ("","bold","black","bold black","red","bold red","green",
"bold green","yellow","bold yellow","blue","bold blue",
"magenta","bold magenta",
"cyan","bold cyan","white","bold white"){
printf "%12s ", $FG;
for my $BG ("",map {"on_$_"} qw(black red green yellow
blue magenta cyan white)){
print $FG||$BG ? Term::ANSIColor::colored(" $T ","$FG $BG") : " $T ";
}
print "\n";
}
print "\n";
}
Yes, this seems helpful to me, it's in.
--
andreas
