Bug #21971 for Archive-Rar: Data::Dumper and Win32::Registry

Mon Oct 09 05:59:16 2006 alexchorny [...] gmail.com - Ticket created

Subject:

Data::Dumper and Win32::Registry

Please add dependency on Data::Dumper. Data::Dumper was first released with perl 5.005 and you require 5.002. Also it depends on Win32::Registry on MSWin32. MANIFEST has entries "Tar.pm" and "ptar" which are correctly missing. Also please add META.yml file. RAR.pm does not have "use strict;". ------- Alexandr Ciornii, http://chorny.net

Mon Oct 09 08:13:36 2006 smueller [...] cpan.org - Correspondence added

Hi Jean-Marc, hi Alexandr, On Mo. 09. Okt. 2006, 05:59:16, alexchorny@gmail.com wrote: Show quoted text

> Please add dependency on Data::Dumper. > Data::Dumper was first released with perl 5.005 and you require 5.002. > > Also it depends on Win32::Registry on MSWin32. > > MANIFEST has entries "Tar.pm" and "ptar" which are correctly missing. > > Also please add META.yml file. > > RAR.pm does not have "use strict;".

I fixed these issues. Of course, META.yml won't carry the Win32::Registry dependency. For details, look at the ChangeLog file of the attached archive. I updated the distribution and incremented the version. I am attaching a .tar.gz which is ready to be uploaded to PAUSE/CPAN. Jean-Marc, just in case you do not wish to further maintain the module, please tell us and make me "co-maintainer" on the PAUSE interface. I will then upload the distribution for you. You keep the copyright, of course! If you find any of this hard to understand, do not hesitate to contact me. All the best, Steffen

Download Archive-Rar-1.91.tar.gz
application/x-gzip 7.7k

Message body not shown because it is not plain text.

Mon Oct 09 08:13:38 2006 The RT System itself - Status changed from 'new' to 'open'

Mon Oct 09 09:12:33 2006 alexchorny [...] gmail.com - Correspondence added

From:

Alexandr Ciornii <alexchorny [...] gmail.com>

On Oct 09 08:13:36 2006, SMUELLER wrote: Show quoted text

> I fixed these issues.

Also was writing patch/new version. Many is similar, but some is different. * Added dependencies and license to Makefile.PL * Change error message to english * Removed "#!/usr/local/bin/perl" from Rar.pm * Corrected error in "README" * Removed duplicate $version from Rar.pm * Rewrote for "use strict" * test moved to t/ (by Steffen Mueller)

Download Archive-Rar-1.91-chorny.tar.gz
application/x-gzip 7.7k

Message body not shown because it is not plain text.

Wed Oct 11 07:56:32 2006 alexchorny [...] gmail.com - Correspondence added

Subject:	patched version
From:	Alexandr Ciornii <alexchorny [...] gmail.com>

More patches: * Converted tests to Test::Simple * Added 2 tests * Added information about Rar download site * Added data/winrar320en.hlp ------- Alexandr Ciornii, http://chorny.net

Download Archive-Rar-1.91-chorny2.tar.gz
application/x-gzip 8.1k

Message body not shown because it is not plain text.

Fri Dec 15 07:30:49 2006 smueller [...] cpan.org - Correspondence added

On Mon Oct 09 05:59:16 2006, alexchorny@gmail.com wrote: Show quoted text

> Please add dependency on Data::Dumper. > Data::Dumper was first released with perl 5.005 and you require 5.002. > > Also it depends on Win32::Registry on MSWin32. > > MANIFEST has entries "Tar.pm" and "ptar" which are correctly missing. > > Also please add META.yml file. > > RAR.pm does not have "use strict;".

I applied all of our changes and uploaded a new version of Archive::Rar to CPAN. When RT notices that I'm a co-maintainer, I'll close this ticket. Cheers, Steffen

Fri Dec 15 07:30:54 2006 smueller [...] cpan.org - Status changed from 'open' to 'resolved'