On Sun Oct 08 17:35:13 2006, kgeorge@tcpsoft.com wrote:
Show quoted text> After looking at this some more, it is still not clear what "i" should
> be in this statement:
>
> col_type= (has_statement_fields ?
> imp_sth->stmt->fields[i].type : MYSQL_TYPE_STRING);
>
> The outer loop looks like it is looping through bound parameters, but
> "i" never changes anywhere in the loop. And doesn't look like it's
> being set to anything useful earlier on (unless there is a side effect
> of a macro or something). Should it be something like this?
>
> - for (bind= imp_sth->bind,
> + for (i = 0,
> + bind= imp_sth->bind,
> fbind= imp_sth->fbind,
> bind_end= bind+DBIc_NUM_PARAMS(imp_sth);
> bind < bind_end ;
> - bind++, fbind++ )
> + bind++, fbind++, i++ )
> {
>
> This would work if the number of fields is always equal to the number of
> bound parameters. However, I don't have much (any) knowledge of the
> internal workings of this module so there's no way for me to say if
> that's the case or not.
This is a good patch! Thanks for finding this. I'm patching it into
3.0007 and 3.0007_1
RT for rt.cpan.org