Skip Menu |

This queue is for tickets about the WWW-Dict-Zdic CPAN distribution.

Report information
The Basics
Id: 21947
Status: resolved
Worked: 5 min
Priority: 0/
Queue: WWW-Dict-Zdic

People
Owner: Nobody in particular
Requestors: slanning [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: v0.0.1
Fixed in: (no value)



Subject: fix tests when perlcritic is missing
Attached is a patch for version 0.1 of WWW::Dict::Zdic to fix t/perlcritic.t in case Test::Perl::Critic is missing. Also, when I did `perl Makefile.PL`, I got a warning: Writing META.yml WARNING: VERSION takes a string/number not a version reference. Please inform the author. I believe it's referring to use version; our $VERSION = qv('0.0.1'); in lib/WWW/Dict/Zdic.pm , but I didn't submit a patch to fix it.
Subject: zdic.diff
--- t/perlcritic.t~ 2006-10-05 05:03:42.000000000 +0200 +++ t/perlcritic.t 2006-10-07 20:25:51.000000000 +0200 @@ -1,6 +1,8 @@ #!perl -if (!require Test::Perl::Critic) { +eval { require Test::Perl::Critic }; +if ($@) { + require Test::More; Test::More::plan( skip_all => "Test::Perl::Critic required for testing PBP compliance" );
From: GUGOD [...] cpan.org
Thanks for this patch. I'm aware of that VERSION warning, but I'm using the Module::Starter::PBP's template, and in version.pm's document, it says to use the exact line as I used. If I stringify it: use version; our $VERSION = qv('0.0.1') . ""; Then the warning is gone, but I don't think this make sense at all. CPAN indexer index this version number perfectly, so it seems to work just fine. :/
patched.