Bug #21904 for perl-ldap: Trouble reading entrys from *.LDIF files with /n/r line endings

BTW, I found a better workaround. If you are on a modern Perl there is the excellent module "PerlIO::eol" which is a IO layer to normalize line terminators. You can do something like: use PerlIO::eol; my $fh = IO::File->new(); fh->open("< dos_lf.ldif") binmode $fh, ":raw:eol(LF)"; my $ldif = Net::LDAP::LDIF->new( $fh ); And everything just works. I think this would work with Mac style line terms as well. I created a new test against the preceeding attached files that shows this in action. It doesn't screw things up if the LF are already unix style but fixes up any trouble with DOS style. Not sure if this will help updating this module since PerlIO::eol only works on modern perls and I think you might want Net::LDAP::LDIF to work on older perls as well. But maybe could help others running into this problem. Thank you for making my job easier :) --John

#!perl use strict; use warnings; use Test::More tests => 12; use_ok('Net::LDAP::LDIF'); use_ok('IO::File'); use_ok('PerlIO::eol'); CHECK_UNIX: { my $fh = IO::File->new(); ok( $fh->open("< unix_lf.ldif"), "Openning the unix test file."); my $ldif = Net::LDAP::LDIF->new( $fh ); my @contacts; while( not $ldif->eof ) { my $entry = $ldif->read_entry; push @contacts, { email => [($entry->get_value('mail'))], name => [($entry->get_value('cn'))], }; } is( $#contacts, 7, "Checking to make sure we get the correct number of entries."); $fh->close; } CHECK_UNIX_WITH_CONVERT: { my $fh = IO::File->new(); ok( $fh->open("< unix_lf.ldif"), "Openning the unix test file."); binmode $fh, ":raw:eol(LF)"; my $ldif = Net::LDAP::LDIF->new( $fh ); my @contacts; while( not $ldif->eof ) { my $entry = $ldif->read_entry; push @contacts, { email => [($entry->get_value('mail'))], name => [($entry->get_value('cn'))], }; } is( $#contacts, 7, "Checking to make sure we get the correct number of entries."); $fh->close; } CHECK_DOS_WITH_CONVERT: { my $fh = IO::File->new(); ok( $fh->open("< dos_lf.ldif"), "Openning the unix test file with the eol(LF) converted."); binmode $fh, ":raw:eol(LF)"; my $ldif = Net::LDAP::LDIF->new( $fh ); my @contacts; while( not $ldif->eof ) { my $entry = $ldif->read_entry; push @contacts, { email => [($entry->get_value('mail'))], name => [($entry->get_value('cn'))], }; } is( $#contacts, 7, "Checking to make sure we get the correct number of entries"); } CHECK_DOS: { my $fh = IO::File->new(); ok( $fh->open("< dos_lf.ldif"), "Openning the dos test file, no preconversion attempted."); my $ldif = Net::LDAP::LDIF->new( $fh ); my @contacts; while( not $ldif->eof ) { my $entry = $ldif->read_entry; push @contacts, { email => [($entry->get_value('mail'))], name => [($entry->get_value('cn'))], }; } is( $#contacts, 7, "Checking to make sure we get the correct number of entries"); $fh->close; }