Skip Menu |

This queue is for tickets about the Win32-File-VersionInfo CPAN distribution.

Report information
The Basics
Id: 21867
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Win32-File-VersionInfo
People
Owner: alexeyt [...] cpan.org
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.03
Fixed in: (no value)

History Show all quoted text
  Tue Oct 03 05:46:36 2006 RURBAN [...] cpan.org - Ticket created
Subject: cygwin patch
Attached patch fixes compilation under cygwin -- http://rurban.xarch.at/
Subject: cygwin.patch
--- Win32-File-VersionInfo-0.03/Makefile.PL.orig 2003-10-20 10:53:00.000000000 +0100 +++ Win32-File-VersionInfo-0.03/Makefile.PL 2006-10-03 11:39:17.343750000 +0100 @@ -8,7 +8,9 @@ ($] >= 5.005 ? ## Add these new keywords supported since 5.005 (ABSTRACT_FROM => 'VersionInfo.pm', # retrieve abstract from module AUTHOR => 'Alexey Toptygin <alexeyt@cpan.org>') : ()), - 'LIBS' => [''], # e.g., '-lm' + ($^O eq 'cygwin' ? + ('MYEXTLIB' => "/usr/lib/w32api/libversion.a") + : ()), 'DEFINE' => '', # e.g., '-DHAVE_SOMETHING' # Insert -I. if you add *.h files later: 'INC' => '', # e.g., '-I/usr/include/other' --- Win32-File-VersionInfo-0.03/VersionInfo.xs.orig 2004-05-01 17:17:52.000000000 +0100 +++ Win32-File-VersionInfo-0.03/VersionInfo.xs 2006-10-03 11:02:33.328125000 +0100 @@ -1,6 +1,7 @@ #include "EXTERN.h" #include "perl.h" #include "XSUB.h" +#include <windows.h> #include <winver.h> MODULE = Win32::File::VersionInfo PACKAGE = Win32::File::VersionInfo
  Tue Oct 03 14:37:24 2006 alexeyt [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #21867] cygwin patch
Date: Tue, 3 Oct 2006 18:37:01 +0000 (UTC)
To: Reini Urban via RT <bug-Win32-File-VersionInfo [...] rt.cpan.org>
From: Alexey Toptygin <alexeyt [...] cpan.org>
On Tue, 3 Oct 2006, Reini Urban via RT wrote: Show quoted text
> Attached patch fixes compilation under cygwin
You're right, but it should actually be including windows.h instead of winver.h, and libversion.a should always be explicitly linked, not just under cygwin. I'll make these changes for 0.04, which is also going to include a rewrite of the variable string part processing, to get around deficiencies in the MS API (so it'll be a little while). Do you mind testing prereleases of 0.04 when they're avalable? Alexey
  Tue Oct 03 14:37:26 2006 The RT System itself - Status changed from 'new' to 'open'
  Tue Oct 03 14:38:03 2006 alexeyt [...] cpan.org - Taken
  Tue Oct 22 12:27:22 2013 BRAD [...] cpan.org - Correspondence added 30 min
Version 0.04 uploaded; this has been tested against Cygwin and Strawberry Perl.
  Tue Oct 22 12:27:22 2013 BRAD [...] cpan.org - Status changed from 'open' to 'resolved'