Bug #21793 for POE-Component-Client-HTTP: big bug with incorrect urls in POE::Component::Client::HTTP

Sat Sep 30 20:44:22 2006 samlowry [...] e-baka.net - Ticket created

Subject:	big bug with incorrect urls in POE::Component::Client::HTTP
Date:	Sun, 1 Oct 2006 01:49:13 +0400
To:	rcaputo [...] cpan.org
From:	samlowry <samlowry [...] e-baka.net>

Hello! I have big trouble with POE::Component::Client::HTTP on bad urls. For example: http://www.royal4net.net/ redirect me to http:/// suspended.page/ then I get croak 'Must include a 'host' in Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ Client/DNS.pm line 112'. Do you can to add to POE::Component::Client::HTTP some verifying of urls?

Tue Oct 17 02:58:32 2006 RCAPUTO [...] cpan.org - Correspondence added

On Sat Sep 30 20:44:22 2006, samlowry@e-baka.net wrote: Show quoted text

> Hello! > I have big trouble with POE::Component::Client::HTTP on bad urls. > For example: http://www.royal4net.net/ redirect me to http:/// > suspended.page/ then I get croak 'Must include a 'host' in > Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ > Client/DNS.pm line 112'. Do you can to add to > POE::Component::Client::HTTP some verifying of urls?

The croak() is bad. I'll see whether I can do something about that. But verifying hosts is going to be hard--- the best way to do it is to ask DNS for an address... and that croaks! :)

Tue Oct 17 02:58:33 2006 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 17 10:23:02 2006 samlowry [...] e-baka.net - Correspondence added

Subject:	Re: [rt.cpan.org #21793] big bug with incorrect urls in POE::Component::Client::HTTP
Date:	Tue, 17 Oct 2006 21:15:53 +0700
To:	bug-POE-Component-Client-HTTP [...] rt.cpan.org
From:	samlowry <samlowry [...] e-baka.net>

You can pre-verify url for presense of default parts - hostname, scheme... (scheme://host). On 10/17/06, via RT <bug-POE-Component-Client-HTTP@rt.cpan.org> wrote: Show quoted text

> > > <URL: http://rt.cpan.org/Ticket/Display.html?id=21793 > > > On Sat Sep 30 20:44:22 2006, samlowry@e-baka.net wrote:

> > Hello! > > I have big trouble with POE::Component::Client::HTTP on bad urls. > > For example: http://www.royal4net.net/ redirect me to http:/// > > suspended.page/ then I get croak 'Must include a 'host' in > > Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ > > Client/DNS.pm line 112'. Do you can to add to > > POE::Component::Client::HTTP some verifying of urls?

> > > The croak() is bad. I'll see whether I can do something about that. > But verifying hosts is going to be hard--- the best way to do it is to > ask DNS for an address... and that croaks! :) >

Thu Oct 19 01:14:33 2006 RCAPUTO [...] cpan.org - Correspondence added

On Sat Sep 30 20:44:22 2006, samlowry@e-baka.net wrote: Show quoted text

> Hello! > I have big trouble with POE::Component::Client::HTTP on bad urls. > For example: http://www.royal4net.net/ redirect me to http:/// > suspended.page/ then I get croak 'Must include a 'host' in > Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ > Client/DNS.pm line 112'. Do you can to add to > POE::Component::Client::HTTP some verifying of urls?

Your error message doesn't make sense. The croak() on line 112 should not be repording line 112. Instead it should be reporting the file and line that called resolve(). Please send a test case.

Mon Oct 30 11:47:12 2006 Kikudjiro [...] yandex.ru - Correspondence added

CC:	samlowry [...] e-baka.net
Subject:	[rt.cpan.org #21793]
Date:	Mon, 30 Oct 2006 19:46:03 +0300 (MSK)
To:	bug-POE-Component-Client-HTTP [...] rt.cpan.org
From:	"Alexander Alexeychuk" <Kikudjiro [...] yandex.ru>

Hello! So, in sub poco_weeble_request { in line: unless ($supported_schemes{$http_request->uri->scheme}) { we added: unless ($supported_schemes{$http_request->uri->scheme} && $http_request->uri->host()) { to avoid requests with null (bad) domain names. uri->host() returns nothing in case of bad domain name. Thanks, Alex

Sat Feb 10 02:50:01 2007 RCAPUTO [...] cpan.org - Correspondence added

Oh, I totally misunderstood the original bug. Fix applied as revision 309, which will appear in version 0.82.

Sat Feb 10 02:50:08 2007 RCAPUTO [...] cpan.org - Status changed from 'open' to 'resolved'